yenru0/EhViewer
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixup! Fix a itemTouchHelper rv leak

Browse Source
This commit is contained in:
tarsin committed 2023-07-12 15:51:07 +08:00
1 parent 1c88be6f82
commit 203c89e3a8
1 file changed
+28 -47
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/java/com/hippo/ehviewer/ui/scene/DownloadsScene.kt
+28 -47
View File
@@ -299,6 +299,34 @@ class DownloadsScene :
recyclerView.scrollToPosition(mInitPosition)
mInitPosition = -1
}
val itemTouchHelper = ItemTouchHelper(object : ItemTouchHelper.Callback() {
override fun getMovementFlags(recyclerView: RecyclerView, viewHolder: RecyclerView.ViewHolder): Int {
return makeMovementFlags(ItemTouchHelper.UP or ItemTouchHelper.DOWN, 0)
}
override fun onMove(
recyclerView: RecyclerView,
viewHolder: RecyclerView.ViewHolder,
target: RecyclerView.ViewHolder,
): Boolean {
val fromPosition = viewHolder.bindingAdapterPosition
val toPosition = target.bindingAdapterPosition
if (fromPosition == toPosition) {
return false
}
lifecycleScope.launchIO {
when (mLabel) {
null -> DownloadManager.moveDownload(fromPosition, toPosition)
getString(R.string.default_download_label_name) -> DownloadManager.moveDownload(null, fromPosition, toPosition)
else -> DownloadManager.moveDownload(mLabel, fromPosition, toPosition)
}
withUIContext {
mAdapter!!.notifyItemMoved(fromPosition, toPosition)
}
}
return true
}
override fun onSwiped(viewHolder: RecyclerView.ViewHolder, direction: Int) {}
})
itemTouchHelper.attachToRecyclerView(recyclerView)
fastScroller.attachToRecyclerView(recyclerView)
val handlerDrawable = HandlerDrawable()
@@ -327,7 +355,6 @@ class DownloadsScene :
binding.recyclerView.stopScroll()
removeAboveSnackView(binding.fabLayout)
(binding.fabLayout.parent as ViewGroup).removeView(binding.fabLayout)
itemTouchHelper.attachToRecyclerView(null)
mViewTransition = null
mAdapter = null
_binding = null
@@ -1186,52 +1213,6 @@ class DownloadsScene :
}
}
private val itemTouchHelper = ItemTouchHelper(object : ItemTouchHelper.Callback() {
override fun getMovementFlags(
recyclerView: RecyclerView,
viewHolder: RecyclerView.ViewHolder,
): Int {
return makeMovementFlags(
ItemTouchHelper.UP or ItemTouchHelper.DOWN,
0,
)
}
override fun onMove(
recyclerView: RecyclerView,
viewHolder: RecyclerView.ViewHolder,
target: RecyclerView.ViewHolder,
): Boolean {
val fromPosition = viewHolder.bindingAdapterPosition
val toPosition = target.bindingAdapterPosition
if (fromPosition == toPosition) {
return false
}
lifecycleScope.launchIO {
when (mLabel) {
null -> {
DownloadManager.moveDownload(fromPosition, toPosition)
}
getString(R.string.default_download_label_name) -> {
DownloadManager.moveDownload(null, fromPosition, toPosition)
}
else -> {
DownloadManager.moveDownload(mLabel, fromPosition, toPosition)
}
}
withUIContext {
mAdapter!!.notifyItemMoved(fromPosition, toPosition)
}
}
return true
}
override fun onSwiped(viewHolder: RecyclerView.ViewHolder, direction: Int) {
}
})
companion object {
const val KEY_GID = "gid"
const val KEY_ACTION = "action"