From 283e8f20b3c63c7b31fa8cda4c60e7bb55ae575a Mon Sep 17 00:00:00 2001
From: FooIbar <118464521+FooIbar@users.noreply.github.com>
Date: Sat, 11 Feb 2023 20:29:02 +0800
Subject: [PATCH] Show image limits in preference summary

---
 .../preference/ImageLimitsPreference.kt       | 39 ++++++++++++++-----
 1 file changed, 30 insertions(+), 9 deletions(-)

diff --git a/app/src/main/java/com/hippo/ehviewer/preference/ImageLimitsPreference.kt b/app/src/main/java/com/hippo/ehviewer/preference/ImageLimitsPreference.kt
index 12efdd8ca..ce2f39680 100644
--- a/app/src/main/java/com/hippo/ehviewer/preference/ImageLimitsPreference.kt
+++ b/app/src/main/java/com/hippo/ehviewer/preference/ImageLimitsPreference.kt
@@ -6,7 +6,6 @@ import android.util.AttributeSet
 import android.view.View
 import android.widget.Button
 import androidx.appcompat.app.AlertDialog
-import androidx.lifecycle.LifecycleCoroutineScope
 import androidx.lifecycle.lifecycleScope
 import com.hippo.ehviewer.R
 import com.hippo.ehviewer.client.EhEngine
@@ -21,12 +20,20 @@ class ImageLimitsPreference(context: Context, attrs: AttributeSet) :
     DialogPreference(context, attrs), View.OnClickListener {
     private val mActivity = context as SettingsActivity
     private val placeholder = context.getString(R.string.please_wait)
-    private lateinit var coroutineScope: LifecycleCoroutineScope
+    private val coroutineScope = mActivity.lifecycleScope
     private lateinit var resetButton: Button
     private lateinit var mDialog: AlertDialog
     private lateinit var mLimits: HomeParser.Limits
     private lateinit var mFunds: HomeParser.Funds
 
+    init {
+        coroutineScope.launchIO {
+            getImageLimits {
+                summary = "${mLimits.current} / ${mLimits.maximum}"
+            }
+        }
+    }
+
     override fun onPrepareDialogBuilder(builder: AlertDialog.Builder) {
         super.onPrepareDialogBuilder(builder)
         builder.setMessage(placeholder)
@@ -35,28 +42,42 @@ class ImageLimitsPreference(context: Context, attrs: AttributeSet) :
     override fun onDialogCreated(dialog: AlertDialog) {
         super.onDialogCreated(dialog)
         mDialog = dialog
-        coroutineScope = dialog.lifecycleScope
         resetButton = dialog.getButton(DialogInterface.BUTTON_POSITIVE)
         resetButton.setOnClickListener(this)
         resetButton.isEnabled = false
-        coroutineScope.launchIO {
-            getImageLimits()
+        if (this::mLimits.isInitialized) {
+            bind()
+        } else {
+            coroutineScope.launchIO {
+                getImageLimits(true) {
+                    bind()
+                }
+            }
         }
     }
 
-    private suspend fun getImageLimits() {
+    override fun onDialogClosed(positiveResult: Boolean) {
+        super.onDialogClosed(positiveResult)
+        if (this::mLimits.isInitialized) {
+            summary = "${mLimits.current} / ${mLimits.maximum}"
+        }
+    }
+
+    private suspend fun getImageLimits(showError: Boolean = false, onSuccess: () -> Unit) {
         runCatching {
             EhEngine.getImageLimits()
         }.onFailure {
             it.printStackTrace()
-            withUIContext {
-                mDialog.setMessage(it.message)
+            if (showError) {
+                withUIContext {
+                    mDialog.setMessage(it.message)
+                }
             }
         }.onSuccess {
             mLimits = it.limits
             mFunds = it.funds
             withUIContext {
-                bind()
+                onSuccess()
             }
         }
     }