From 2fea94ce9b57d40bb9e84e4791b9f82efb9dc582 Mon Sep 17 00:00:00 2001
From: FooIbar <118464521+FooIbar@users.noreply.github.com>
Date: Mon, 27 Feb 2023 02:09:22 +0800
Subject: [PATCH] fixup! Implement image request merging in standalone
 Interceptor

---
 .../java/com/hippo/ehviewer/EhApplication.kt  |  2 ++
 .../hippo/ehviewer/coil/MergeInterceptor.kt   | 29 ++++++++++---------
 .../java/com/hippo/widget/LoadImageView.kt    |  9 ++++--
 3 files changed, 25 insertions(+), 15 deletions(-)

diff --git a/app/src/main/java/com/hippo/ehviewer/EhApplication.kt b/app/src/main/java/com/hippo/ehviewer/EhApplication.kt
index 88f85978e..2d4ae32f0 100644
--- a/app/src/main/java/com/hippo/ehviewer/EhApplication.kt
+++ b/app/src/main/java/com/hippo/ehviewer/EhApplication.kt
@@ -27,6 +27,7 @@ import androidx.lifecycle.LifecycleOwner
 import androidx.lifecycle.ProcessLifecycleOwner
 import coil.ImageLoader
 import coil.ImageLoaderFactory
+import coil.util.DebugLogger
 import com.hippo.Native
 import com.hippo.ehviewer.client.EhCookieStore
 import com.hippo.ehviewer.client.EhDns
@@ -186,6 +187,7 @@ class EhApplication : Application(), DefaultLifecycleObserver, ImageLoaderFactor
             okHttpClient(okHttpClient)
             components { add(MergeInterceptor) }
             crossfade(300)
+            if (BuildConfig.DEBUG) logger(DebugLogger())
         }.build()
     }
 
diff --git a/app/src/main/java/com/hippo/ehviewer/coil/MergeInterceptor.kt b/app/src/main/java/com/hippo/ehviewer/coil/MergeInterceptor.kt
index b19548515..a67330581 100644
--- a/app/src/main/java/com/hippo/ehviewer/coil/MergeInterceptor.kt
+++ b/app/src/main/java/com/hippo/ehviewer/coil/MergeInterceptor.kt
@@ -15,7 +15,8 @@ import kotlin.coroutines.Continuation
 import kotlin.coroutines.resume
 
 object MergeInterceptor : Interceptor {
-    private val pendingContinuationMap: HashMap<String, MutableList<Continuation<Unit>>> = hashMapOf()
+    private val pendingContinuationMap: HashMap<String, MutableList<Continuation<Unit>>> =
+        hashMapOf()
     private val pendingContinuationMapLock = Mutex()
     private val notifyScope = CoroutineScope(Dispatchers.IO + SupervisorJob())
     override suspend fun intercept(chain: Interceptor.Chain): ImageResult {
@@ -23,18 +24,8 @@ object MergeInterceptor : Interceptor {
         val originListener = originRequest.listener
         val key = originRequest.data as String
         val newRequest = ImageRequest.Builder(originRequest).listener(
-            { originListener?.onStart(it) },
-            {
-                originListener?.onCancel(it)
-                notifyScope.launch {
-                    pendingContinuationMapLock.withLock {
-                        // Wake up a pending continuation to continue executing task
-                        val successor = pendingContinuationMap[key]?.removeFirstOrNull()?.apply { resume(Unit) }
-                        // If no successor, delete this entry from hashmap
-                        successor ?: pendingContinuationMap.remove(key)
-                    }
-                }
-            },
+            {},
+            {}, // Only original request's onStart and onCancel will get called
             { request, result ->
                 originListener?.onError(request, result)
                 // Wake all pending continuations since this request is to be failed
@@ -72,4 +63,16 @@ object MergeInterceptor : Interceptor {
 
         return withContext(originRequest.interceptorDispatcher) { chain.proceed(newRequest) }
     }
+
+    fun onCancel(key: String) {
+        notifyScope.launch {
+            pendingContinuationMapLock.withLock {
+                // Wake up a pending continuation to continue executing task
+                val successor =
+                    pendingContinuationMap[key]?.removeFirstOrNull()?.apply { resume(Unit) }
+                // If no successor, delete this entry from hashmap
+                successor ?: pendingContinuationMap.remove(key)
+            }
+        }
+    }
 }
\ No newline at end of file
diff --git a/app/src/main/java/com/hippo/widget/LoadImageView.kt b/app/src/main/java/com/hippo/widget/LoadImageView.kt
index 43bc3391b..e56f257f4 100644
--- a/app/src/main/java/com/hippo/widget/LoadImageView.kt
+++ b/app/src/main/java/com/hippo/widget/LoadImageView.kt
@@ -27,6 +27,7 @@ import coil.size.Size
 import com.hippo.drawable.PreciselyClipDrawable
 import com.hippo.ehviewer.EhApplication
 import com.hippo.ehviewer.R
+import com.hippo.ehviewer.coil.MergeInterceptor
 
 private val application = EhApplication.application
 private val errorDrawable = AppCompatResources.getDrawable(application, R.drawable.image_failed)
@@ -84,7 +85,10 @@ open class LoadImageView @JvmOverloads constructor(
             if (!crossfade) crossfade(false)
             listener(
                 { setRetry(false) },
-                { setRetry(true) },
+                {
+                    MergeInterceptor.onCancel(url)
+                    setRetry(true)
+                },
                 { _, _ ->
                     super.setImageDrawable(errorDrawable)
                     setRetry(true)
@@ -102,7 +106,8 @@ open class LoadImageView @JvmOverloads constructor(
         var newDrawable = drawable
         if (newDrawable != null) {
             if (Integer.MIN_VALUE != mOffsetX) {
-                newDrawable = PreciselyClipDrawable(newDrawable, mOffsetX, mOffsetY, mClipWidth, mClipHeight)
+                newDrawable =
+                    PreciselyClipDrawable(newDrawable, mOffsetX, mOffsetY, mClipWidth, mClipHeight)
             }
             onPreSetImageDrawable(newDrawable, true)
         }