From 6bfe1ba8761514730f915db42de0d1c8758bb7d4 Mon Sep 17 00:00:00 2001 From: FooIbar <118464521+FooIbar@users.noreply.github.com> Date: Fri, 20 Jan 2023 22:54:56 +0800 Subject: [PATCH] Resolve #703 --- .../com/hippo/ehviewer/ui/scene/GalleryListScene.kt | 13 ++++--------- .../com/hippo/ehviewer/ui/scene/SearchBarScene.kt | 4 ++-- app/src/main/res/layout/scene_searchbar.xml | 3 ++- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/com/hippo/ehviewer/ui/scene/GalleryListScene.kt b/app/src/main/java/com/hippo/ehviewer/ui/scene/GalleryListScene.kt index f9f8aede9..642d05d9c 100644 --- a/app/src/main/java/com/hippo/ehviewer/ui/scene/GalleryListScene.kt +++ b/app/src/main/java/com/hippo/ehviewer/ui/scene/GalleryListScene.kt @@ -401,12 +401,7 @@ class GalleryListScene : SearchBarScene(), OnDragHandlerListener, SearchLayout.H val colorID = theme.resolveColor(com.google.android.material.R.attr.colorOnSurface) mActionFabDrawable = AddDeleteDrawable(context, colorID) binding.fabLayout.primaryFab!!.setImageDrawable(mActionFabDrawable) - mSearchFab!!.setOnClickListener { - if (STATE_NORMAL != mState) { - onApplySearch() - hideSoftInput() - } - } + mSearchFab!!.setOnClickListener { onApplySearch() } // Update list url builder onUpdateUrlBuilder() @@ -701,7 +696,7 @@ class GalleryListScene : SearchBarScene(), OnDragHandlerListener, SearchLayout.H override fun onSearchViewExpanded() { super.onSearchViewExpanded() - selectSearchFab(true) + if (mState == STATE_NORMAL) selectSearchFab(true) } override fun onSearchViewHidden() { @@ -1279,11 +1274,11 @@ class GalleryListScene : SearchBarScene(), OnDragHandlerListener, SearchLayout.H return if (null != mHelper) mHelper!!.size() else 0 } - public override fun onItemClick(view: View, position: Int) { + override fun onItemClick(view: View, position: Int) { this@GalleryListScene.onItemClick(position) } - public override fun onItemLongClick(view: View, position: Int): Boolean { + override fun onItemLongClick(view: View, position: Int): Boolean { return this@GalleryListScene.onItemLongClick(position) } diff --git a/app/src/main/java/com/hippo/ehviewer/ui/scene/SearchBarScene.kt b/app/src/main/java/com/hippo/ehviewer/ui/scene/SearchBarScene.kt index fa98dcd6a..0b1493ac2 100644 --- a/app/src/main/java/com/hippo/ehviewer/ui/scene/SearchBarScene.kt +++ b/app/src/main/java/com/hippo/ehviewer/ui/scene/SearchBarScene.kt @@ -53,8 +53,6 @@ abstract class SearchBarScene : BaseScene(), ToolBarScene { updateSuggestions() } binding.searchview.editText.setOnEditorActionListener { _, _, _ -> - binding.toolbar.text = binding.searchview.text - binding.searchview.hide() onApplySearch() true } @@ -157,6 +155,8 @@ abstract class SearchBarScene : BaseScene(), ToolBarScene { } fun onApplySearch() { + binding.toolbar.text = binding.searchview.text + binding.searchview.hide() val query = binding.toolbar.text.toString().trim() if (!mAllowEmptySearch && query.isEmpty()) { return diff --git a/app/src/main/res/layout/scene_searchbar.xml b/app/src/main/res/layout/scene_searchbar.xml index 166b0dc2e..8d0fda26e 100644 --- a/app/src/main/res/layout/scene_searchbar.xml +++ b/app/src/main/res/layout/scene_searchbar.xml @@ -50,7 +50,8 @@