From 934629d829f29a636d9fc66bffc5f94ff394da0c Mon Sep 17 00:00:00 2001
From: FooIbar <118464521+FooIbar@users.noreply.github.com>
Date: Sun, 15 Oct 2023 17:16:50 +0800
Subject: [PATCH] Add lint check for marshmallow (#58)

* Add lint check for marshmallow

* Treat some warnings as errors

* Fix attribute unused on older versions
---
 .github/workflows/ci.yml                      |   3 +
 app/build.gradle.kts                          |   5 +
 app/lint-baseline.xml                         | 147 ++++++++++++++++++
 .../main/res/{xml => xml-v25}/shortcuts.xml   |   0
 4 files changed, 155 insertions(+)
 create mode 100644 app/lint-baseline.xml
 rename app/src/main/res/{xml => xml-v25}/shortcuts.xml (100%)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7c433a636..0ce261d38 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -48,6 +48,9 @@ jobs:
       - name: Spotless Check
         run: ./gradlew spotlessCheck
 
+      - name: Lint Check
+        run: ./gradlew lintMarshmallowRelease
+
       - name: CMake Cache
         uses: actions/cache@v3
         with:
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 224f3003e..c6a0a353a 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -105,6 +105,11 @@ android {
             compileOptions {
                 isCoreLibraryDesugaringEnabled = true
             }
+            lint {
+                baseline = file("lint-baseline.xml")
+                checkOnly += setOf("InlinedApi", "NewApi", "UnusedAttribute")
+                error += setOf("InlinedApi", "UnusedAttribute")
+            }
         }
     }
 
diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml
new file mode 100644
index 000000000..5607d110a
--- /dev/null
+++ b/app/lint-baseline.xml
@@ -0,0 +1,147 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.3.0-alpha07" type="baseline" client="gradle" dependencies="false" name="AGP (8.3.0-alpha07)" variant="all" version="8.3.0-alpha07">
+
+    <issue
+        id="NewApi"
+        message="Call requires API level 28 (current min is 23): `android.graphics.ImageDecoder#createSource`"
+        errorLine1="        return ImageDecoder.createSource(context.contentResolver, uri!!)"
+        errorLine2="                            ~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/unifile/Contracts.kt"
+            line="74"
+            column="29"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `installCronetHttpUriFetcher`"
+        errorLine1="                installCronetHttpUriFetcher()"
+        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/EhApplication.kt"
+            line="149"
+            column="17"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `cronetRequest`"
+        errorLine1="        cronetRequest(url, referer).execute {"
+        errorLine2="        ~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/client/EhEngine.kt"
+            line="123"
+            column="9"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `execute`"
+        errorLine1="        cronetRequest(url, referer).execute {"
+        errorLine2="                                    ~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/client/EhEngine.kt"
+            line="123"
+            column="37"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `awaitBodyFully`"
+        errorLine1="                awaitBodyFully {"
+        errorLine2="                ~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/client/EhEngine.kt"
+            line="126"
+            column="17"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires API level 28 (current min is 23): `android.graphics.ImageDecoder#createSource`"
+        errorLine1="        get() = ImageDecoder.createSource(mFile)"
+        errorLine2="                             ~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/unifile/RawFile.kt"
+            line="151"
+            column="30"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `cronetRequest`"
+        errorLine1="            cronetRequest(url, referer) {"
+        errorLine2="            ~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/spider/SpiderDen.kt"
+            line="135"
+            column="13"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `android.net.http.UrlRequest.Builder#setCacheDisabled`"
+        errorLine1="                setCacheDisabled(true)"
+        errorLine2="                ~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/spider/SpiderDen.kt"
+            line="136"
+            column="17"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `execute`"
+        errorLine1="            }.execute { info ->"
+        errorLine2="              ~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/spider/SpiderDen.kt"
+            line="137"
+            column="15"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `android.net.http.HeaderBlock#getAsMap`"
+        errorLine1="                val headers = info.headers.asMap"
+        errorLine2="                                           ~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/spider/SpiderDen.kt"
+            line="138"
+            column="44"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `android.net.http.UrlResponseInfo#getHeaders`"
+        errorLine1="                val headers = info.headers.asMap"
+        errorLine2="                                   ~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/spider/SpiderDen.kt"
+            line="138"
+            column="36"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `copyToChannel`"
+        errorLine1="                        copyToChannel(chan) {"
+        errorLine2="                        ~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/spider/SpiderDen.kt"
+            line="145"
+            column="25"/>
+    </issue>
+
+    <issue
+        id="NewApi"
+        message="Call requires version 7 of the S Extensions SDK (current min is 0): `android.net.http.UrlResponseInfo#getReceivedByteCount`"
+        errorLine1="                            notifyProgress(length, info.receivedByteCount, it)"
+        errorLine2="                                                        ~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/com/hippo/ehviewer/spider/SpiderDen.kt"
+            line="146"
+            column="57"/>
+    </issue>
+
+</issues>
diff --git a/app/src/main/res/xml/shortcuts.xml b/app/src/main/res/xml-v25/shortcuts.xml
similarity index 100%
rename from app/src/main/res/xml/shortcuts.xml
rename to app/src/main/res/xml-v25/shortcuts.xml