Convert EasyRecyclerView to kotlin

app/src/main/java/com/hippo/ehviewer/client/EhEngine.kt

@@ -449,8 +449,7 @@ object EhEngine {
         if (filter) list.removeAll { EhFilter.filterUploader(it) || EhFilter.filterTag(it) || EhFilter.filterTagNamespace(it) }
     }
 
-    suspend fun addFavoritesRange(gidArray: LongArray, tokenArray: Array<String?>, dstCat: Int) {
+    suspend fun addFavoritesRange(gidTokenArray: Array<Pair<Long, String>>, dstCat: Int) {
-        require(gidArray.size == tokenArray.size)
+        gidTokenArray.forEach { (gid, token) -> addFavorites(gid, token, dstCat, null) }
-        gidArray.forEachIndexed { index, gid -> addFavorites(gid, tokenArray[index], dstCat, null) }
     }
 }

app/src/main/java/com/hippo/ehviewer/ui/scene/DownloadsScene.kt

@@ -439,16 +439,12 @@ class DownloadsScene :
                 NewLabelDialogHelper(builder, dialog)
                 return@setOnMenuItemClickListener true
             } else if (id == R.id.action_default_download_label) {
-                val list = DownloadManager.labelList
+                val list = DownloadManager.labelList.mapNotNull { it.label }.toTypedArray()
-                val items = arrayOfNulls<String>(list.size + 2)
+                val items = arrayOf(
-                items[0] = getString(R.string.let_me_select)
+                    getString(R.string.let_me_select),
-                items[1] = getString(R.string.default_download_label_name)
+                    getString(R.string.default_download_label_name),
-                var i = 0
+                    *list
-                val n = list.size
+                )
-                while (i < n) {
-                    items[i + 2] = list[i].label
-                    i++
-                }
                 BaseDialogBuilder(requireContext())
                     .setTitle(R.string.default_download_label)
                     .setItems(items) { _: DialogInterface?, which: Int ->
@@ -539,7 +535,7 @@ class DownloadsScene :
             if (collectDownloadInfo) {
                 downloadInfoList = LinkedList()
             }
-            val stateArray = binding.recyclerView.checkedItemPositions
+            val stateArray = binding.recyclerView.checkedItemPositions!!
             for (i in 0 until stateArray.size()) {
                 if (stateArray.valueAt(i)) {
                     val info = list[stateArray.keyAt(i)]

app/src/main/java/com/hippo/ehviewer/ui/scene/FavoritesScene.kt

@@ -485,17 +485,14 @@ class FavoritesScene :
             return
         }
         mModifyGiList.clear()
-        val stateArray = binding.contentLayout.recyclerView.checkedItemPositions
+        val stateArray = binding.contentLayout.recyclerView.checkedItemPositions!!
-        var i = 0
+        for (i in 0 until stateArray.size()) {
-        val n = stateArray.size()
-        while (i < n) {
             if (stateArray.valueAt(i)) {
                 val gi = mHelper.getDataAtEx(stateArray.keyAt(i))
                 if (gi != null) {
                     mModifyGiList.add(gi)
                 }
             }
-            i++
         }
         when (position) {
             3 -> // Check all
@@ -696,13 +693,7 @@ class FavoritesScene :
             }
             binding.contentLayout.recyclerView.outOfCustomChoiceMode()
             if (mUrlBuilder!!.favCat == FavListUrlBuilder.FAV_CAT_LOCAL) { // Delete local fav
-                val gidArray = LongArray(mModifyGiList.size)
+                val gidArray = mModifyGiList.map { it.gid }.toLongArray()
-                var i = 0
-                val n = mModifyGiList.size
-                while (i < n) {
-                    gidArray[i] = mModifyGiList[i].gid
-                    i++
-                }
                 EhDB.removeLocalFavorites(gidArray)
                 mModifyGiList.clear()
                 mHelper.refresh()
@@ -737,13 +728,7 @@ class FavoritesScene :
             }
             binding.contentLayout.recyclerView.outOfCustomChoiceMode()
             if (srcCat == FavListUrlBuilder.FAV_CAT_LOCAL) { // Move from local to cloud
-                val gidArray = LongArray(mModifyGiList.size)
+                val gidArray = mModifyGiList.map { it.gid }.toLongArray()
-                var i = 0
-                val n = mModifyGiList.size
-                while (i < n) {
-                    gidArray[i] = mModifyGiList[i].gid
-                    i++
-                }
                 EhDB.removeLocalFavorites(gidArray)
                 mEnableModify = true
                 mModifyFavCat = dstCat
@@ -811,22 +796,13 @@ class FavoritesScene :
             if (mEnableModify) {
                 mEnableModify = false
                 val local = mUrlBuilder!!.favCat == FavListUrlBuilder.FAV_CAT_LOCAL
-                val gidArray = LongArray(mModifyGiList.size)
                 if (mModifyAdd) {
-                    val tokenArray = arrayOfNulls<String>(mModifyGiList.size)
+                    val gidTokenArray = mModifyGiList.map { Pair(it.gid, it.token!!) }.toTypedArray()
-                    var i = 0
-                    val n = mModifyGiList.size
-                    while (i < n) {
-                        val gi = mModifyGiList[i]
-                        gidArray[i] = gi.gid
-                        tokenArray[i] = gi.token
-                        i++
-                    }
                     val modifyGiListBackup: List<GalleryInfo> = ArrayList(mModifyGiList)
                     mModifyGiList.clear()
                     lifecycleScope.launchIO {
                         runSuspendCatching {
-                            EhEngine.addFavoritesRange(gidArray, tokenArray, mModifyFavCat)
+                            EhEngine.addFavoritesRange(gidTokenArray, mModifyFavCat)
                         }.onSuccess {
                             withUIContext {
                                 onGetFavoritesLocal(mUrlBuilder?.keyword, taskId)
@@ -841,12 +817,7 @@ class FavoritesScene :
                         }
                     }
                 } else {
-                    var i = 0
+                    val gidArray = mModifyGiList.map { it.gid }.toLongArray()
-                    val n = mModifyGiList.size
-                    while (i < n) {
-                        gidArray[i] = mModifyGiList[i].gid
-                        i++
-                    }
                     mModifyGiList.clear()
                     val url: String = if (local) {
                         // Local fav is shown now, but operation need be done for cloud fav