From 1a38433dee9440db5dc0ebe1ac487dc91fa4eeb6 Mon Sep 17 00:00:00 2001 From: Kunall Banerjee Date: Mon, 13 Jul 2026 12:38:11 -0400 Subject: [PATCH] settings_ui: Open ACP docs from Settings UI correctly (#60881) ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes #60822. --- Release Notes: - Fixed broken handler for opening ACP documentation from the Settings UI --- crates/settings_ui/src/pages/external_agents_page.rs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/crates/settings_ui/src/pages/external_agents_page.rs b/crates/settings_ui/src/pages/external_agents_page.rs index b4b4350619..786e3063e4 100644 --- a/crates/settings_ui/src/pages/external_agents_page.rs +++ b/crates/settings_ui/src/pages/external_agents_page.rs @@ -18,7 +18,6 @@ use ui::{ }; use util::ResultExt as _; use workspace::{MultiWorkspace, Workspace, create_and_open_local_file}; -use zed_actions::OpenBrowser; use crate::SettingsWindow; @@ -310,14 +309,7 @@ pub(crate) fn render_add_agent_popover( .icon(IconName::ArrowUpRight) .icon_color(Color::Muted) .icon_position(IconPosition::End) - .handler(move |window, cx| { - window.dispatch_action( - Box::new(OpenBrowser { - url: "https://agentclientprotocol.com/".into(), - }), - cx, - ); - }), + .handler(|_window, cx| cx.open_url("https://agentclientprotocol.com/")), ) })) });