From 1be046a007649761cdc20bf032191df8a87fddbd Mon Sep 17 00:00:00 2001 From: Kunall Banerjee Date: Wed, 29 Jul 2026 16:58:08 -0400 Subject: [PATCH] collab_ui: Open contact finder with empty query (#61363) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I ran into this while conducting some tests. If you search for a channel name in the Collab Panel and then try to “Add a Contact,” it seeds the query with your search term from the current contents of that channel search editor. Opted to just drop that method altogether as it’s not being used anywhere else. ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable --- Release Notes: - Fixed the contact finder inheriting the channel search query in the Collab Panel --- crates/collab_ui/src/collab_panel.rs | 4 +--- crates/collab_ui/src/collab_panel/contact_finder.rs | 6 ------ 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/crates/collab_ui/src/collab_panel.rs b/crates/collab_ui/src/collab_panel.rs index 3e3201f810..d96db6d533 100644 --- a/crates/collab_ui/src/collab_panel.rs +++ b/crates/collab_ui/src/collab_panel.rs @@ -2132,9 +2132,7 @@ impl CollabPanel { if let Some(workspace) = self.workspace.upgrade() { workspace.update(cx, |workspace, cx| { workspace.toggle_modal(window, cx, |window, cx| { - let mut finder = ContactFinder::new(self.user_store.clone(), window, cx); - finder.set_query(self.filter_editor.read(cx).text(cx), window, cx); - finder + ContactFinder::new(self.user_store.clone(), window, cx) }); }); } diff --git a/crates/collab_ui/src/collab_panel/contact_finder.rs b/crates/collab_ui/src/collab_panel/contact_finder.rs index 22c09b285b..5349a79cd6 100644 --- a/crates/collab_ui/src/collab_panel/contact_finder.rs +++ b/crates/collab_ui/src/collab_panel/contact_finder.rs @@ -25,12 +25,6 @@ impl ContactFinder { Self { picker } } - - pub fn set_query(&mut self, query: String, window: &mut Window, cx: &mut Context) { - self.picker.update(cx, |picker, cx| { - picker.set_query(&query, window, cx); - }); - } } impl Render for ContactFinder {