languages: Improve semantic token highlighting for parameters and Python (#52130)
## Context Zed's semantic token highlighting does not cover all token types returned by language servers, so the highlighting looks fairly primitive compared with tree-sitter highlighting, especially for Python language servers. This PR adds some global and Python-specific rules for better highlighting. I need to admit that the built-in Python language servers currently have weak semantic highlighting implementations. Pylance, the closed-source Python language server from Microsoft, provides the best highlighting for now, but I think ty will do better, even though it still has a long way to go. ## How to Review Basically, this is a rule-adding change. Some rules are made global, and some are made Python-specific. ## Self-Review Checklist <!-- Check before requesting review: --> - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Improved semantic token highlighting for parameters and Python
This commit is contained in:
1 parent
2938ab95db
commit
23e1bcf59d
4 files changed
+41
-2
No files matched your search
@@ -0,0 +1,15 @@
|
||||
[
|
||||
{
|
||||
"token_type": "selfParameter",
|
||||
"style": ["variable.special"]
|
||||
},
|
||||
{
|
||||
"token_type": "clsParameter",
|
||||
"style": ["variable.special"]
|
||||
},
|
||||
// ty specific
|
||||
{
|
||||
"token_type": "builtinConstant",
|
||||
"style": ["constant.builtin"]
|
||||
}
|
||||
]
|
||||
Reference in new issue
Block a user