From 35ab3ef108a32c6e11ebe1d8de0f4eabbd45e01f Mon Sep 17 00:00:00 2001 From: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Date: Tue, 24 Mar 2026 09:16:13 -0300 Subject: [PATCH] ui: Clean up unused icons (#52282) This PR removes a bunch of unused icons in the codebase. Just cleaning it up! Release Notes: - N/A --- assets/icons/ai.svg | 27 ------------------- assets/icons/cog.svg | 1 - assets/icons/ellipsis_vertical.svg | 5 ---- assets/icons/menu_alt.svg | 3 --- assets/icons/shield_check.svg | 4 --- assets/icons/swatch_book.svg | 1 - assets/icons/terminal_ghost.svg | 4 --- assets/icons/threads_sidebar_right_closed.svg | 5 ---- assets/icons/threads_sidebar_right_open.svg | 5 ---- assets/icons/tool_read.svg | 7 ----- assets/icons/tool_regex.svg | 4 --- .../manage_profiles_modal.rs | 4 +-- crates/agent_ui/src/conversation_view.rs | 2 +- .../agent_ui/src/language_model_selector.rs | 2 +- crates/agent_ui/src/test_support.rs | 2 +- crates/agent_ui/src/text_thread_editor.rs | 4 +-- .../src/assistant_text_thread_tests.rs | 4 +-- crates/icons/src/icons.rs | 12 --------- 18 files changed, 9 insertions(+), 87 deletions(-) delete mode 100644 assets/icons/ai.svg delete mode 100644 assets/icons/cog.svg delete mode 100644 assets/icons/ellipsis_vertical.svg delete mode 100644 assets/icons/menu_alt.svg delete mode 100644 assets/icons/shield_check.svg delete mode 100644 assets/icons/swatch_book.svg delete mode 100644 assets/icons/terminal_ghost.svg delete mode 100644 assets/icons/threads_sidebar_right_closed.svg delete mode 100644 assets/icons/threads_sidebar_right_open.svg delete mode 100644 assets/icons/tool_read.svg delete mode 100644 assets/icons/tool_regex.svg diff --git a/assets/icons/ai.svg b/assets/icons/ai.svg deleted file mode 100644 index 4236d50337..0000000000 --- a/assets/icons/ai.svg +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/assets/icons/cog.svg b/assets/icons/cog.svg deleted file mode 100644 index 7dd3a8beff..0000000000 --- a/assets/icons/cog.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/assets/icons/ellipsis_vertical.svg b/assets/icons/ellipsis_vertical.svg deleted file mode 100644 index c38437667e..0000000000 --- a/assets/icons/ellipsis_vertical.svg +++ /dev/null @@ -1,5 +0,0 @@ - - - - - diff --git a/assets/icons/menu_alt.svg b/assets/icons/menu_alt.svg deleted file mode 100644 index b9cc19e22f..0000000000 --- a/assets/icons/menu_alt.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/assets/icons/shield_check.svg b/assets/icons/shield_check.svg deleted file mode 100644 index 43b52f43a8..0000000000 --- a/assets/icons/shield_check.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/assets/icons/swatch_book.svg b/assets/icons/swatch_book.svg deleted file mode 100644 index b37d5df8c1..0000000000 --- a/assets/icons/swatch_book.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/assets/icons/terminal_ghost.svg b/assets/icons/terminal_ghost.svg deleted file mode 100644 index 7d0d0e068e..0000000000 --- a/assets/icons/terminal_ghost.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/assets/icons/threads_sidebar_right_closed.svg b/assets/icons/threads_sidebar_right_closed.svg deleted file mode 100644 index 10fa4b792f..0000000000 --- a/assets/icons/threads_sidebar_right_closed.svg +++ /dev/null @@ -1,5 +0,0 @@ - - - - - diff --git a/assets/icons/threads_sidebar_right_open.svg b/assets/icons/threads_sidebar_right_open.svg deleted file mode 100644 index 23a01eb3f8..0000000000 --- a/assets/icons/threads_sidebar_right_open.svg +++ /dev/null @@ -1,5 +0,0 @@ - - - - - diff --git a/assets/icons/tool_read.svg b/assets/icons/tool_read.svg deleted file mode 100644 index d22e9d8c7d..0000000000 --- a/assets/icons/tool_read.svg +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - diff --git a/assets/icons/tool_regex.svg b/assets/icons/tool_regex.svg deleted file mode 100644 index 818c2ba360..0000000000 --- a/assets/icons/tool_regex.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/crates/agent_ui/src/agent_configuration/manage_profiles_modal.rs b/crates/agent_ui/src/agent_configuration/manage_profiles_modal.rs index 744c92a7f7..9a8b56f43f 100644 --- a/crates/agent_ui/src/agent_configuration/manage_profiles_modal.rs +++ b/crates/agent_ui/src/agent_configuration/manage_profiles_modal.rs @@ -991,7 +991,7 @@ impl Render for ManageProfilesModal { .pb_1() .child(ProfileModalHeader::new( format!("{profile_name} — Configure Built-in Tools"), - Some(IconName::Cog), + Some(IconName::Settings), )) .child(ListSeparator) .child(tool_picker.clone()) @@ -1014,7 +1014,7 @@ impl Render for ManageProfilesModal { .pb_1() .child(ProfileModalHeader::new( format!("{profile_name} — Configure Default Model"), - Some(IconName::Ai), + Some(IconName::ZedAgent), )) .child(ListSeparator) .child(v_flex().w(rems(34.)).child(model_picker.clone())) diff --git a/crates/agent_ui/src/conversation_view.rs b/crates/agent_ui/src/conversation_view.rs index 0f47776291..1f218c6ccc 100644 --- a/crates/agent_ui/src/conversation_view.rs +++ b/crates/agent_ui/src/conversation_view.rs @@ -3627,7 +3627,7 @@ pub(crate) mod tests { C: 'static + AgentConnection + Send + Clone, { fn logo(&self) -> ui::IconName { - ui::IconName::Ai + ui::IconName::ZedAgent } fn agent_id(&self) -> AgentId { diff --git a/crates/agent_ui/src/language_model_selector.rs b/crates/agent_ui/src/language_model_selector.rs index e6e72b3197..899542245a 100644 --- a/crates/agent_ui/src/language_model_selector.rs +++ b/crates/agent_ui/src/language_model_selector.rs @@ -724,7 +724,7 @@ mod tests { .any(|(fav_provider, fav_name)| *fav_provider == provider && *fav_name == name); ModelInfo { model: Arc::new(TestLanguageModel::new(name, provider)), - icon: IconOrSvg::Icon(IconName::Ai), + icon: IconOrSvg::Icon(IconName::ZedAgent), is_favorite, } }) diff --git a/crates/agent_ui/src/test_support.rs b/crates/agent_ui/src/test_support.rs index 43efc85f02..375d542637 100644 --- a/crates/agent_ui/src/test_support.rs +++ b/crates/agent_ui/src/test_support.rs @@ -48,7 +48,7 @@ where C: 'static + AgentConnection + Send + Clone, { fn logo(&self) -> ui::IconName { - ui::IconName::Ai + ui::IconName::ZedAgent } fn agent_id(&self) -> AgentId { diff --git a/crates/agent_ui/src/text_thread_editor.rs b/crates/agent_ui/src/text_thread_editor.rs index 5cac22e0a0..ce1a7300c9 100644 --- a/crates/agent_ui/src/text_thread_editor.rs +++ b/crates/agent_ui/src/text_thread_editor.rs @@ -894,7 +894,7 @@ impl TextThreadEditor { |_, _, _, _| Empty.into_any_element(), ) .with_metadata(CreaseMetadata { - icon_path: SharedString::from(IconName::Ai.path()), + icon_path: SharedString::from(IconName::ZedAgent.path()), label: "Thinking Process".into(), }), ); @@ -2256,7 +2256,7 @@ impl TextThreadEditor { let provider_icon = active_provider .as_ref() .map(|p| p.icon()) - .unwrap_or(IconOrSvg::Icon(IconName::Ai)); + .unwrap_or(IconOrSvg::Icon(IconName::ZedAgent)); let (color, icon) = if self.language_model_selector_menu_handle.is_deployed() { (Color::Accent, IconName::ChevronUp) diff --git a/crates/assistant_text_thread/src/assistant_text_thread_tests.rs b/crates/assistant_text_thread/src/assistant_text_thread_tests.rs index 9829e8993c..c4f1688dd0 100644 --- a/crates/assistant_text_thread/src/assistant_text_thread_tests.rs +++ b/crates/assistant_text_thread/src/assistant_text_thread_tests.rs @@ -526,7 +526,7 @@ async fn test_slash_commands(cx: &mut TestAppContext) { command_output_tx .unbounded_send(Ok(SlashCommandEvent::StartSection { - icon: IconName::Ai, + icon: IconName::ZedAgent, label: "src/main.rs".into(), metadata: None, })) @@ -870,7 +870,7 @@ async fn test_random_context_collaboration(cx: &mut TestAppContext, mut rng: Std rng.random_range(section_start..=output_text.len()), ); events.push(Ok(SlashCommandEvent::StartSection { - icon: IconName::Ai, + icon: IconName::ZedAgent, label: "section".into(), metadata: None, })); diff --git a/crates/icons/src/icons.rs b/crates/icons/src/icons.rs index 321c7fcc6f..bcdd156e6e 100644 --- a/crates/icons/src/icons.rs +++ b/crates/icons/src/icons.rs @@ -9,7 +9,6 @@ use strum::{EnumIter, EnumString, IntoStaticStr}; #[strum(serialize_all = "snake_case")] pub enum IconName { AcpRegistry, - Ai, AiAnthropic, AiBedrock, AiClaude, @@ -69,7 +68,6 @@ pub enum IconName { Close, CloudDownload, Code, - Cog, Command, Control, Copilot, @@ -106,7 +104,6 @@ pub enum IconName { EditorSublime, EditorVsCode, Ellipsis, - EllipsisVertical, Envelope, Eraser, Escape, @@ -178,7 +175,6 @@ pub enum IconName { MagnifyingGlass, Maximize, Menu, - MenuAlt, MenuAltTemp, Mic, MicMute, @@ -220,7 +216,6 @@ pub enum IconName { Send, Server, Settings, - ShieldCheck, Shift, SignalHigh, SignalLow, @@ -237,7 +232,6 @@ pub enum IconName { Star, StarFilled, Stop, - SwatchBook, SweepAi, SweepAiDisabled, SweepAiDown, @@ -246,7 +240,6 @@ pub enum IconName { Tab, Terminal, TerminalAlt, - TerminalGhost, TextSnippet, TextThread, ThinkingMode, @@ -255,8 +248,6 @@ pub enum IconName { ThreadFromSummary, ThreadsSidebarLeftClosed, ThreadsSidebarLeftOpen, - ThreadsSidebarRightClosed, - ThreadsSidebarRightOpen, ThumbsDown, ThumbsUp, TodoComplete, @@ -269,8 +260,6 @@ pub enum IconName { ToolHammer, ToolNotification, ToolPencil, - ToolRead, - ToolRegex, ToolSearch, ToolTerminal, ToolThink, @@ -297,7 +286,6 @@ pub enum IconName { ZedPredictUp, ZedSrcCustom, ZedSrcExtension, - ZedXCopilot, } impl IconName {