ci: Improve messaging around compliance failures (#54636)

Release Notes:

- N/A

.github/workflows/release.yml

@@ -643,7 +643,6 @@ jobs:
   validate_release_assets:
     needs:
     - upload_release_assets
-    - compliance_check
     runs-on: namespace-profile-2x4-ubuntu-2404
     steps:
     - name: release::validate_release_assets
@@ -664,6 +663,12 @@ jobs:
         echo "All expected assets are present in the release."
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  release_compliance_check:
+    needs:
+    - upload_release_assets
+    - compliance_check
+    runs-on: namespace-profile-8x16-ubuntu-2204
+    steps:
     - name: steps::checkout_repo
       uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd
       with:
@@ -712,6 +717,7 @@ jobs:
   auto_release_preview:
     needs:
     - validate_release_assets
+    - release_compliance_check
     if: startsWith(github.ref, 'refs/tags/v') && endsWith(github.ref, '-pre') && !endsWith(github.ref, '.0-pre')
     runs-on: namespace-profile-2x4-ubuntu-2404
     steps:
@@ -730,6 +736,7 @@ jobs:
     - create_draft_release
     - upload_release_assets
     - validate_release_assets
+    - release_compliance_check
     - auto_release_preview
     - run_tests_mac
     - run_tests_linux
@@ -750,9 +757,7 @@ jobs:
     - id: generate-webhook-message
       name: release::generate_slack_message
       run: |
-        MESSAGE=$(TAG="$GITHUB_REF_NAME"
-
-        if [ "$DRAFT_RESULT" == "failure" ]; then
+        MESSAGE=$(if [ "$DRAFT_RESULT" == "failure" ]; then
             echo "❌ Draft release creation failed for $TAG: $RUN_URL"
         else
             RELEASE_URL=$(gh release view "$TAG" --repo=zed-industries/zed --json url -q '.url')
@@ -787,8 +792,11 @@ jobs:
                         echo "❌ Tests for $TAG failed: $RUN_URL"
                     fi
                 fi
+            elif [ "$COMPLIANCE_RESULT" == "failure" ]; then
+                # We already notify within that job
+                echo ""
             elif [ "$VALIDATE_RESULT" == "failure" ]; then
-                echo "❌ Release asset validation failed for $TAG (missing assets): $RUN_URL"
+                echo "❌ Release validation failed for $TAG: missing assets: $RUN_URL"
             elif [ "$AUTO_RELEASE_RESULT" == "success" ]; then
                 echo "✅ Release $TAG was auto-released successfully: $RELEASE_URL"
             elif [ "$AUTO_RELEASE_RESULT" == "failure" ]; then
@@ -804,8 +812,10 @@ jobs:
         DRAFT_RESULT: ${{ needs.create_draft_release.result }}
         UPLOAD_RESULT: ${{ needs.upload_release_assets.result }}
         VALIDATE_RESULT: ${{ needs.validate_release_assets.result }}
+        COMPLIANCE_RESULT: ${{ needs.release_compliance_check.result }}
         AUTO_RELEASE_RESULT: ${{ needs.auto_release_preview.result }}
         RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+        TAG: ${{ github.ref_name }}
         RESULT_RUN_TESTS_MAC: ${{ needs.run_tests_mac.result }}
         RESULT_RUN_TESTS_LINUX: ${{ needs.run_tests_linux.result }}
         RESULT_RUN_TESTS_WINDOWS: ${{ needs.run_tests_windows.result }}
@@ -820,6 +830,7 @@ jobs:
         RESULT_BUNDLE_WINDOWS_AARCH64: ${{ needs.bundle_windows_aarch64.result }}
         RESULT_BUNDLE_WINDOWS_X86_64: ${{ needs.bundle_windows_x86_64.result }}
     - name: release::send_slack_message
+      if: steps.generate-webhook-message.outputs.message != ''
       run: 'curl -X POST -H ''Content-type: application/json'' --data "$(jq -n --arg text "$SLACK_MESSAGE" ''{"text": $text}'')" "$SLACK_WEBHOOK"'
       env:
         SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_WORKFLOW_FAILURES }}