From 47dd63518ce8270cde3f0e98c54409dd8212bcdb Mon Sep 17 00:00:00 2001 From: Ben Kunkle Date: Tue, 16 Jun 2026 12:29:10 -0500 Subject: [PATCH] ep: Store rejected patch as prediction (#59440) # Objective - Describe the objective or issue this PR addresses. - If you're fixing a specific issue, use "Fixes #X" for each issue as [described in the GitHub docs](https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword). ## Solution - Describe the solution used to achieve the objective above. ## Testing - Did you test these changes? If so, how? - Are there any parts that need more testing? - How can other people (reviewers) test your changes? Is there anything specific they need to know? - If relevant, what platforms did you test these changes on, and are there any important ones you can't test? ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Showcase > This section is optional. If this PR does not include a visual change or does not add a new user-facing feature, you can delete this section. - Help others understand the result of this PR by showcasing your awesome work! - If this PR includes a visual change, consider adding a screenshot, GIF, or video - A before/after comparison is very useful for changes to existing features! While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases:
Click to view showcase My super cool demos here
--- Release Notes: - N/A or Added/Fixed/Improved ... --- crates/edit_prediction_cli/src/pull_examples.rs | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/crates/edit_prediction_cli/src/pull_examples.rs b/crates/edit_prediction_cli/src/pull_examples.rs index 73778ef548..15171c6feb 100644 --- a/crates/edit_prediction_cli/src/pull_examples.rs +++ b/crates/edit_prediction_cli/src/pull_examples.rs @@ -1801,10 +1801,19 @@ fn build_rejected_example( Some(RejectionInfo { reason, was_shown }), zed_version, ); - example.spec.rejected_patch = Some(rejected_patch); + example.spec.rejected_patch = Some(rejected_patch.clone()); if let Some(expected_patch) = expected_patch { example.spec.expected_patches = vec![expected_patch]; } + example.predictions.push(ExamplePrediction { + provider: PredictionProvider::default(), + actual_output: output.clone(), + actual_patch: Some(rejected_patch), + actual_cursor: None, + error: None, + cumulative_logprob: None, + avg_logprob: None, + }); example.prompt = prompt.map(|prompt| ExamplePrompt { input: prompt, expected_output: None,