From 4e8057d74db3570b3bd419ff296eb84c35b3a5a3 Mon Sep 17 00:00:00 2001 From: Finn Evers Date: Mon, 10 Aug 2026 11:20:15 +0200 Subject: [PATCH] ci: Ensure assignees can be set for generated PRs (#62418) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Now, this is one of these beautiful cases where GitHubs API ist just so pleasant to work with: Because PRs are treated as issues, assigning an assignee to a PR suddenly requires issue write permissions, despite the issue in question being a PR. Not having that permission resulted in some missing assignees on zed zippy bumps and failures of the workflows as seen in https://github.com/zed-industries/zed/actions/runs/31339736929/job/93311493258. In comparison, labelling PRs requires PR write permissions as seen in https://github.com/zed-industries/zed/pull/61525 🤡 Beautiful API and a pleasure to work with, 10/10 would recommend. Release Notes: - N/A --- .github/workflows/bump_zed_version.yml | 1 + .github/workflows/extension_bump.yml | 1 + .github/workflows/extension_workflow_rollout.yml | 3 ++- .github/workflows/publish_extension_cli.yml | 2 ++ tooling/xtask/src/tasks/workflows/bump_zed_version.rs | 1 + tooling/xtask/src/tasks/workflows/extension_bump.rs | 1 + .../xtask/src/tasks/workflows/extension_workflow_rollout.rs | 3 ++- tooling/xtask/src/tasks/workflows/publish_extension_cli.rs | 2 ++ 8 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bump_zed_version.yml b/.github/workflows/bump_zed_version.yml index f5b72cccf1..9ff390ac5d 100644 --- a/.github/workflows/bump_zed_version.yml +++ b/.github/workflows/bump_zed_version.yml @@ -104,6 +104,7 @@ jobs: owner: ${{ github.repository_owner }} repositories: ${{ github.event.repository.name }} permission-contents: write + permission-issues: write permission-pull-requests: write - name: steps::checkout_repo uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd diff --git a/.github/workflows/extension_bump.yml b/.github/workflows/extension_bump.yml index 0b611bfdaf..40f8387e59 100644 --- a/.github/workflows/extension_bump.yml +++ b/.github/workflows/extension_bump.yml @@ -84,6 +84,7 @@ jobs: owner: ${{ github.repository_owner }} repositories: ${{ github.event.repository.name }} permission-contents: write + permission-issues: write permission-pull-requests: write - name: steps::checkout_repo uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd diff --git a/.github/workflows/extension_workflow_rollout.yml b/.github/workflows/extension_workflow_rollout.yml index a295c20ddb..d4cba07bf2 100644 --- a/.github/workflows/extension_workflow_rollout.yml +++ b/.github/workflows/extension_workflow_rollout.yml @@ -125,8 +125,9 @@ jobs: private-key: ${{ secrets.ZED_ZIPPY_APP_PRIVATE_KEY }} owner: zed-extensions repositories: ${{ matrix.repo }} - permission-pull-requests: write permission-contents: write + permission-issues: write + permission-pull-requests: write permission-workflows: write - name: checkout_extension_repo uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd diff --git a/.github/workflows/publish_extension_cli.yml b/.github/workflows/publish_extension_cli.yml index 6f14092a66..6c1c295e28 100644 --- a/.github/workflows/publish_extension_cli.yml +++ b/.github/workflows/publish_extension_cli.yml @@ -72,6 +72,7 @@ jobs: owner: ${{ github.repository_owner }} repositories: ${{ github.event.repository.name }} permission-contents: write + permission-issues: write permission-pull-requests: write permission-workflows: write - name: steps::checkout_repo @@ -129,6 +130,7 @@ jobs: owner: zed-industries repositories: extensions permission-contents: write + permission-issues: write permission-pull-requests: write permission-workflows: write - id: short-sha diff --git a/tooling/xtask/src/tasks/workflows/bump_zed_version.rs b/tooling/xtask/src/tasks/workflows/bump_zed_version.rs index 47a98d8fca..45cd20a3e4 100644 --- a/tooling/xtask/src/tasks/workflows/bump_zed_version.rs +++ b/tooling/xtask/src/tasks/workflows/bump_zed_version.rs @@ -141,6 +141,7 @@ fn bump_main( .for_repository(steps::RepositoryTarget::current()) .with_permissions([ (steps::TokenPermissions::Contents, Level::Write), + (steps::TokenPermissions::Issues, Level::Write), (steps::TokenPermissions::PullRequests, Level::Write), ]) .into(); diff --git a/tooling/xtask/src/tasks/workflows/extension_bump.rs b/tooling/xtask/src/tasks/workflows/extension_bump.rs index 7ec0245b1f..71225fc941 100644 --- a/tooling/xtask/src/tasks/workflows/extension_bump.rs +++ b/tooling/xtask/src/tasks/workflows/extension_bump.rs @@ -222,6 +222,7 @@ fn bump_extension_version( .for_repository(RepositoryTarget::current()) .with_permissions([ (TokenPermissions::Contents, Level::Write), + (TokenPermissions::Issues, Level::Write), (TokenPermissions::PullRequests, Level::Write), ]) .into(); diff --git a/tooling/xtask/src/tasks/workflows/extension_workflow_rollout.rs b/tooling/xtask/src/tasks/workflows/extension_workflow_rollout.rs index ae3465af48..de7b681f3b 100644 --- a/tooling/xtask/src/tasks/workflows/extension_workflow_rollout.rs +++ b/tooling/xtask/src/tasks/workflows/extension_workflow_rollout.rs @@ -298,8 +298,9 @@ fn rollout_workflows_to_extension( &["${{ matrix.repo }}"], )) .with_permissions([ - (TokenPermissions::PullRequests, Level::Write), (TokenPermissions::Contents, Level::Write), + (TokenPermissions::Issues, Level::Write), + (TokenPermissions::PullRequests, Level::Write), (TokenPermissions::Workflows, Level::Write), ]) .into(); diff --git a/tooling/xtask/src/tasks/workflows/publish_extension_cli.rs b/tooling/xtask/src/tasks/workflows/publish_extension_cli.rs index 567e235dfe..450b70b7f6 100644 --- a/tooling/xtask/src/tasks/workflows/publish_extension_cli.rs +++ b/tooling/xtask/src/tasks/workflows/publish_extension_cli.rs @@ -90,6 +90,7 @@ fn update_sha_in_zed(publish_job: &NamedJob, message: &WorkflowInput) -> NamedJo .for_repository(RepositoryTarget::current()) .with_permissions([ (TokenPermissions::Contents, Level::Write), + (TokenPermissions::Issues, Level::Write), (TokenPermissions::PullRequests, Level::Write), (TokenPermissions::Workflows, Level::Write), ]) @@ -159,6 +160,7 @@ fn update_sha_in_extensions(publish_job: &NamedJob, message: &WorkflowInput) -> .for_repository(extensions_repo) .with_permissions([ (TokenPermissions::Contents, Level::Write), + (TokenPermissions::Issues, Level::Write), (TokenPermissions::PullRequests, Level::Write), (TokenPermissions::Workflows, Level::Write), ])