From 5f9f1cc56163b2a378d160c06e344385f0d7b408 Mon Sep 17 00:00:00 2001
From: Tiou Lims <dourokinga@gmail.com>
Date: Fri, 5 Jun 2026 23:21:46 +0800
Subject: [PATCH] Fix macOS system font fallback cascade append (#58020)

Fixes #57916.

`append_system_fallbacks` used `.map(...)` for the `CFArrayAppendValue`
side effect, but the iterator was never consumed.

This changes it to a `for` loop so the fallback descriptors are actually
appended.
---
 crates/gpui_macos/src/open_type.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/crates/gpui_macos/src/open_type.rs b/crates/gpui_macos/src/open_type.rs
index 048ba13dd1..8a30508de2 100644
--- a/crates/gpui_macos/src/open_type.rs
+++ b/crates/gpui_macos/src/open_type.rs
@@ -125,12 +125,12 @@ fn append_system_fallbacks(fallback_array: CFMutableArrayRef, font_ref: CTFontRe
         let default_fallbacks: CFArray<CTFontDescriptor> =
             CFArray::wrap_under_create_rule(default_fallbacks);
 
-        default_fallbacks
+        for desc in default_fallbacks
             .iter()
             .filter(|desc| desc.font_path().is_some())
-            .map(|desc| {
-                CFArrayAppendValue(fallback_array, desc.as_concrete_TypeRef() as _);
-            });
+        {
+            CFArrayAppendValue(fallback_array, desc.as_concrete_TypeRef() as _);
+        }
     }
 }