From 63fc2ea50101aead6bd77e0215a88bbd2bb48375 Mon Sep 17 00:00:00 2001 From: Nicolas Le Cam Date: Tue, 8 Sep 2026 21:44:06 +0000 Subject: [PATCH] node_runtime: Ignore package-lock.json files when installing internal tools (#52451) ## Context This prevents tools with native bindings to fail installation, see: - https://github.com/oxc-project/oxc-zed/issues/145 - https://github.com/napi-rs/napi-rs/pull/2707 - https://github.com/npm/cli/issues/4828 ## How to Review Fixes for https://github.com/oxc-project/oxc-zed/issues/145 ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed potential node tools failed/incomplete installation when having native bindings as optional dependencies Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> --- crates/node_runtime/src/node_runtime.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/node_runtime/src/node_runtime.rs b/crates/node_runtime/src/node_runtime.rs index dabf153859..7579789d7b 100644 --- a/crates/node_runtime/src/node_runtime.rs +++ b/crates/node_runtime/src/node_runtime.rs @@ -325,6 +325,7 @@ impl NodeRuntime { .iter() .map(|p| p.as_str()) .chain([ + "--no-package-lock", "--save-exact", "--fetch-retry-mintimeout", "2000",