From 6f42904133bd2bbd517e02041d79e04ea446c1bf Mon Sep 17 00:00:00 2001
From: Nadir <67718820+raideno@users.noreply.github.com>
Date: Thu, 11 Jun 2026 19:10:13 +0200
Subject: [PATCH] repl: Add notebook cell stop button (#57093)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes #57092

Before:

<img width="3400" height="2210" alt="image"
src="https://github.com/user-attachments/assets/0056817e-4826-46c1-85d4-e84c9c8d80f1"
/>

After:

<img width="1700" height="1105" alt="image"
src="https://github.com/user-attachments/assets/0ed86e42-20d7-41a0-90b6-102dfb57cc33"
/>

Release Notes:

- Add notebook cell stop button.

---------

Co-authored-by: Martin Ye <martin@zed.dev>
Co-authored-by: Yara <git@yara.blue>
---
 crates/repl/src/notebook/cell.rs | 38 +++++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 11 deletions(-)

diff --git a/crates/repl/src/notebook/cell.rs b/crates/repl/src/notebook/cell.rs
index 2267c135c1..2baf05a2d5 100644
--- a/crates/repl/src/notebook/cell.rs
+++ b/crates/repl/src/notebook/cell.rs
@@ -14,6 +14,7 @@ use runtimelib::{JupyterMessage, JupyterMessageContent};
 use settings::Settings as _;
 use ui::{CommonAnimationExt, IconButtonShape, prelude::*};
 use util::ResultExt;
+use zed_actions::notebook::InterruptKernel;
 
 use crate::{
     notebook::{CODE_BLOCK_INSET, GUTTER_WIDTH},
@@ -31,6 +32,7 @@ pub enum CellPosition {
 pub enum CellControlType {
     RunCell,
     RerunCell,
+    StopCell,
     ClearCell,
     CellOptions,
     CollapseCell,
@@ -52,12 +54,24 @@ impl CellControlType {
         match self {
             CellControlType::RunCell => IconName::PlayFilled,
             CellControlType::RerunCell => IconName::ArrowCircle,
+            CellControlType::StopCell => IconName::Stop,
             CellControlType::ClearCell => IconName::ListX,
             CellControlType::CellOptions => IconName::Ellipsis,
             CellControlType::CollapseCell => IconName::ChevronDown,
             CellControlType::ExpandCell => IconName::ChevronRight,
         }
     }
+    fn id(&self) -> &'static str {
+        match self {
+            CellControlType::RunCell => "CellControlType::RunCell",
+            CellControlType::RerunCell => "CellControlType::RerunCell",
+            CellControlType::StopCell => "CellControlType::StopCell",
+            CellControlType::ClearCell => "CellControlType::ClearCell",
+            CellControlType::CellOptions => "CellControlType::CellOptions",
+            CellControlType::CollapseCell => "CellControlType::CollapseCelln",
+            CellControlType::ExpandCell => "CellControlType::ExpandCell",
+        }
+    }
 }
 
 pub struct CellControl {
@@ -927,23 +941,25 @@ impl RenderableCell for CodeCell {
     }
 
     fn control(&self, _window: &mut Window, cx: &mut Context<Self>) -> Option<CellControl> {
-        let control_type = if self.has_outputs() {
+        let control_type = if self.is_executing {
+            CellControlType::StopCell
+        } else if self.has_outputs() {
             CellControlType::RerunCell
         } else {
             CellControlType::RunCell
         };
 
-        let cell_control = CellControl::new(
-            if self.has_outputs() {
-                "rerun-cell"
-            } else {
-                "run-cell"
-            },
-            control_type,
+        Some(
+            CellControl::new(control_type.id(), control_type).on_click(cx.listener(
+                move |this, _, window, cx| {
+                    if this.is_executing {
+                        window.dispatch_action(Box::new(InterruptKernel), cx);
+                    } else {
+                        this.run(window, cx);
+                    }
+                },
+            )),
         )
-        .on_click(cx.listener(move |this, _, window, cx| this.run(window, cx)));
-
-        Some(cell_control)
     }
 
     fn selected(&self) -> bool {