From a39a18de33c8d80fbc285a009bfc9805e76e359f Mon Sep 17 00:00:00 2001 From: Kunall Banerjee Date: Wed, 24 Jun 2026 01:43:59 -0400 Subject: [PATCH] settings_ui: Route Skill tool permissions to its own config page (#59728) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Skill page now renders the correct “Skill Tool” title, the skill-specific explanation, and reads/writes the `skill` tool’s own rules. ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable ## Showcase | Before | After | |--------|--------| | image | image | Closes #59720. --- Release Notes: - Fixed the Skill tool’s “Configure” button in the Agent’s Tool Permissions settings opening the Terminal tool’s configuration instead of the Skill tool’s own permission rules --- crates/settings_ui/src/pages.rs | 4 ++-- crates/settings_ui/src/pages/tool_permissions_setup.rs | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/settings_ui/src/pages.rs b/crates/settings_ui/src/pages.rs index ecb3eda800..1287f36f06 100644 --- a/crates/settings_ui/src/pages.rs +++ b/crates/settings_ui/src/pages.rs @@ -32,6 +32,6 @@ pub(crate) use tool_permissions_setup::render_tool_permissions_setup_page; pub use tool_permissions_setup::{ render_copy_path_tool_config, render_create_directory_tool_config, render_delete_path_tool_config, render_edit_file_tool_config, render_fetch_tool_config, - render_move_path_tool_config, render_terminal_tool_config, render_web_search_tool_config, - render_write_file_tool_config, + render_move_path_tool_config, render_skill_tool_config, render_terminal_tool_config, + render_web_search_tool_config, render_write_file_tool_config, }; diff --git a/crates/settings_ui/src/pages/tool_permissions_setup.rs b/crates/settings_ui/src/pages/tool_permissions_setup.rs index 25e8d1254c..d76f83cd9e 100644 --- a/crates/settings_ui/src/pages/tool_permissions_setup.rs +++ b/crates/settings_ui/src/pages/tool_permissions_setup.rs @@ -311,6 +311,7 @@ fn get_tool_render_fn( "create_directory" => render_create_directory_tool_config, "fetch" => render_fetch_tool_config, "search_web" => render_web_search_tool_config, + "skill" => render_skill_tool_config, _ => render_terminal_tool_config, // fallback } } @@ -1388,6 +1389,7 @@ tool_config_page_fn!(render_move_path_tool_config, "move_path"); tool_config_page_fn!(render_create_directory_tool_config, "create_directory"); tool_config_page_fn!(render_fetch_tool_config, "fetch"); tool_config_page_fn!(render_web_search_tool_config, "search_web"); +tool_config_page_fn!(render_skill_tool_config, "skill"); #[cfg(test)] mod tests {