From d86d6f44df2a3cfec01f04bf66a7b48df26b0c11 Mon Sep 17 00:00:00 2001 From: Ben Kunkle Date: Fri, 15 May 2026 10:04:55 -0500 Subject: [PATCH] docs: Re-add missing cookie banner env var in build (#56889) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --- .github/workflows/after_release.yml | 1 + .github/workflows/deploy_docs.yml | 4 ++++ .github/workflows/deploy_nightly_docs.yml | 1 + .github/workflows/run_tests.yml | 1 + tooling/xtask/src/tasks/workflows/deploy_docs.rs | 12 ++++++++++++ tooling/xtask/src/tasks/workflows/vars.rs | 1 + 6 files changed, 20 insertions(+) diff --git a/.github/workflows/after_release.yml b/.github/workflows/after_release.yml index f6777aa2c0..7ffcfe1b32 100644 --- a/.github/workflows/after_release.yml +++ b/.github/workflows/after_release.yml @@ -44,6 +44,7 @@ jobs: uses: zed-industries/zed/.github/workflows/deploy_docs.yml@main secrets: DOCS_AMPLITUDE_API_KEY: ${{ secrets.DOCS_AMPLITUDE_API_KEY }} + DOCS_CONSENT_IO_INSTANCE: ${{ secrets.DOCS_CONSENT_IO_INSTANCE }} CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }} CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} with: diff --git a/.github/workflows/deploy_docs.yml b/.github/workflows/deploy_docs.yml index c66a56f160..6c492135ea 100644 --- a/.github/workflows/deploy_docs.yml +++ b/.github/workflows/deploy_docs.yml @@ -16,6 +16,9 @@ on: DOCS_AMPLITUDE_API_KEY: description: DOCS_AMPLITUDE_API_KEY required: true + DOCS_CONSENT_IO_INSTANCE: + description: DOCS_CONSENT_IO_INSTANCE + required: true CLOUDFLARE_API_TOKEN: description: CLOUDFLARE_API_TOKEN required: true @@ -39,6 +42,7 @@ jobs: runs-on: namespace-profile-16x32-ubuntu-2204 env: DOCS_AMPLITUDE_API_KEY: ${{ secrets.DOCS_AMPLITUDE_API_KEY }} + DOCS_CONSENT_IO_INSTANCE: ${{ secrets.DOCS_CONSENT_IO_INSTANCE }} CC: clang CXX: clang++ steps: diff --git a/.github/workflows/deploy_nightly_docs.yml b/.github/workflows/deploy_nightly_docs.yml index 340713e0a4..91dcc6a277 100644 --- a/.github/workflows/deploy_nightly_docs.yml +++ b/.github/workflows/deploy_nightly_docs.yml @@ -13,6 +13,7 @@ jobs: uses: zed-industries/zed/.github/workflows/deploy_docs.yml@main secrets: DOCS_AMPLITUDE_API_KEY: ${{ secrets.DOCS_AMPLITUDE_API_KEY }} + DOCS_CONSENT_IO_INSTANCE: ${{ secrets.DOCS_CONSENT_IO_INSTANCE }} CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }} CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} with: diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index 8dc3daec56..1210b9b36b 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -668,6 +668,7 @@ jobs: runs-on: namespace-profile-16x32-ubuntu-2204 env: DOCS_AMPLITUDE_API_KEY: ${{ secrets.DOCS_AMPLITUDE_API_KEY }} + DOCS_CONSENT_IO_INSTANCE: ${{ secrets.DOCS_CONSENT_IO_INSTANCE }} CC: clang CXX: clang++ steps: diff --git a/tooling/xtask/src/tasks/workflows/deploy_docs.rs b/tooling/xtask/src/tasks/workflows/deploy_docs.rs index 894e485fa9..fa6f925bf7 100644 --- a/tooling/xtask/src/tasks/workflows/deploy_docs.rs +++ b/tooling/xtask/src/tasks/workflows/deploy_docs.rs @@ -86,6 +86,7 @@ fn docs_build_steps( steps::use_clang( job.add_env(("DOCS_AMPLITUDE_API_KEY", vars::DOCS_AMPLITUDE_API_KEY)) + .add_env(("DOCS_CONSENT_IO_INSTANCE", vars::DOCS_CONSENT_IO_INSTANCE)) .add_step( steps::checkout_repo().when_some(checkout_ref, |step, checkout_ref| { step.with_ref(checkout_ref) @@ -269,6 +270,10 @@ pub(crate) fn deploy_docs_workflow_call( "DOCS_AMPLITUDE_API_KEY".to_owned(), vars::DOCS_AMPLITUDE_API_KEY.to_owned(), ), + ( + "DOCS_CONSENT_IO_INSTANCE".to_owned(), + vars::DOCS_CONSENT_IO_INSTANCE.to_owned(), + ), ( "CLOUDFLARE_API_TOKEN".to_owned(), vars::CLOUDFLARE_API_TOKEN.to_owned(), @@ -327,6 +332,13 @@ pub(crate) fn deploy_docs() -> Workflow { required: true, }, ), + ( + "DOCS_CONSENT_IO_INSTANCE".to_owned(), + WorkflowCallSecret { + description: "DOCS_CONSENT_IO_INSTANCE".to_owned(), + required: true, + }, + ), ( "CLOUDFLARE_API_TOKEN".to_owned(), WorkflowCallSecret { diff --git a/tooling/xtask/src/tasks/workflows/vars.rs b/tooling/xtask/src/tasks/workflows/vars.rs index 6f6fca5e2a..5923c7a1c5 100644 --- a/tooling/xtask/src/tasks/workflows/vars.rs +++ b/tooling/xtask/src/tasks/workflows/vars.rs @@ -54,6 +54,7 @@ secret!(R2_SECRET_ACCESS_KEY); secret!(CLOUDFLARE_API_TOKEN); secret!(CLOUDFLARE_ACCOUNT_ID); secret!(DOCS_AMPLITUDE_API_KEY); +secret!(DOCS_CONSENT_IO_INSTANCE); // todo(ci) make these secrets too... var!(AZURE_SIGNING_ACCOUNT_NAME);