From ea77ca2818f3e059a2b61ecc7e63b67e01e1cec5 Mon Sep 17 00:00:00 2001 From: Pavel Druzhinin <34269347+paveldroo@users.noreply.github.com> Date: Mon, 20 Jul 2026 18:20:16 +0300 Subject: [PATCH] Fix keybindings conflict for Project Search filters and Text Findex (#60677) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Objective Fixes #60540 ## Solution I suggest to focus on new feature keybindings support `Text Finder` instead of supporting old `DeployReplace`: 1. Add `cmd+opt+f` bind for `Text Finder` in `Editor` and `BufferSearch` to all platforms (now it's not there) 2. Remove `cmd+opt+f` bind for `buffer_search::DeployReplace` from `Editor` and `BufferSearch` on macOS. 3. Add breaking changes `buffer_search::DeployReplace` has no keybind anymore on macOS. ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Showcase
Click to view showcase Uploading github.mov…
--- Release Notes: - `Text Search` now opens from almost all contexts (added `Editor`, `BufferSearch`) - Breaking changes: Dropped support for toggle filters hotkey in `BufferSearch` in macOS instead of supporting new `Text Search` feature with `cmd+alt+f` --- assets/keymaps/default-linux.json | 2 ++ assets/keymaps/default-macos.json | 5 ++--- assets/keymaps/default-windows.json | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/assets/keymaps/default-linux.json b/assets/keymaps/default-linux.json index 834568fbe5..5b0476282f 100644 --- a/assets/keymaps/default-linux.json +++ b/assets/keymaps/default-linux.json @@ -146,6 +146,7 @@ "ctrl-shift-backspace": "editor::GoToPreviousChange", "ctrl-shift-alt-backspace": "editor::GoToNextChange", "alt-enter": "editor::OpenSelectionsInMultibuffer", + "ctrl-alt-f": "text_finder::Toggle", }, }, { @@ -413,6 +414,7 @@ "ctrl-f": "search::FocusSearch", "ctrl-h": "search::ToggleReplace", "ctrl-l": "search::ToggleSelection", + "ctrl-alt-f": "text_finder::Toggle", }, }, { diff --git a/assets/keymaps/default-macos.json b/assets/keymaps/default-macos.json index 639ab247ee..b44a32c086 100644 --- a/assets/keymaps/default-macos.json +++ b/assets/keymaps/default-macos.json @@ -163,12 +163,12 @@ "cmd-shift-enter": "editor::NewlineAbove", "cmd-k z": "editor::ToggleSoftWrap", "cmd-f": "buffer_search::Deploy", - "cmd-alt-f": "buffer_search::DeployReplace", "cmd-alt-l": ["buffer_search::Deploy", { "selection_search_enabled": true }], "cmd-e": "buffer_search::UseSelectionForFind", "cmd->": "agent::AddSelectionToThread", "cmd-alt-e": "editor::SelectEnclosingSymbol", "alt-enter": "editor::OpenSelectionsInMultibuffer", + "alt-cmd-f": "text_finder::Toggle", }, }, { @@ -452,9 +452,9 @@ "cmd-shift-enter": "editor::ToggleFoldAll", "alt-enter": "search::SelectAllMatches", "cmd-f": "search::FocusSearch", - "cmd-alt-f": "search::ToggleReplace", "cmd-alt-l": "search::ToggleSelection", "cmd-shift-o": "outline::Toggle", + "alt-cmd-f": "text_finder::Toggle", }, }, { @@ -561,7 +561,6 @@ "alt-enter": "search::SelectAllMatches", "alt-cmd-c": "search::ToggleCaseSensitive", "alt-cmd-w": "search::ToggleWholeWord", - "alt-cmd-f": "project_search::ToggleFilters", "alt-cmd-x": "search::ToggleRegex", "cmd-k shift-enter": "pane::TogglePinTab", }, diff --git a/assets/keymaps/default-windows.json b/assets/keymaps/default-windows.json index 7f31683801..c2723cf396 100644 --- a/assets/keymaps/default-windows.json +++ b/assets/keymaps/default-windows.json @@ -142,6 +142,7 @@ "ctrl-shift-backspace": "editor::GoToPreviousChange", "ctrl-shift-alt-backspace": "editor::GoToNextChange", "alt-enter": "editor::OpenSelectionsInMultibuffer", + "ctrl-alt-f": "text_finder::Toggle", }, }, { @@ -416,6 +417,7 @@ "ctrl-f": "search::FocusSearch", "ctrl-h": "search::ToggleReplace", "ctrl-l": "search::ToggleSelection", + "ctrl-alt-f": "text_finder::Toggle", }, }, {