Keith Simmons
b03abdb6df
Reduce accessibility of multibuffer read to reduce risk of borrowing snapshot and buffer refcells twice
2022-05-13 16:58:30 -07:00
Keith Simmons
157de669ae
Merge pull request #973 from zed-industries/selections-refactor
...
Pull selections out of editor into selections collection
2022-05-13 16:07:26 -07:00
Keith Simmons
2a984285a2
store buffer and display_map model handles on selections collection
2022-05-13 15:55:27 -07:00
Keith Simmons
851e04d46b
Passing tests and removed local argument. Also pulled autoscroll argument out to change_selections
2022-05-13 15:55:27 -07:00
Keith Simmons
9b46bb0ee6
Move selection helpers to SelectionCollection, add update_anchor_selections, add a number of invariant preserving mutation functions to the MutableSelectionCollection
2022-05-13 15:55:17 -07:00
Nathan Sobo
472b313309
Put context parameter last in toggle_modal callback
...
This is more consistent with our treatment of context params everywhere else.
2022-05-10 16:46:53 -06:00
Max Brunsfeld
3e9daa2377
Give hover state to picker items, keystrokes in command palette
2022-04-28 15:17:56 -07:00
Max Brunsfeld
3bcb97f912
Rename Selector -> Picker in theme
2022-04-28 14:45:32 -07:00
a8a55600c9
Navigate to best match when updating outline view query
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Keith Simmons <keith@the-simmons.net >
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2022-04-19 10:12:42 -06:00
Max Brunsfeld
04cbb7b727
Use Picker in Outline view
2022-04-18 17:11:39 -07:00
Max Brunsfeld
ff345ba696
Load modal key bindings from JSON file
2022-04-10 11:39:43 -07:00
0cf9925cb1
Restructure action macro to assign a namespace to every action
...
Also, allow arbitrary types to be used as Actions via the impl_actions macro
Co-authored-by: Nathan Sobo <nathan@zed.dev >
Co-authored-by: Keith Simmons <keith@zed.dev >
2022-04-07 16:20:49 -07:00
Antonio Scandurra
ce2a590521
Merge pull request #748 from zed-industries/fix-outline-panic
...
Don't assume there are always matches in outline view
2022-04-07 09:49:13 +02:00
Max Brunsfeld and Keith Simmons
dce66e6f9e
Move Settings to its own crate
...
Co-authored-by: Keith Simmons <keith@zed.dev >
2022-04-06 10:23:33 -07:00
Nathan Sobo
ffbf1f890e
Don't assume there are always matches in outline view
2022-04-06 09:33:47 -06:00
Antonio Scandurra and Nathan Sobo
04d1c52456
Allow flex items to float to the end of the flex axis
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-30 16:46:14 +02:00
Antonio Scandurra
a0ca4a13f8
Rename editor::Event::Edited to editor::Event::BufferEdited
...
This is to distinguish it from a new event we're about to add which
represent edits originating from that specific editor.
2022-03-24 08:55:46 +01:00
Antonio Scandurra
0de3f0980f
Automatically unfollow when editing, scrolling or changing selections
2022-03-22 09:17:01 +01:00
Antonio Scandurra and Nathan Sobo
e158b79115
Rename app_state to global in gpui
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-17 14:33:01 +01:00
Max Brunsfeld
836480a3e3
Merge branch 'main' into settings-file
2022-03-13 10:43:23 -07:00
Max Brunsfeld
d2a4b6888c
Store settings as a global via a gpui app_state
2022-03-11 15:58:58 -08:00
Nathan Sobo
150fdc71af
Start on text highlight support
2022-03-09 20:51:35 -07:00
Keith Simmons
8585bc9e56
Make theme selector eagerly display the selected theme
2022-03-08 18:42:31 -08:00
Max Brunsfeld
3a1a9ecb45
Disable doctests for all libraries
...
We don't use them, and they add a lot of noise to the test output
when running all tests in the workspace.
2022-03-03 16:15:56 -08:00
Nathan Sobo
5f24a95e7e
Make versions oldest_selection and newest_selection that don't require snapshots
...
I thought I needed this but actually didn't, but I still kinda think it's a good change for the public interface of Editor.
2022-02-27 13:02:09 -07:00
Max Brunsfeld and Nathan Sobo
20d923b53e
Provide editor styling information separately from editor settings
...
* Since regular editors' font sizes and families are controlled by
the settings and not the theme, don't store a dummy text style in
the theme. Instead, only store a font color, and synthesize
the text style for regular editors using both the theme and the
settings.
* Style single-line and auto-height editors (now called "field
editors") using a single function that takes the entire theme and
selects a relevant sub-object.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-02-24 16:42:00 -08:00
Max Brunsfeld
8d1a1c61dd
Start work on syntax highlighting completions
2022-02-02 18:14:30 -08:00
b485554e64
Take an Into<AnyViewHandle> in ChildView::new
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2022-01-27 17:54:45 +01:00
Antonio Scandurra and Nathan Sobo
ade37e946c
Make "go to definition" work in project diagnostics
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-20 17:30:30 +01:00
Max Brunsfeld
bfe0cefa38
Avoid changing selection in buffer navigation dialogs
...
If an editor has highlighted_rows, autoscroll it to reveal those rows instead of
its cursor positions.
2022-01-18 17:29:33 -08:00
Antonio Scandurra
b9d8def8cc
Always re-render outline view when changing the active selection
2022-01-17 10:17:11 +01:00
Max Brunsfeld
c48ad4015b
Add bottom margin to the outline view
2022-01-14 11:01:20 -08:00
Max Brunsfeld
570acbe732
Avoid panic in OutlineView when active item isn't an editor
2022-01-14 10:51:26 -08:00
e1bf476b29
Add select_first and select_last bindings to outline view
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-14 10:45:37 -08:00
6372b5908e
Center the selected item when updating outline query
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-14 17:53:06 +01:00
Antonio Scandurra and Nathan Sobo
5aab69847b
Dismiss outline view when the query editor is blurred
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-14 17:25:24 +01:00
Antonio Scandurra and Nathan Sobo
b7dccb6e5b
Associate StringMatchCandidate with an id
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-14 14:55:03 +01:00
Antonio Scandurra and Nathan Sobo
872625e22d
Highlight matches by increasing the font weight
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-14 14:39:15 +01:00
Antonio Scandurra
c15d590dd3
Don't emit duplicate text when mixing syntax highlighting and match indices
2022-01-14 10:08:08 +01:00
Max Brunsfeld
3dd4c39edd
Incorporate syntax highlighting into symbol outline view
...
Still need to figure out how to style the fuzzy match characters
now that there's syntax highlighting. Right now, they are
underlined in red.
2022-01-13 18:10:02 -08:00
Max Brunsfeld
09cc3bd94d
Include highlighting runs in Outline
2022-01-13 14:46:15 -08:00
Max Brunsfeld
a1a9c9356d
Allow multiple disjoint nodes to be captured as matcheable in the outline query
2022-01-13 14:04:25 -08:00
Max Brunsfeld and Antonio Scandurra
b792fa22db
Implement navigation via outline modal
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-01-13 11:48:44 -08:00
Antonio Scandurra and Max Brunsfeld
2d08f4fba7
Select the closest outline item when the outline view's query is empty
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2022-01-13 18:43:49 +01:00
Antonio Scandurra and Max Brunsfeld
fad016d316
Return Outline<Anchor> from MultiBuffer::outline
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2022-01-13 18:24:00 +01:00
Antonio Scandurra and Nathan Sobo
256cf3831d
Implement selecting prev and next in outline view
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-13 16:44:06 +01:00
Antonio Scandurra
890c3b8767
Allow searching of outline items
2022-01-13 15:10:50 +01:00
Antonio Scandurra
fc0c9ffbb7
Start on rendering the outline view
2022-01-13 12:01:11 +01:00
Max Brunsfeld and Nathan Sobo
72a4ddd689
Add Buffer::outline method
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-01-12 18:17:49 -08:00
Keith Simmons