Antonio Scandurra and Max Brunsfeld
6c5de48e00
Avoid ending the pending selection until updating selections
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-11-03 19:07:06 +01:00
b09850a993
Make resolving selections generic
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-11-03 17:51:57 +01:00
Max Brunsfeld and Nathan Sobo
7270358c7c
Move protobuf logic from buffer crate to language crate
...
This will enable us to add operations that only pertain to the language crate.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-11-01 14:05:19 -07:00
Antonio Scandurra
d941e129e7
Take a &clock::Global instead of cloning in edits_since
2021-11-01 10:48:20 +01:00
Antonio Scandurra and Nathan Sobo
8a5bee616d
Communicate with language servers in terms of UTF-16 coordinates
...
This required indexing UTF-16 positions in `Rope`. We tried opting
into the UTF-8 experimental support but it didn't seem to work
correctly and the standard is UTF-16 anyway.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-29 18:33:23 +02:00
Max Brunsfeld
825fb94fc6
Merge branch 'anchor-map-selections' into lsp
2021-10-28 17:08:06 -07:00
Max Brunsfeld
9af0d07f23
Create valid disjoint selection sets in selections_in_ranges
2021-10-28 16:04:16 -07:00
Antonio Scandurra and Max Brunsfeld
4fdefb4cb3
Start fixing compilation errors on Editor
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-10-28 19:36:43 +02:00
Antonio Scandurra and Max Brunsfeld
6279e74712
Clip points coming from language server
...
This avoids panicking in Zed if the points they give us are invalid.
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-10-28 19:02:26 +02:00
Antonio Scandurra
e260151c5f
Report new_lines extent correctly when coalescing edits
2021-10-28 11:32:10 +02:00
Nathan Sobo and Max Brunsfeld
85892ad428
Adjust disk-based diagnostics based on edits since the last save
...
Still need to add tests... not sure if this is right yet.
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2021-10-27 18:58:07 -06:00
61c1354415
Introduce FullOffset type
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2021-10-27 18:30:00 -06:00
Antonio Scandurra
10ad2d113c
Fix bug in to_full_offset when Anchor::version != Content::version
2021-10-27 11:56:04 +02:00
Max Brunsfeld and Nathan Sobo
a827f6b6d7
Generalize AnchorRangeMultimap's 'intersecting ranges' API
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-26 17:56:39 -07:00
Max Brunsfeld
fef3c44f4a
Allow retrieving a buffer's diagnostics
2021-10-26 15:46:08 -07:00
Antonio Scandurra
a6d95b9652
WIP
2021-10-26 19:42:40 +02:00
Antonio Scandurra
165161687c
Introduce Content::anchor_range_multimap
2021-10-26 14:28:02 +02:00
Max Brunsfeld and Nathan Sobo
2cfdf3096e
Start work on AnchorRangeMultimap
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-25 21:42:55 -07:00
Nathan Sobo
0beb4ffe93
Get language and project compiling
2021-10-25 09:26:36 -06:00
Nathan Sobo
27d84b4f56
Get buffer compiling with new SelectionSets based on AnchorRangeMap
...
One test is failing however.
2021-10-22 14:12:16 -06:00
Nathan Sobo
1d85cf2ef5
WIP: Start converting SelectionSet to use AnchorRangeMap
2021-10-22 13:19:19 -06:00
Nathan Sobo
ddbc43beb3
Implement TryFrom<proto::SelectionSet> on SelectionSet
...
More prep work for changing the selection set representation.
2021-10-22 12:46:02 -06:00
Nathan Sobo
df9dad2804
Simplify protocol messages related to selection sets
...
This prepares the way to switch to using AnchorRangeMaps to store and transmit selection sets.
2021-10-22 12:35:29 -06:00
Nathan Sobo
f9abbd1900
Move SelectionSet and Into impl to selection module
2021-10-22 09:56:47 +02:00
6d8aa9f7d8
Assign new file handles on buffers when their files change on disk
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-21 13:08:54 +02:00
Max Brunsfeld
7a3a9575e2
Rename TextBuffer back to Buffer
2021-10-21 11:12:19 +02:00
Max Brunsfeld
3f96f0aa6f
Remove unnecessary dependencies in buffer and language crates
2021-10-21 09:40:50 +02:00
Max Brunsfeld
34cda9fe9b
Extract a language crate
2021-10-20 22:51:40 +02:00
Max Brunsfeld
a0d4443c38
Re-enable randomized concurrent edits test
2021-10-20 21:44:26 +02:00
b84f5e3940
Extract a TextBuffer from Buffer, which has no tree or file
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-20 00:10:57 +02:00
230307ce59
Insert an extra newline between brackets
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2021-10-19 13:17:16 +02:00
Nathan Sobo
1a48b3e5e6
Restore all active selections when undoing/redoing autoindent
...
In the unlikely event that we're handling autoindent requests from multiple editors, we undo/redo selections from both editors. This is somewhat imperfect but probably good enough and easier than performing auto-indents on a per-editor basis.
2021-10-11 17:22:18 -06:00
Max Brunsfeld
1d24ca172f
Move selections explicitly when applying autoindents
2021-10-11 15:27:38 -07:00
Max Brunsfeld
991d42724a
Move buffer tests into their own file
2021-10-11 12:18:31 -07:00
Max Brunsfeld and Nathan Sobo
71ed81bc93
Ensure that autoindent task yields frequently to respect cancellation
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-11 11:25:15 -07:00
Antonio Scandurra and Nathan Sobo
f8188c8519
WIP: Determine autoindents asynchronously
...
We still need to insert yield points in `compute_autoindents`.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-11 18:00:48 +02:00
Antonio Scandurra
864ebc7c31
Fix creation of anchors for the inserted portion of an edit
2021-10-11 13:08:50 +02:00
Antonio Scandurra
6471d88238
Always use seek_forward when resolving anchors
2021-10-11 09:37:21 +02:00
Nathan Sobo
a4223aab87
Improve auto-indenting of inserted lines
...
Still not working totally correctly with our new approach, but getting closer.
2021-10-08 22:07:01 -06:00
Max Brunsfeld and Nathan Sobo
149fc28019
Start on new way of comparing old and new indent suggestions
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-08 16:54:27 -07:00
Nathan Sobo and Antonio Scandurra
5b09707cb0
Don't request auto-indent if there is no language assigned on the buffer
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2021-10-08 10:25:16 -06:00
Antonio Scandurra and Nathan Sobo
4c6c4d5750
💄
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-08 17:43:19 +02:00
Antonio Scandurra
db8cac6536
Cancel out outdents and indents referring to the previous row
2021-10-08 12:52:48 +02:00
Antonio Scandurra
66a833c337
Bias the start of an autoindent request towards the right for new text
...
When a newline is inserted, this prevents the request from including
the line on which the newline got inserted.
2021-10-08 12:15:21 +02:00
Max Brunsfeld
470fa86a60
Replace Buffer::request_autoindent API with ::edit_with_autoindent
...
When computing the "previous autoindent suggestion", we can't just
use the old tree and the current text. We need to find out what the
suggestion would have been before we made any changes.
2021-10-07 17:55:23 -07:00
Max Brunsfeld and Nathan Sobo
0053182229
Preserve indentation for lines that are both indented and outdented
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-07 13:55:59 -07:00
Max Brunsfeld
bc1a6ff075
Remove no-longer-used dirty field on buffer::SyntaxTree
...
This became unnecessary when we reworked our reparsing logic
to block from 1ms on each parse.
2021-10-07 12:46:08 -07:00
Max Brunsfeld
8bb2a5f35a
Fix collection of row ranges in Buffer::perform_autoindent
2021-10-07 12:43:26 -07:00
Max Brunsfeld and Antonio Scandurra
3202d11680
Implement selective auto-indent by comparing old and new suggestions
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2021-10-07 10:46:40 -07:00
Antonio Scandurra and Max Brunsfeld
f1aa471d38
WIP
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-10-07 19:09:14 +02:00
