Mikayla Maki
f627bcfe14
Make clippy happy
2022-08-11 15:47:56 -07:00
Mikayla Maki
577e2559b3
Merge branch 'main' into ime-stuff
2022-08-11 15:35:42 -07:00
K Simmons
f2328c2f23
minor rustfmt fix
2022-08-11 11:35:11 -07:00
ForLoveOfCats and Mikayla
fbea44bc5c
One big cleanup pass of clippy lints
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2022-08-10 16:51:01 -07:00
K Simmons
07cab9f3c1
Fix failing tests
2022-08-10 16:26:53 -07:00
K Simmons
9fcea3e805
Pane focus working. Modals seem broken now
2022-08-09 17:15:54 -07:00
K Simmons
b76bd98ed8
WIP compiling but failing with circular reference
2022-08-09 17:15:52 -07:00
K Simmons
98499db694
Switch action dispatch to use MutableAppContext parent utilities and delete parent map from presenter
2022-08-09 17:09:28 -07:00
K Simmons
20770e7240
Event dispatch moved to MutableAppContext. No longer dispatches from presenter. Not currently handling key presses properly
2022-08-09 17:09:16 -07:00
Mikayla Maki and Keith
0c0e66dbfc
changed name of subscription mapping and moved out to file
...
Co-authored-by: Keith <keith@zed.dev >
2022-08-09 16:59:13 -07:00
Mikayla Maki
774256b60e
checkpoint, no idea what's happening
2022-08-09 16:15:53 -07:00
ForLoveOfCats and Mikayla
f2ed63f6a3
Jankily adjust left padding on workspace title in fullscreen
...
This could seriously be done better
Co-authored-by: Mikayla <mikayla@zed.dev >
2022-08-09 19:03:32 -04:00
ForLoveOfCats and Mikayla
67baec6641
Invalidate view when entering/exiting fullscreen
...
This is required for `render_titlebar` to eventually adapt to
fullscreen status to affect the size of left padding on workspace
name to account for the traffic lights presence/absence
Co-authored-by: Mikayla <mikayla@zed.dev >
2022-08-09 19:03:32 -04:00
ForLoveOfCats and Mikayla
27a72ec951
Refactor notification/observation callback pattern in MutableAppContext
...
Pull out duplicate code and clarify some misc behavior. Some of this
existing API feels like it's probably incorrect but that needs more
thorough investigation
Co-authored-by: Mikayla <mikayla@zed.dev >
2022-08-09 19:03:25 -04:00
ForLoveOfCats and Mikayla
3e64a78d7e
Route whether or not a window is fullscreen down into GPUI
...
This still needs to be able to invalidate things to be useful
but it's a good first cut at just making the information available
to platform-agnostic code
Co-authored-by: Mikayla <mikayla@zed.dev >
2022-08-09 19:03:12 -04:00
Max Brunsfeld
3ef9a85cf8
Merge pull request #1462 from zed-industries/crash-on-goto-diagnostic
...
Fix two crashes related to diagnostics and bugs in mouse-based columnar selection
2022-08-03 12:04:56 -07:00
Max Brunsfeld
1606878258
Fix crash and wrong columnar selection when mousing over block lines
2022-08-03 10:19:06 -07:00
Antonio Scandurra
0d5f9f7378
Implement default macOS menu items
...
- `Zed -> Hide`, bound to `cmd-h`
- `Zed -> Hide Others`, bound to `alt-cmd-h`
- `Zed -> Show All`
- `Window -> Minimize`, bound to `cmd-m`
- `Window -> Zoom`
2022-08-03 15:13:30 +02:00
ForLoveOfCats
07dafaac8f
Add cmd+shift+click action for triggering go to type definition
2022-07-29 17:00:07 -04:00
Antonio Scandurra
e24138eae6
Don't insert input when the fn key is held
2022-07-27 12:01:44 +02:00
Antonio Scandurra
874e3bd51d
Dispatch application menu events if custom key equivalent wasn't found
2022-07-27 11:46:47 +02:00
Antonio Scandurra
b02e23a2f3
Honor shift when converting keystroke to native key equivalent
2022-07-27 09:28:56 +02:00
Max Brunsfeld
9a6cd8bdc7
Log instead of showing an alert when exiting due to no GPU
...
Showing the alert resulted in a panic because tasks
dispatched to the app's main GCD queue continue
to run even while the alert is displayed.
2022-07-25 16:13:28 -07:00
Max Brunsfeld
e0e4786d98
Simulate calling of text-insertion APIs in TestAppContext::dispatch_keystroke
2022-07-25 12:20:12 -07:00
Max Brunsfeld
3b9be2d9a9
Add comment about noop performKeyEquivalent function
2022-07-25 11:42:54 -07:00
Antonio Scandurra
bc4a73ad56
Honor shift if pressing command switches keyboard
2022-07-25 11:01:38 +02:00
Antonio Scandurra
bfa490c35d
Merge branch 'main' into ime-support-2
2022-07-22 16:03:38 +02:00
Antonio Scandurra
6141bb52cc
Synthesize CGEvents instead of using charactersByApplyingModifiers
2022-07-22 15:51:34 +02:00
Antonio Scandurra
7526f37d7c
Honor ⌘ when Dvorak-QWERTY is used
2022-07-22 14:52:24 +02:00
Antonio Scandurra
bffe391a34
Discard shift when it causes keyboard to output a different character
2022-07-22 08:15:44 +02:00
Keith Simmons
ab252d559a
Merge pull request #1396 from zed-industries/better-empty-pane
...
Fix Pane Focus Issues
2022-07-21 15:07:03 -07:00
Max Brunsfeld
314bbe31f6
Remove print statements
2022-07-21 13:44:58 -07:00
Max Brunsfeld
b28439face
Remove the set_selected_text_range method from the InputHandler trait
2022-07-21 12:22:12 -07:00
Antonio Scandurra
8faec49db3
Don't dispatch keydown event if editor is still composing
2022-07-21 17:37:32 +02:00
Antonio Scandurra
379f8887ba
Position IME input according to where the selection is rendered
2022-07-21 17:35:40 +02:00
Antonio Scandurra
18c1c8fa97
Always mark keydown events as handled to suppress beep
2022-07-21 15:53:21 +02:00
Antonio Scandurra
c11cb83faa
🎨
2022-07-21 14:39:22 +02:00
Antonio Scandurra
1613207abd
Handle keydown event even when charactersIgnoringModifiers is empty
...
This allows the input system to work in the presence of dead keys.
2022-07-21 14:36:47 +02:00
Antonio Scandurra
7ac7137f6c
Remove input from KeyDownEvent
2022-07-21 14:29:27 +02:00
Antonio Scandurra
aa9a4b6fb4
Remove println statements from NSTextInputClient protocol functions
2022-07-21 13:51:31 +02:00
Antonio Scandurra
0bb08ee3f7
Remove unused {cancel,finish}_composition methods
2022-07-21 13:48:56 +02:00
Antonio Scandurra
cdfa679eef
Restructure IME composition to not follow Chromium so closely
2022-07-21 13:41:55 +02:00
Antonio Scandurra
dbe8a85af5
Treat NSTextInputClient ranges as UTF-16
2022-07-21 13:41:35 +02:00
Antonio Scandurra
02cf03474b
Honor setting the selected range in addition to marking text
2022-07-21 08:57:20 +02:00
K Simmons
b31b867200
Address some issues where panes don't get focused properly, make the focused pane more obvious, and prevent splitting of the pane with no items
2022-07-20 18:52:32 -07:00
Max Brunsfeld
eccd21aad6
Call methods on the focused view during input events
2022-07-20 16:44:26 -07:00
Max Brunsfeld and Antonio Scandurra <antonio@zed.dev
ae72d1da3e
Change interpretation of marked_text and edit when handling input
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev
2022-07-20 09:53:49 -07:00
Antonio Scandurra
1e94068a66
WIP
2022-07-20 18:06:29 +02:00
Antonio Scandurra
1da1545f84
WIP
2022-07-20 15:07:09 +02:00
K Simmons
10f65f70d7
Fix clipping when dragging the mouse with vim-mode enabled and adjust single line editor selections
2022-07-19 17:18:17 -07:00
Mikayla Maki