Commit Graph
25009 Commits
Author SHA1 Message Date
Kirill Bulatov 007e8a8942 Fix enter, tab and shift-tab behavior in project search 2 2023-12-22 18:43:02 +02:00
Piotr Osiewicz dacac5688a Titlebar project menu double click (#3784)
This addresses a bug where popover menus in the titlebar were rendered
only after a 2nd click. The first click was creating the View which the
second one then rendered.
In addition to this, `PopoverMenu::menu` function argument can now
return an `Option<View<T>>` instead of `View<T>` as the creation of the
menu can fail (as it might in case of git popover).

Release Notes:

- N/A
2023-12-22 17:18:12 +01:00
Kirill Bulatov 52d39e5adb Do not display a getting start message when the project is open 2023-12-22 18:06:23 +02:00
Antonio Scandurra 12378b723e Allow horizontal scrolling of tab bar on vertical mouse wheel (#3783)
Now, if we receive a scroll event for an axis, but that axis can't be
scrolled (overflow != scroll), we will apply it to the opposite axis
instead if that axis supports scrolling.

Release Notes:

- N/A
2023-12-22 16:08:29 +01:00
Antonio Scandurra 70436bcbc6 Allow horizontal scrolling of tab bar on vertical mouse wheel
Now, if we receive a scroll event for an axis, but that axis can't be scrolled
(overflow != scroll), we will apply it to the opposite axis instead
if that axis supports scrolling.
2023-12-22 15:56:37 +01:00
Antonio Scandurra 41ead4a91c Dismiss mention notification when x icon is clicked (#3782)
We were emitting the wrong kind of event, which caused the workspace to
never remove the notification.

Release Notes:

- N/A
2023-12-22 15:23:53 +01:00
Antonio Scandurra 6bd3980f84 Dismiss mention notification when x icon is clicked
We were emitting the wrong kind of event, which caused the workspace
to never remove the notification.
2023-12-22 15:12:01 +01:00
Antonio Scandurra 6b913eee15 Reveal item even if project panel was closed while active entry changed (#3781)
The project panel was actually working just fine, the problem was due to
`UniformList` not re-hydrating the element state's scroll offset when
being rendered again.

Release Notes:

- N/A
2023-12-22 14:55:38 +01:00
Kirill Bulatov 81fe89be46 Restore zoom buttons in pane tab bars, fix + button in the terminal one (#3780)
Release Notes:

- N/A
2023-12-22 15:48:38 +02:00
Antonio Scandurra f160e1f7b7 Reveal item even if project panel was closed while active entry changed
The project panel was actually working just fine, the problem was due to
`UniformList` not re-hydrating the element state's scroll offset when
being rendered again.
2023-12-22 14:39:16 +01:00
Kirill Bulatov 1e5d3700ac Restore zoom buttons in pane tab bars, fix + button in the terminal one 2023-12-22 15:32:47 +02:00
Antonio Scandurra 492876b495 Fix dismissing context menu when clicking on an item dispatched action (#3779)
Release Notes:

- N/A
2023-12-22 12:34:08 +01:00
Antonio Scandurra cc12ff10cb Fix panic in completions menu (#3778)
We were shifting all the positions while keeping the original string,
which caused problems later when combining highlighted ranges with
matched indices.

Release Notes:

- N/A
2023-12-22 12:27:52 +01:00
Antonio Scandurra 8cd9512a4e Fix dismissing context menu when clicking on an item dispatched action 2023-12-22 12:27:20 +01:00
Antonio Scandurra 9278f5cce5 Fix panic in completions menu
We were shifting all the positions while keeping the original
string, which caused problems later when combining highlighted
ranges with matched indices.
2023-12-22 12:12:39 +01:00
Kirill Bulatov ac0f7c8bd2 Move multibuffer "go to file" button into the buffer header (#3777)
Release Notes:

- N/A
2023-12-22 12:24:51 +02:00
Kirill Bulatov 004fa540b0 Fix the tests 2023-12-22 12:14:53 +02:00
Joseph T. Lyons 040c3763da Slow down sampling metric collection rate (#3775)
Release Notes:

- N/A
2023-12-22 05:03:38 -05:00
Kirill BulatovandAntonio Scandurra e3179189fa Move multibuffer "go to file" button into the buffer header
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-12-22 12:02:44 +02:00
Kirill Bulatov 9b589acf3d Remove the warnings from element.rs 2023-12-22 12:02:44 +02:00
Joseph T. Lyons 8a8d4bc18f Slow down sampling metric collection rate 2023-12-22 04:52:36 -05:00
Antonio Scandurra ba80e6444b Fix context menu in tab bar (#3776)
Release Notes:

- N/A
2023-12-22 10:35:05 +01:00
Antonio Scandurra 01022e81da Fix context menu in tab bar 2023-12-22 10:23:27 +01:00
Kirill Bulatov b05b91fae7 Highlight termina on external files drag and drop 2023-12-22 10:45:51 +02:00
Antonio Scandurra dacf3af50d Optimize order rendering and border drawing (#3762)
Reverts zed-industries/zed#3761

There was a bug in the previous implementation of `BatchIterator` that
was being masked by how we were using the BSP tree. The bug caused us to
render primitives without honoring the `PrimitiveKind` implicit
ordering.
2023-12-22 09:40:54 +01:00
Antonio Scandurra 3937d86fd7 Avoid painting a background quad if it is fully transparent 2023-12-22 09:29:56 +01:00
Antonio Scandurra f669a184c9 Honor PrimitiveKind ordering when order is the same
This was a bug in the previous implementation that was being masked by
how we were using BSP.
2023-12-22 09:24:01 +01:00
Antonio Scandurra 387ea8c6bf Revert "Revert "Optimize order rendering and border drawing"" 2023-12-22 09:12:18 +01:00
Marshall Bowers f2da6a0cfd Add vertical padding to the picker empty state (#3774)
This PR adds vertical padding to the picker's empty state.

This matches the styles added in #3769.

Release Notes:

- N/A
2023-12-21 23:41:24 -05:00
Marshall Bowers d2c9b0509d Indent contacts in collab panel (#3773)
This PR indents contacts in the collab panel.

Release Notes:

- N/A
2023-12-21 23:35:50 -05:00
Marshall Bowers d8ce4330bc Increase the indent step size for the collab panel (#3772)
This PR increases the indent step size for the collab panel.

This gives the channel list a clearer hierarchy for nested channels, as
well as help align the disclosures with the parent channel's icon.

Release Notes:

- N/A
2023-12-21 23:22:22 -05:00
Marshall Bowers b935d97988 Fix names for Rosé Pine themes (#3771)
This PR fixes the names of the Rosé Pine themes.

We want to keep the Unicode "é" in the theme name, both because this is
the actual name of the theme, and also to maintain parity with Zed1.

Release Notes:

- N/A
2023-12-21 22:45:29 -05:00
Marshall Bowers 13d4de4d36 Fix typo in "Noctis Hibernus" theme name (#3770)
This PR fixes a typo in the name of the "Noctis Hibernus" theme.

Release Notes:

- N/A
2023-12-21 22:36:40 -05:00
Marshall Bowers ba0dfa3fb9 Add vertical padding to the picker entry list (#3769)
This PR adds vertical padding to the list of picker entries.

This prevents us from ending up with entries squished against the edges
of the picker.

Release Notes:

- N/A
2023-12-21 22:36:15 -05:00
Marshall Bowers 2ef25a6cea Add more left padding to title bar (#3768)
This PR adds more left padding to the title bar to achieve the same
positioning of the title bar items that we have in Zed1.

Release Notes:

- N/A
2023-12-21 22:29:30 -05:00
Julia c9e5aa5bc0 Some terminal bugs (#3767)
Fixes:
 - drag and drop into terminal element does not change its style
 - drag and drop terminal tab into main pane then back panics
 - can drop non-terminal items into the terminal pane

Release Notes:

- N/A
2023-12-21 18:05:14 -05:00
Julia 7ef512b426 Prevent drag-dropping non-terminal item into terminal pane 2023-12-21 17:52:29 -05:00
Marshall Bowers 733d995264 Scale down status bar items (#3766)
This PR scales down the sizes of items in the status bar.

This brings us more in line with Zed1.

Release Notes:

- N/A
2023-12-21 17:42:54 -05:00
Marshall Bowers 6919ff1148 Align Picker editor with entries (#3765)
This PR re-aligns the `Picker` editor with the entries after the changes
in #3764.

Release Notes:

- N/A
2023-12-21 17:03:57 -05:00
Marshall Bowers ef7868db22 Increase spacing of ListItems inside Pickers (#3764)
This PR increases the spacing of `ListItem`s inside of `Picker`s to give
the UI some more breathing room.

#### Before

<img width="584" alt="Screenshot 2023-12-21 at 4 36 21 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ed324c0d-e606-4844-b30a-7d5b8b8c9e47">

#### After

<img width="592" alt="Screenshot 2023-12-21 at 4 36 31 PM"
src="https://github.com/zed-industries/zed/assets/1486634/fbbcb230-0048-4310-8e06-07943af6a38e">

Release Notes:

- N/A
2023-12-21 16:43:38 -05:00
Marshall Bowers c07c610080 Use sparse spacing for ListItems in Pickers 2023-12-21 16:33:41 -05:00
Marshall Bowers a665b8ef3a Use a ListItem as the empty state for Pickers 2023-12-21 16:17:04 -05:00
Marshall Bowers 8a288ddfb8 Increase horizontal padding for inset ListItems 2023-12-21 16:07:55 -05:00
Marshall Bowers 7102d1ee65 Use small labels for title bar buttons (#3763)
This PR adjusts the sizing of the labels in the buttons in the title bar
to use the small label size.

This should bring them more in line with how things looked in Zed1.

Release Notes:

- N/A
2023-12-21 15:48:37 -05:00
Antonio Scandurra 745fffba3e Revert "Optimize order rendering and border drawing" (#3761)
Reverts zed-industries/zed#3759

It seems like this is not quite right yet. Reverting until we figure out
what's wrong.
2023-12-21 19:48:59 +01:00
Antonio Scandurra f62a552e21 Revert "Optimize order rendering and border drawing" 2023-12-21 19:40:03 +01:00
Julia 732e405c09 Fix pane drag target not appearing over terminal element 2023-12-21 13:08:48 -05:00
Julia 2b120af824 Prevent panic dragging tab into terminal panel 2023-12-21 12:56:30 -05:00
Joseph T. Lyons 212e668d00 Bump tree-sitter-nu rev id (#3760) 2023-12-21 12:29:49 -05:00
Antonio Scandurra 8644ae15eb Optimize order rendering and border drawing (#3759)
This fixes the slowdowns we were observing when opening the saved
assistant conversations.

Release Notes:

- N/A
2023-12-21 18:19:39 +01:00