Antonio Scandurra
a191e527bf
Introduce InteractiveElement::capture_any_mouse_{down,up}
2023-12-20 14:00:12 +01:00
Antonio Scandurra
d80c00a981
Use InteractiveBounds everywhere we change the cursor style
2023-12-20 13:59:52 +01:00
Piotr Osiewicz
f1d3cab4be
Popover buttons titlebar ( #3732 )
...
Migrate project picker/vcs menu to use popover_menu.
Release Notes:
- N/A
2023-12-20 12:47:53 +01:00
Antonio Scandurra
bc4bf73ddd
Fix sluggish experience when dragging tabs ( #3731 )
...
The problem was caused by a missing call to `WindowContext::notify` when
moving the mouse. Actually, we *did* notify as part of a
`MouseMoveEvent` listener registered in `Interactivity` but that code
path was never exercised because we were clearing the
`pending_mouse_down`.
This pull request fixes the issue by automatically redrawing the window
in gpui when there is an active drag and the mouse moves.
Release Notes:
- N/A
2023-12-20 11:34:09 +01:00
Antonio Scandurra
4a9545870f
Fix sluggish experience when dragging tabs
...
The problem was caused by a missing call to `WindowContext::notify` when
moving the mouse. Actually, we *did* notify as part of a `MouseMoveEvent`
listener registered in `Interactivity` but that code path was never
exercised because we were clearing the `pending_mouse_down`.
This commit fixes the issue by automatically redrawing the window in gpui
when there is an active drag and the mouse moves.
2023-12-20 11:21:55 +01:00
Max Brunsfeld
a27b9afbcb
Ensure that new view observers are called by WindowContext::replace_root_view ( #3730 )
...
This fixes a bug where the window got into a bad, non-interactive state
when opening a project from an empty window.
2023-12-19 17:16:30 -08:00
Max Brunsfeld
a4122f387c
Ensure that new view observers are called by WindowContext::replace_root_view
2023-12-19 17:04:42 -08:00
Max Brunsfeld
a321beb15e
Fix layout of diagnostic blocks ( #3729 )
...
Previously, all of the lines in a multi-line error message were painted
on top of each other. I also simplified the logic for highlighting
backtick-enclosed ranges in a diagnostic message.
2023-12-19 15:49:56 -08:00
Marshall Bowers
6d141d833d
Style go-to-definition links ( #3727 )
...
This PR styles go-to-definition links using the link color from the
theme.
Release Notes:
- N/A
2023-12-19 18:41:45 -05:00
Max Brunsfeld
e7d7c4b055
Fix layout of diagnostic blocks
2023-12-19 15:41:00 -08:00
Julia and Antonio Scandurra
9362e6f11e
Reintroduce LSP diagnostic/status message
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 18:38:25 -05:00
Marshall Bowers
803ff5b096
Map textLink.activeForeground from VS Code to link_text_hover
2023-12-19 18:29:27 -05:00
Marshall Bowers
38a30560ff
Use link_text_hover for go-to-definition links
2023-12-19 18:24:52 -05:00
Marshall Bowers
c2154e3805
Style pane drop targets ( #3726 )
...
This PR styles the pane drop targets using the `drop_target_background`
color from the theme.
We do have to adjust the alpha channel of the color so that it doesn't
obscure the contents of the buffer.
Release Notes:
- N/A
2023-12-19 18:06:21 -05:00
Marshall Bowers
ef7231e167
Style tab drop targets for project entries ( #3725 )
...
This PR styles the drop targets when dragging a project entry onto a tab
or the tab bar.
I also adjusted the existing tab drop targets to use the
`drop_target_background` from the theme.
Release Notes:
- N/A
2023-12-19 17:45:42 -05:00
Max Brunsfeld
3edb17c964
Make collab panel usable from the keyboard, add missing styling ( #3724 )
...
* allow confirming all items via the keyboard
* allow deploying the channel context menu via the keyboard
* add missing selected styling for list items
2023-12-19 14:33:56 -08:00
Max Brunsfeld
2ca38d8863
Add missing selected state and keyboard action for some collab panel items
2023-12-19 14:16:44 -08:00
Max Brunsfeld
112b2fcf39
Don't reset the collab panel when it loses focus
2023-12-19 14:12:29 -08:00
Max Brunsfeld
541ae5993d
Restrcit context for some editor bindings that don't apply to single-line editors
2023-12-19 14:11:59 -08:00
Kirill Bulatov
8dfe7eecae
Better display items from different sources with different z-indices in the same place ( #3723 )
2023-12-20 00:01:37 +02:00
Kirill Bulatov and Antonio Scandurra
2ac6f36ab4
Tidy up z-index handling
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 23:50:42 +02:00
Marshall Bowers
fbc2d8d65f
Fix typo in ButtonCommon doc comment ( #3722 )
...
This PR fixes a small typo in the doc comments for `ButtonCommon`.
Was waiting to roll this up into another PR, but it never ended up
happening.
Release Notes:
- N/A
2023-12-19 16:32:57 -05:00
Kirill Bulatov
13b50e5502
Optimize stack id in-memory layout
2023-12-19 23:31:17 +02:00
Kirill Bulatov and Antonio Scandurra
b4932b264e
Fix more z-index and rendering issues
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 23:30:17 +02:00
bdad88c207
Initial fix of the z-index
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-12-19 23:29:08 +02:00
Marshall Bowers
d5b97db646
Fix typo in "Quote Selection" tooltip ( #3721 )
...
This PR fixes a typo in the "Quote Selection" tooltip.
Release Notes:
- N/A
2023-12-19 16:21:58 -05:00
Marshall Bowers
cbaa666ebe
Apply padding at the toolbar level ( #3720 )
...
This PR adjusts the padding in the toolbar to be applied within the
toolbar itself.
Previously the different elements within the toolbar were applying their
own padding, which led to inconsistencies.
Release Notes:
- N/A
2023-12-19 16:01:03 -05:00
Max Brunsfeld
4162c74b39
Add missing collab panel features ( #3719 )
...
* channel modal
* channel invites in collab panel
2023-12-19 12:16:01 -08:00
Max Brunsfeld and Nathan
e6458a9b07
Clean up commented code
...
Co-authored-by: Nathan <nathan@zed.dev >
2023-12-19 12:06:47 -08:00
Max Brunsfeld and Nathan
cf11738a38
Implement channel modal
...
Co-authored-by: Nathan <nathan@zed.dev >
2023-12-19 12:02:35 -08:00
Marshall Bowers
b9a96abb00
Use child instead of children ( #3718 )
...
This PR refactors some code where we were using `children` when we could
have used `child` instead.
Release Notes:
- N/A
2023-12-19 13:49:52 -05:00
Max Brunsfeld
2e3bb03a0d
wip
2023-12-19 10:20:40 -08:00
Max Brunsfeld
ed56527860
Render channel invites in collab panel, fix unused warnings
2023-12-19 10:20:40 -08:00
Marshall Bowers
f4e1fdbe0b
Style contact finder ( #3717 )
...
This PR styles the contact finder.
<img width="598" alt="Screenshot 2023-12-19 at 12 59 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ca9d9345-bf27-4256-aabc-6017a0c4d217 ">
Release Notes:
- N/A
2023-12-19 13:16:14 -05:00
Julia
9867940dce
Allow editor mouse drag selection outside interactive bounds ( #3716 )
...
Release Notes:
- N/A
2023-12-19 13:07:31 -05:00
Julia
45da851599
Match zed1 scrollbar drag behavior ( #3715 )
...
Still not ideal, but we need to ship and this is more than reasonable
Release Notes:
- N/A
2023-12-19 13:00:26 -05:00
Julia and Antonio Scandurra
38c2a4c897
Allow editor mouse drag selection outside interactive bounds
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 13:00:21 -05:00
Julia and Antonio Scandurra
1464b2c928
Match zed1 scrollbar drag behavior
...
Still not ideal, but we need to ship and this is more than reasonable
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 12:50:06 -05:00
Nate Butler
4d475df8a3
Style assistant panel ( #3711 )
...
[[PR Description]]
Styles most of the assistant panel. A few notes:
- We now cut off the title if it gets to long so the assistant tools
don't get cut off
- I wasn't able to get to the "no api key" state, so that hasn't been
style checked yet.
- A few of icons were updated in this PR
I also added a new tooltip that teaches you a bit about role cycling:
🐜 Known issues 🐜
- There is a bug where zooming the panel makes it shift 1px (@maxdeviant
I think this has to do with panel borders)
- We are showing a timestamp for new conversations before you have sent
a message/launched an assist action. I wasn't sure how to case this out.
Before:
After:
Release Notes:
- N/A
2023-12-19 12:11:18 -05:00
Marshall Bowers
12e666f782
Style buffer search input ( #3713 )
...
This PR styles the text input for the buffer search.
Release Notes:
- N/A
2023-12-19 12:11:06 -05:00
Max Brunsfeld
cb5aec95bb
Fix panel resize ( #3707 )
...
* [x] Reposition right dock handle
* [x] Handle mouse events correctly for drag and drop
* [x] Prevent drag events from passing through the resize handle to the
draggable items in the panels (channels, files)
* [x] Stop the editor gutter from stealing mouse move events
2023-12-19 09:08:56 -08:00
Nate Butler
e041bb3df7
Update assistant editor
2023-12-19 12:04:01 -05:00
Max Brunsfeld
f5e3825dc1
Don't stop propagation on mouse move over editor gutter
2023-12-19 09:02:25 -08:00
Nate Butler
0741529559
Update assistant panel message header, model switcher
2023-12-19 11:58:20 -05:00
Nate Butler
f163f2646b
use to_string to return the format distance string from FormatDistance
2023-12-19 11:57:57 -05:00
Max Brunsfeld
5c16d926c9
Merge branch 'main' into fix-panel-resize
2023-12-19 08:55:55 -08:00
Nate Butler
b0efebaf7d
Add FormatDistance struct, add hide_prefix option
2023-12-19 11:41:14 -05:00
Marshall Bowers
40f36d1109
Wire up the middle mouse button to close tabs ( #3714 )
...
This PR wires up the middle mouse button to close tabs.
Right now we're doing this using `on_mouse_down`, but we need a way in
GPUI2 to have an `on_click` for a mouse button other than the left one.
Release Notes:
- N/A
2023-12-19 11:26:55 -05:00
Nate Butler
f67cf4ad02
Rename format distance test names
2023-12-19 11:19:18 -05:00
Nate Butler
fa882e36ce
Allow format_distance to take a DateTimeType
2023-12-19 11:16:59 -05:00
Antonio Scandurra