Commit Graph
25009 Commits
Author SHA1 Message Date
Nate Butler 5407216c11 Update fold_indicator render 2023-12-15 12:09:06 -05:00
Marshall Bowers 3667bd8b2e Render the collab panel using a gpui::list 2023-12-15 11:56:03 -05:00
Nate Butler 3f3df033af Titlebar cleanup (#3675)
[[PR Description]]

Clean up titlebar design nits

- Remove red borders
- Update menu button styles
- Adjust padding
- Improve tooltips with keybindings

Release Notes:

- N/A
2023-12-15 11:45:52 -05:00
Nate Butler 4b0443826c Add some right side padding in titlebar. 2023-12-15 11:25:24 -05:00
Nate Butler b608193910 Reduce intensity of project panel icons 2023-12-15 11:20:56 -05:00
Nate Butler d3e14a16e4 Remove red borders, improve left side padding 2023-12-15 11:07:40 -05:00
Nate Butler 434a54ad95 Improve tooltip with keybinding styling 2023-12-15 11:07:17 -05:00
Nate Butler b396818f28 Story/Storybook Enhancements (#3674)
[[PR Description]]

- Adds some Story components to reduce the amount of code needed to lay
out stories
- Added the ability to open a story in Zed using a link (see text story)
- Added sections with descriptions and usage.

Release Notes:

- N/A
2023-12-15 10:48:13 -05:00
Nate Butler 6a14da5391 Fix import 2023-12-15 10:33:27 -05:00
Nate Butler b30cddec7d Merge branch 'main' into story-enhancements 2023-12-15 10:26:59 -05:00
Nate Butler 4c85020dac Update storybook2.rs 2023-12-15 10:25:07 -05:00
Antonio Scandurra b4263d317c Move Arena to a thread-local and use it to allocate AnyElement 2023-12-15 16:18:05 +01:00
Antonio Scandurra d325c110b2 Use an Arena to reuse allocations for listeners 2023-12-15 15:13:32 +01:00
Piotr Osiewicz 4f3520e152 search: Reintroduce whole word switch (#3672)
It seems to have been lost in the recent styling pass.

Release Notes:

- N/A
2023-12-15 12:20:54 +01:00
Piotr Osiewicz 7b19cebb4f Dismiss Recent Projects & VCS modals on ESC (#3671)
Release Notes:

- N/A
2023-12-15 12:07:25 +01:00
Kirill Bulatov 81c3315fd4 zed2: Restore buffer search deploy & focus behavior (#3670)
In zed1, cmd-f either opened the search buffer, or focused into it if it
was open already. Search query got updated, if any selection was made on
the moment of cmd-f call.

The PR restores that behavior and also

* fixes a bug when opened diagnostics error always got pasted
* comments out the panic on multibuffer separator click 
* removes extra stdout & stderr debug logging

Release Notes:

- N/A
2023-12-15 12:33:45 +02:00
Kirill Bulatov 55eafa301f Restore zed1 behavior for buffer search deploy 2023-12-15 12:23:03 +02:00
Kirill Bulatov 26292d4df2 Adjust copy/paste buffer only on the copy error action trigger 2023-12-15 11:34:00 +02:00
Kirill Bulatov 8a5c5a5707 Remove extra nits, do not panic on clicking the buffer separator 2023-12-15 11:28:48 +02:00
Joseph T. Lyons 8f26c2770a Tweak wording 2023-12-15 01:47:59 -05:00
Julia 198305c44a Fire focus handlers on draw to avoid timing with newly created item (#3640)
See title

Any focus changes which fire from within a focus handler should be
handled in the next frame

Release Notes:

- N/A
2023-12-14 23:57:24 -05:00
Julia f423a59c9c Give correct focus handle when project search has no matches 2023-12-14 23:49:44 -05:00
Julia ca58e64a15 Merge branch 'main' into focus-handlers-on-draw 2023-12-14 23:08:23 -05:00
Conrad Irwin 25452bee79 Implement user menu (#3636)
Release Notes:

- N/A
2023-12-14 20:30:28 -07:00
Julia 79407febab Give result-less project search a focus handle 2023-12-14 22:29:33 -05:00
Conrad Irwin 53fcb54443 Merge branch 'main' into user-menu 2023-12-14 20:18:20 -07:00
Mikayla Maki 22e76a9f24 Fix some todos, add others (#3669)
As it says on the tin

Release Notes:

-
2023-12-14 19:00:58 -08:00
Julia 398b66a901 Render panel in these tests 2023-12-14 21:33:11 -05:00
Julia cd278df003 Track focus on TestItem 2023-12-14 20:58:59 -05:00
Mikayla 1c80a5911b Add several red outlines 2023-12-14 17:48:49 -08:00
Mikayla 43ae943159 Fix todos in auto-update 2023-12-14 17:00:07 -08:00
Max Brunsfeld a12c976902 Fix overlay rendering when dragging onto the center of a pane (#3667) 2023-12-14 16:59:19 -08:00
Max Brunsfeld c4398f87e5 Fix overlay rendering when dragging onto the center of a pane 2023-12-14 16:52:03 -08:00
Mikayla Maki 23141c8766 Make more performance improvements to GPUI 2 (#3664)
In the 3 charts below, "window draw" has 3 major subroutines. Request
layout, where we walk over the tree and have everything talk to the
layout engine initially. Compute layout, where we have the layout engine
actually do the layout, and then paint, where we use the computed bounds
to populate the scene.


![image_720](https://github.com/zed-industries/zed/assets/1789/d2225389-865f-4c8a-9452-9f611da64dcf)

Things are moving quickly so before/after comparisons are tough. In the
graph above, green bars are from a commit actually pre-dates a merge of
master which increased the complexity of layout. The red bars represent
the state of the world after this PR. Note how we improve the
performance of `paint`.

Improvements:

- Not moving `self` in `Element::paint`. This was moving from the heap
to the stack and imposing a big cost. This is the biggest win in this
PR.
- We got some minor wins by making the stacking order a bigger smallvec
of u8 instead of u32.
- A big win that doesn't show up in this chart is avoiding a double
render of the editor when autoscrolling by never pushing notification
effects or marking the window dirty when notifying during a window draw.

Release Notes:

- N/A
2023-12-14 16:45:58 -08:00
Max Brunsfeld 1b5bcd5833 Fix centering of empty pane text (#3666)
The formatting of the empty pane text regressed in #3665, in which I
also made it possible to drag items onto an empty pane.
2023-12-14 16:44:30 -08:00
Mikayla Maki 3b9965ca36 Merge branch 'main' into perf-2 2023-12-14 16:39:10 -08:00
Max Brunsfeld dbb71b40c7 Fix centering of empty pane text 2023-12-14 16:35:58 -08:00
Max Brunsfeld ed9b54a9a8 Fix stickiness of main pane drag target (#3665)
Reimplement the pane drag targets using on_drag_move
2023-12-14 16:30:02 -08:00
Mikayla Maki be59fd1032 Merge branch 'main' into perf-2 2023-12-14 16:25:40 -08:00
Max Brunsfeld 2e5f766302 Fix stickiness of main pane drag target
Reimplement the pane drag targets using on_drag_move
2023-12-14 16:23:15 -08:00
Mikayla Maki d8bf1ccba6 Fix dock resizing (#3663)
This fixes some bugs in the display and tracking of dock resizes

Release Notes:

-
2023-12-14 16:20:29 -08:00
Nathan Sobo bde23a78d3 Rename draw2 -> draw_and_update_state 2023-12-14 17:20:27 -07:00
Nathan Sobo e89e66090d Merge remote-tracking branch 'origin/main' into perf-2 2023-12-14 17:15:44 -07:00
Mikaylaandconrad e9e31e57aa Fix dock resize handles
co-authored-by: conrad <conrad@zed.dev>
2023-12-14 16:05:10 -08:00
Nathan Sobo 88f0572bad Merge remote-tracking branch 'origin/main' into perf-2 2023-12-14 16:56:36 -07:00
Marshall Bowers 586b9073f3 Fix warning in release mode (#3662)
This PR fixes a warning that was present in release mode, which was
preventing the nightly builds from running:

```
error: variable does not need to be mutable
   --> crates/gpui2/src/elements/div.rs:547:9
    |
547 |     let mut div = Div {
    |         ----^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `-D unused-mut` implied by `-D warnings`
```

Release Notes:

- N/A
2023-12-14 18:52:14 -05:00
Mikaylaandconrad 831e4a5df4 Fix bug in drag move dispatch
co-authored-by: conrad <conrad@zed.dev>
2023-12-14 15:23:24 -08:00
Nate Butler 90bb7c5297 Remove unused imports 2023-12-14 17:56:42 -05:00
Marshall Bowers ae6a3bcf52 Use separate editor foreground color (#3661)
This PR populates the `editor_foreground` color in the various themes
and updates the editor to use this as the color for text.

The `text` field in the theme should now be used for UI elements, while
`editor_foreground` should be used for buffers.

This improves the contrast in some themes, notably Ayu Dark.

Release Notes:

- N/A
2023-12-14 17:54:44 -05:00
Nate Butler 882fede4da WIP IconButton story 2023-12-14 17:51:08 -05:00