Commit Graph
25009 Commits
Author SHA1 Message Date
Antonio Scandurra 0ecb9099e1 💄 2023-11-13 18:33:08 +01:00
Antonio Scandurra 16edc402e2 Fix panic when querying available actions 2023-11-13 18:29:18 +01:00
Nate Butler 5322689909 Checkpoint 2023-11-13 12:09:31 -05:00
Nate Butler 2e18121d4c Update Status Colors 2023-11-13 11:56:42 -05:00
Kirill Bulatov 986ab3badd Make inlay hint cache tests pass (#3310)
Release Notes:

- N/A
2023-11-13 18:42:16 +02:00
Kirill BulatovandConrad 7f6dbeef29 Make inlay hint cache tests pass
Co-Authored-By: Conrad  <conrad.irwin@gmail.com>
2023-11-13 18:25:21 +02:00
Marshall Bowers b8beeaee43 Add Sized bound to StyledExt trait (#3309)
This PR moves the `Sized` bound to the `StyledExt` trait so we don't
have to repeat it on each of the methods.

Release Notes:

- N/A
2023-11-13 11:22:49 -05:00
Marshall Bowers 940cb582b5 Remove unnecessary map 2023-11-13 11:10:08 -05:00
Marshall Bowers 44f67a2763 Move Sized bound to StyledExt trait 2023-11-13 11:10:00 -05:00
Joseph T. Lyons 6f3ef27d85 Update jetbrains keymap to match community repo 2023-11-13 10:41:56 -05:00
Antonio Scandurra 5082646901 Clear all the state when clearing KeyDispatcher 2023-11-13 15:31:35 +01:00
Antonio Scandurra f021e72b06 Register actions on the right div 2023-11-13 15:21:47 +01:00
Antonio Scandurra dc3cc470a7 💄 2023-11-13 15:20:43 +01:00
Antonio Scandurra 3f59bc123f Clear pending keystrokes when finding action 2023-11-13 14:48:08 +01:00
Antonio Scandurra 3a05795b33 Capture node in dispatch tree even if it's not focusable 2023-11-13 14:42:16 +01:00
Antonio Scandurra 873be74687 Fix focus story 2023-11-13 14:35:49 +01:00
Kirill Bulatov 51941e36f2 Uncomment inlay hints logic and tests (#3307)
Tests compile, but do not pass due to todo!s in the platform code, hence
ignored for now.

Release Notes:

- N/A
2023-11-13 15:20:43 +02:00
Kirill Bulatov 1cfaaa7924 Ignore tests for now 2023-11-13 15:02:24 +02:00
Piotr Osiewicz dadb37be50 chore: Bump cc to 1.0.84 (#3304)
This resolves a minor issue where build scripts could've acquired more
job server tokens from Cargo than allowed by `-j` parameter. I've filled
a PR at https://github.com/rust-lang/cc-rs/pull/878 and we've iterated
on the design over there since.

TL;DR: some build scripts may complete a tad bit quicker, potentially
shaving off a few seconds off of debug/release builds. Full description
of the issue is available in
https://github.com/rust-lang/cc-rs/issues/858

Release Notes:

- N/A
2023-11-13 13:14:22 +01:00
Kirill Bulatov 6765223273 Uncomment all inlay hint cache code and tests 2023-11-13 14:07:48 +02:00
Kirill Bulatov 359613ad0e pane: When opening a buffer, actually scroll to the selected tab. (#3306)
Previously it might've reused a shared state.

Deals with https://github.com/zed-industries/community/issues/2262 also
fixes influencer's feedback.

No gpui2 port, due to 0 scrollable functionality in it yet.

Release Notes:

- Fixed tabs not being scrolled to on buffer (re)open
(https://github.com/zed-industries/community/issues/2262)
2023-11-13 13:21:26 +02:00
Kirill BulatovandPiotr dccdf1955c pane: When opening a buffer, actually scroll to the selected tab. Previously it might've reused a shared state.
Deals with https://github.com/zed-industries/community/issues/2262 also fixes influencer's feedback.

Co-Authored-By: Piotr <piotr@zed.dev>
2023-11-13 13:09:02 +02:00
Antonio ScandurraandThorsten 7c56355f10 Register key and action listeners using Interactive::initialize
Co-Authored-By: Thorsten <mrnugget@gmail.com>
2023-11-13 11:37:57 +01:00
Antonio ScandurraandThorsten ce5d3e2e73 Fix panic when calling with_key_dispatch recursively
Co-Authored-By: Thorsten <mrnugget@gmail.com>
2023-11-13 10:17:52 +01:00
Mikayla 99c75d2916 Poke at getting the project panel showing up 2023-11-12 23:22:02 -08:00
Nate Butler 5df63d3568 Theme elevation + Palette Style (#3305)
[[PR Description]]

Release Notes:

- N/A
2023-11-12 22:29:25 -05:00
Nate Butler 13a8138462 Update command palette style 2023-11-12 22:13:54 -05:00
Piotr Osiewicz c01ef1bdad chore: Bump cc to 1.0.84
This resolves a minor issue where build scripts could've acquired more job server tokens from Cargo than allowed by `-j` parameter. I've filled a PR at https://github.com/rust-lang/cc-rs/pull/878 and we've iterated on the design over there since.

TL;DR: some build scripts may complete a tad bit quicker, potentially shaving off a few seconds off of debug/release builds.
2023-11-12 21:28:02 +01:00
Nathan Sobo a3ec1048fd WIP 2023-11-10 14:47:45 -07:00
Nate ButlerandMarshall Bowers abf4debc13 Refactor command palette, picker and code action styles.
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-10 16:13:25 -05:00
Nate ButlerandMarshall Bowers 61fe4fdebd Add ui::Divider component
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-10 16:12:32 -05:00
Nate ButlerandMarshall Bowers 2725e39675 Add elevation to StyledExt
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-10 16:12:14 -05:00
Nathan SoboandAntonio Scandurra f5cc32c077 Add a DispatchTree which will replace the existing key dispatch strategy
Instead of freezing a stack, we will record the entire dispatch tree so we can
change focus.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2023-11-10 11:56:14 -07:00
Antonio Scandurra 2f0339e574 Wire up code actions in editor2 (#3302)
Release Notes:

- N/A
2023-11-10 16:47:09 +01:00
Antonio Scandurra 61693a0e13 🔥 2023-11-10 16:41:21 +01:00
Antonio Scandurra ffd1f0390e Fix bad import 2023-11-10 16:41:21 +01:00
Antonio Scandurra 8482025e74 Allow measuring arbitrary items in UniformList 2023-11-10 16:41:21 +01:00
Antonio Scandurra 3a0bfdf098 Confirm code action on mouse down 2023-11-10 16:41:21 +01:00
Antonio Scandurra 7648abf87d Wire up keyboard interaction in code actions menu 2023-11-10 16:41:21 +01:00
Antonio Scandurra c58a74c03e Make code actions menu prettier 2023-11-10 16:41:21 +01:00
Antonio Scandurra 25930beaf2 Use padded bounds to draw uniform list items 2023-11-10 16:41:21 +01:00
Antonio Scandurra 2343434962 Ensure UniformList style is painted beneath its items 2023-11-10 16:41:21 +01:00
Antonio Scandurra 271bb74856 Ceil measured width for Text element 2023-11-10 16:41:13 +01:00
Kirill Bulatov 95bbdb0ddc Do not add diagnostics for any selection in the diagnostics panel (#3300)
Make the panel less jumpy by deferring diagnostics updates until cmd-s
is pressed, if any caret is placed inside the diagnostics panel.

Release Notes:

- N/A
2023-11-10 13:50:58 +02:00
Kirill Bulatov 943bc66a9a Do not add diagnostics for any selection in the diagnostics panel 2023-11-10 13:35:58 +02:00
Antonio Scandurra 4157559870 Show a very basic code actions menu 2023-11-10 12:26:35 +01:00
Antonio Scandurra 0a12de9f42 Ignore element offset when manually drawing AnyElement 2023-11-10 11:35:57 +01:00
Antonio Scandurra 03050a8dc1 Merge remote-tracking branch 'origin/main' into code-actions-2 2023-11-10 11:01:23 +01:00
Conrad Irwin 2ff4c24205 command palette2 (#3296)
Still to do:
- [ ] Figure out why `ctrl-g` `ctrl-g` doesn't dismiss GoToLine (but
`cmd-shift-p` `cmd-shift-p` does dismiss Command). Likely to do with the
"Editor" context in the keymap, but this did used to work in gpui1.
- [ ] Fix first render with incorrect matches immediately flashes.
- [ ] Show keybindings
- [x] Figure out why `cmd-shift-p "go to line" enter` panics
- [ ] Fix the selected visuals
- [ ] Party hard
- [ ] Uncomment the tests
2023-11-09 22:44:50 -07:00
Conrad Irwin 95c1ae6316 Fix panic caused by focusing the same thing twice 2023-11-09 22:25:46 -07:00