Commit Graph
25009 Commits
Author SHA1 Message Date
Max Brunsfeld b06ede0175 Avoid possible panic in Room::most_active_project
Participants' locations might momentarily reference projects that have already been unshared.
2023-10-09 15:04:01 -07:00
Marshall Bowers 42daa94cc0 Add a story showcasing z-index 2023-10-09 18:00:49 -04:00
Max Brunsfeld 5e9452789d Add a Reconnect action, for simulating connection blips 2023-10-09 14:46:33 -07:00
Max Brunsfeld 057666a0c4 Handle participants' participant index changing
This normally doesn't happen, but it can happen if a participant
loses connection ungracefully, restarts their app, and then
explicitly joins again.
2023-10-09 14:45:19 -07:00
Max Brunsfeld c8032614f6 Log a warning when leader activates an unknown view 2023-10-09 14:29:45 -07:00
Kirill Bulatov 375f338063 Detect file paths that end with : (#3109)
New rustc messages look like

```
thread 'tests::test_history_items_vs_very_good_external_match' panicked at crates/file_finder/src/file_finder.rs:1902:13:
assertion `left == right` failed: Only one history item contains collab_ui, it should be present and others should be filtered out
  left: 0
 right: 1
```

now and we fail to parse that `13:` bit properly, fix that.

One caveat is that we highlight the entire word including the trailing
`:`:
<img width="914" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/d653a8ff-3e6e-4e3d-b6ea-dad0c8db0f06">

this is unfortunate, but better than nothing (as now).
This is due to the fact, that we detect words with regex inside the
`terminal.rs` and send events to other place that's able to check paths
for existence (and whether that's a path at all), currently there's no
way to detect a path and sanitize it in `terminal.rs`

Release Notes:

- N/A
2023-10-09 23:16:03 +02:00
Marshall Bowers e53adde22d Clean up theme loading 2023-10-09 17:00:10 -04:00
Kirill Bulatov 0aca36ab63 Detect file paths that end with :
New rustc messages look like

```
thread 'tests::test_history_items_vs_very_good_external_match' panicked at crates/file_finder/src/file_finder.rs:1902:13:
assertion `left == right` failed: Only one history item contains collab_ui, it should be present and others should be filtered out
  left: 0
 right: 1
```

now and we fail to parse that `13:` bit properly, fix that.
2023-10-09 23:55:58 +03:00
Marshall Bowers 61751d3cdc Change how the default theme gets determined 2023-10-09 16:53:28 -04:00
Max Brunsfeld 1c2db83bd1 Fix bug that allowed following multiple people in one pane (#3108)
I've also simplified the representation of a workspace's leaders, so
that it encodes in the type that there can only be one leader per pane.

Release Notes:

- Fixed a bug where you could accidentally follow multiple collaborators
in one pane at the same time.
2023-10-09 13:50:51 -07:00
Marshall Bowers 1a9a127abb Add theme loading 2023-10-09 16:37:20 -04:00
Kirill Bulatov 9ddb186dd8 Ignore history items' paths when matching search queries (#3107)
Follow-up of https://github.com/zed-industries/zed/pull/3059 

Before: 

![image](https://github.com/zed-industries/zed/assets/2690773/4eb2d2d1-1aa3-40b8-b782-bf2bc5f17b43)

After:

![image](https://github.com/zed-industries/zed/assets/2690773/5587d46b-9198-45fe-9372-114a95d4b7d6)

Release Notes:

- N/A
2023-10-09 22:35:11 +02:00
Max Brunsfeld 65e37b561b Ensure there's only one leader per pane 2023-10-09 13:32:38 -07:00
Max Brunsfeld a41791a817 Add failing test for switching leaders in a pane 2023-10-09 13:30:14 -07:00
Kirill Bulatov 762ef32154 Ignore history items' paths when matching search queries 2023-10-09 23:14:32 +03:00
Marshall Bowers 4cf8fb1143 Add support for switching between the two hardcoded themes 2023-10-09 15:52:57 -04:00
Max Brunsfeld be3525c08e Unify the two local zed scripts, take a flag for an instance count (#3106)
This PR introduces a new script for running Zed against a local collab
server, called `script/zed-local`. This script replaces the two existing
scripts that we had for this purpose: `script/zed-with-local-servers`
and `script/start-local-collaboration`.

By default, the script starts one single instance of Zed, but you can
pass a numeric flag to start 1, 2, 3 or 4 instances. So to start up two
instances side by side, (like `start-local-collaboration` script), you'd
do this:

```
script/zed-local -2
```

But you can also start *three* (or even four) instances, each taking up
a quarter of the screen, like this:

```
script/zed-local -3
```

Like before, you can pass other arguments to the script, and they will
be passed through to the first zed instance.

Also, unlike the `start-local-collaboration` script, this script now
requires a call to GitHub to determine your GitHub username. It just
logs you in as Nathan by default, unless you set `ZED_IMPERSONATE`
explicitly.
2023-10-09 12:52:20 -07:00
Max Brunsfeld 676c7fae34 Update docs to refer to new zed-local script 2023-10-09 12:49:12 -07:00
Max Brunsfeld ac800abdea Unify the 2 local zed scripts, take a flag for instance count 2023-10-09 12:40:36 -07:00
Conrad Irwin 92f876af3e re-trigger build with new profile? 2023-10-09 13:40:22 -06:00
Conrad Irwin 928230ecb2 Only allow one release channel in a call 2023-10-09 12:59:18 -06:00
Julia a45b0c2e23 Fix hover_popover.rs after bad rebase 2023-10-09 14:28:53 -04:00
Conrad Irwin f98ab0f1e3 Focus the currently active project if there is one
(also consider your own projects in "most_active_projects")
2023-10-09 12:05:26 -06:00
Antonio Scandurra 0a1bf65acd WIP 2023-10-09 19:50:48 +02:00
Marshall Bowers d32434779c Add note about CSS hack 2023-10-09 13:39:08 -04:00
Marshall Bowers b604b9ff5b Add a Toast in the bottom-right corner 2023-10-09 13:32:19 -04:00
Marshall Bowers 25ea57bcaf Add div.z_index 2023-10-09 13:19:32 -04:00
Antonio Scandurra c50cc9d7af Checkpoint 2023-10-09 19:13:57 +02:00
Marshall Bowers 0e25444808 Use command modifier for example keybindings in CommandPalette 2023-10-09 12:51:57 -04:00
Marshall Bowers c651d61b78 Add strikethrough support back to Label 2023-10-09 12:33:52 -04:00
Marshall Bowers b9f493c8e5 Add back negative margins, now that they're supported again 2023-10-09 12:33:30 -04:00
Marshall Bowers 18bbdbeedf Update gpui3_macros::style_helpers! based on its gpui2 equivalent 2023-10-09 12:31:22 -04:00
Max Brunsfeld 649e9ca889 Always log panics (#2896)
I just panicked and wanted to see the cause, but forgot that panic files
get deleted when Zed uploads them.

Release Notes:

- Panics are now written to `~/Library/Logs/Zed/Zed.log`
2023-10-09 09:21:08 -07:00
Max Brunsfeld eddb00d506 Add a crate-dep-graph script, remove a few unnecessary dependencies (#3103)
This was motivated by me trying to decide which crate I should put a
`NotificationStore` in.

Run `script/crate-dep-graph` to generate an SVG showing the dependency
graph of our `crates` folder, and open it in a web browser.

After running this command, I noticed a couple of dependencies that
didn't make sense and were easy to remove.

Current dependency graph:

![Screen Shot 2023-10-06 at 1 15 42
PM](https://github.com/zed-industries/zed/assets/326587/b5008235-498a-4562-a826-cc923898c052)
2023-10-09 09:20:06 -07:00
Marshall Bowers 5fc40d5514 Add Details component 2023-10-09 11:55:27 -04:00
Marshall Bowers 18e3610263 Add RecentProjects component 2023-10-09 11:47:22 -04:00
Conrad Irwin 1e6395331b Code quality 2023-10-09 09:44:09 -06:00
Marshall Bowers b764e9a757 Add ThemeSelector component 2023-10-09 11:44:08 -04:00
Marshall Bowers 2903e365d3 Add LanguageSelector component 2023-10-09 11:39:42 -04:00
Marshall Bowers 7cf10db728 Add MultiBuffer component 2023-10-09 11:36:09 -04:00
Marshall Bowers 88747f07cc Remove unused Arc import 2023-10-09 11:32:10 -04:00
Marshall Bowers a3de68152f Add Toast component 2023-10-09 11:31:56 -04:00
Conrad Irwin 9ae2983a6f Add "Copy Link" to channel right click menu 2023-10-09 09:30:00 -06:00
Marshall Bowers 65a292c1af Add ContextMenu component 2023-10-09 11:25:33 -04:00
Marshall Bowers e5ec507a56 Add CommandPalette component 2023-10-09 11:20:10 -04:00
Marshall Bowers 75cabfb6be Add Palette component 2023-10-09 11:15:50 -04:00
Marshall Bowers 5d005d67ce Rename view_type to state_type 2023-10-09 11:11:03 -04:00
Marshall Bowers db426819c4 Add Keybinding component 2023-10-09 11:09:44 -04:00
Marshall Bowers 89b82cd0df Add CollabPanel component 2023-10-09 11:04:53 -04:00
Conrad Irwin 925afa67d0 Fix ./script/bundle to allow passing key 2023-10-09 08:59:25 -06:00