Antonio Scandurra
52730b0e08
Clip UTF-16 offsets provided by Cocoa when composing IME input
2022-07-25 17:32:33 +02:00
Antonio Scandurra
cb2dfa883e
Introduce MultiBuffer::clip_offset_utf16
2022-07-25 15:06:04 +02:00
Antonio Scandurra
37c4f2bbf3
Introduce Rope::clip_offset_utf16
2022-07-25 15:02:45 +02:00
Antonio Scandurra
5b5b5556a4
Handle IME composition with multiple cursors
2022-07-25 14:50:09 +02:00
Antonio Scandurra
bc4a73ad56
Honor shift if pressing command switches keyboard
2022-07-25 11:01:38 +02:00
Antonio Scandurra
47fce17ff8
Merge branch 'main' into ime-support-2
2022-07-25 10:47:49 +02:00
Antonio Scandurra
daff3fc7f6
Coalesce IME compositions into a single edit
2022-07-25 09:53:51 +02:00
Antonio Scandurra
ffdedfe04d
🎨
2022-07-23 09:31:41 +02:00
Antonio Scandurra
db5f26474b
Allow grouping local transactions even if remote peer edits in between
2022-07-23 09:27:21 +02:00
Max Brunsfeld
9e716749e6
Combine adjacent ranges in 'edited_ranges_for_transaction'
2022-07-22 17:41:31 -07:00
Max Brunsfeld and Antonio Scandurra
51868f445b
Remove versioned offset ranges from transactions and undo operations
...
Now, instead of using these versioned offset ranges, we locate the
fragments associated with a transaction using the transaction's
edit ids. To make this possible, buffers now store a new map called
`insertion_slices`, which lets you look up the ranges of insertions
that were affected by a given edit.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2022-07-22 17:28:55 -07:00
Nate Butler
56fc43bb45
WIP for keith
2022-07-22 17:28:58 -04:00
Mikayla Maki
ae5e4ce659
Merge pull request #1393 from zed-industries/graceful-exit
...
Polishing the terminal
2022-07-22 13:59:13 -07:00
Mikayla Maki
013125e978
Finished terminal refactoring
2022-07-22 13:54:46 -07:00
Mikayla Maki
86b761fb93
Refactored a bunch of stuff, working on tidying element code
2022-07-22 12:06:42 -07:00
Max Brunsfeld and Antonio Scandurra
48aff8d05d
Move edited_ranges_for_transaction from BufferSnapshot to Buffer
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2022-07-22 11:24:14 -07:00
Keith Simmons
d8ac0cf838
Merge pull request #1378 from zed-industries/diagnostics-popover
...
Diagnostics Popover
2022-07-22 11:12:56 -07:00
K Simmons
fc42d01661
attempt to fix broken test
2022-07-22 10:55:57 -07:00
Mikayla Maki
68c28d3ecc
Refactored terminal tests
2022-07-22 10:20:15 -07:00
Nate Butler
46cbde862f
Fix reversed disclosure arrows in project panel
2022-07-22 11:57:53 -04:00
Antonio Scandurra
bfa490c35d
Merge branch 'main' into ime-support-2
2022-07-22 16:03:38 +02:00
Antonio Scandurra
6141bb52cc
Synthesize CGEvents instead of using charactersByApplyingModifiers
2022-07-22 15:51:34 +02:00
Antonio Scandurra
7526f37d7c
Honor ⌘ when Dvorak-QWERTY is used
2022-07-22 14:52:24 +02:00
Antonio Scandurra
bffe391a34
Discard shift when it causes keyboard to output a different character
2022-07-22 08:15:44 +02:00
Max Brunsfeld
ef1e089260
Remove test for handling input via key events
...
Now, textual input is handled by a different code path than other key events.
2022-07-21 21:40:37 -07:00
Max Brunsfeld
f362b2b527
Adjust editor tests to use input APIs instead of key events
2022-07-21 21:36:40 -07:00
Max Brunsfeld
1ac16da8e8
Add simple IME handling to the terminal
2022-07-21 21:32:58 -07:00
Keith Simmons
ab252d559a
Merge pull request #1396 from zed-industries/better-empty-pane
...
Fix Pane Focus Issues
2022-07-21 15:07:03 -07:00
K Simmons
ba17408e36
Minor naming improvements and revert empty pane background color change
2022-07-21 14:56:17 -07:00
Max Brunsfeld
314bbe31f6
Remove print statements
2022-07-21 13:44:58 -07:00
Max Brunsfeld
a4d997214e
Remove Input action, detect ignored input in vim via an event
2022-07-21 13:40:48 -07:00
Max Brunsfeld
1173626be7
Prevent IME window from appearing while editor's input is disabled (vim)
2022-07-21 12:48:36 -07:00
Mikayla Maki
b960af3cb0
Finished erorr terminal refactoring
2022-07-21 12:37:15 -07:00
Max Brunsfeld
b28439face
Remove the set_selected_text_range method from the InputHandler trait
2022-07-21 12:22:12 -07:00
Mikayla Maki
b1a384f96c
added cursor text back
2022-07-21 10:04:12 -07:00
Antonio Scandurra
8faec49db3
Don't dispatch keydown event if editor is still composing
2022-07-21 17:37:32 +02:00
Antonio Scandurra
379f8887ba
Position IME input according to where the selection is rendered
2022-07-21 17:35:40 +02:00
Antonio Scandurra
18c1c8fa97
Always mark keydown events as handled to suppress beep
2022-07-21 15:53:21 +02:00
Antonio Scandurra
c11cb83faa
🎨
2022-07-21 14:39:22 +02:00
Antonio Scandurra
1613207abd
Handle keydown event even when charactersIgnoringModifiers is empty
...
This allows the input system to work in the presence of dead keys.
2022-07-21 14:36:47 +02:00
Antonio Scandurra
7ac7137f6c
Remove input from KeyDownEvent
2022-07-21 14:29:27 +02:00
Antonio Scandurra
aa9a4b6fb4
Remove println statements from NSTextInputClient protocol functions
2022-07-21 13:51:31 +02:00
Antonio Scandurra
0bb08ee3f7
Remove unused {cancel,finish}_composition methods
2022-07-21 13:48:56 +02:00
Antonio Scandurra
cdfa679eef
Restructure IME composition to not follow Chromium so closely
2022-07-21 13:41:55 +02:00
Antonio Scandurra
dbe8a85af5
Treat NSTextInputClient ranges as UTF-16
2022-07-21 13:41:35 +02:00
Antonio Scandurra
d103825bc6
Start indexing UTF-16 offsets
...
This is needed because cocoa will report ranges as UTF-16 indices.
2022-07-21 09:40:48 +02:00
Antonio Scandurra
02cf03474b
Honor setting the selected range in addition to marking text
2022-07-21 08:57:20 +02:00
K Simmons
2e0f73ff3a
fix test failure
2022-07-20 19:13:16 -07:00
K Simmons
e43451b8be
tweak diagnostic popover colors
2022-07-20 19:02:33 -07:00
K Simmons
3d9beeb468
address warnings
2022-07-20 19:02:33 -07:00
Antonio Scandurra