Max Brunsfeld
34954ab8b2
Extend empty diagnostic ranges at the ends of lines
2021-11-03 13:49:39 -07:00
Max Brunsfeld
c38aaf003d
Remove logging in worktree tests
2021-11-03 12:36:57 -07:00
Max Brunsfeld
06829caeab
In the status bar, show the diagnostic under the cursor
2021-11-03 12:33:16 -07:00
54e78b0461
End pending selection when starting a transaction
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-11-03 19:15:54 +01:00
Antonio Scandurra and Max Brunsfeld
6c5de48e00
Avoid ending the pending selection until updating selections
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-11-03 19:07:06 +01:00
b09850a993
Make resolving selections generic
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-11-03 17:51:57 +01:00
7d77e68984
Introduce a status bar and add the cursor position to it
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-11-03 17:27:51 +01:00
Antonio Scandurra
f79e43103d
Merge pull request #218 from zed-industries/lsp
...
Integrate rust-analyzer and highlight diagnostics
2021-11-03 10:17:13 +01:00
Antonio Scandurra
42921ac2ad
Request autoscroll when undoing/redoing
2021-11-03 09:44:23 +01:00
Antonio Scandurra
3ea225fc3d
Fix test for disk-based diagnostics
2021-11-03 09:39:15 +01:00
Max Brunsfeld
d5c0172d76
Use status colors for diagnostic underlines
2021-11-02 17:51:18 -07:00
Max Brunsfeld and Nathan Sobo
837244e938
Start language servers based on buffers' languages
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-11-02 17:41:01 -07:00
Max Brunsfeld
174efb1a04
Add an integration test for replicating buffer's diagnostics
2021-11-02 14:57:24 -07:00
Max Brunsfeld
95e6765d21
Avoid using worktree handle in File's path methods
...
This avoids a circular model update that was happening
when trying to retrieve the absolute path from a buffer's
file while applying remote operations.
2021-11-02 14:33:55 -07:00
Max Brunsfeld and Nathan Sobo
355e2bf5c8
Deserialize buffer's diagnostics
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-11-02 12:29:03 -07:00
e1e2240199
Explicitly shut down language servers when quitting the app
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2021-11-02 13:16:25 -06:00
Antonio Scandurra
cfef953537
Avoid error during deserialization if the result field isn't there
2021-11-02 14:58:00 +01:00
Antonio Scandurra
26c99b5c6b
Remove all windows before quitting
...
This gives all entities a chance of running `Drop::drop` which,
in turn, could cause them to spawn a critical task. For example,
we use this capability when a language server is dropped and we
need to asynchronously send a shutdown message.
2021-11-02 14:55:31 +01:00
Max Brunsfeld
79a9be0c30
Avoid circular model update when sending diagnostics operations
2021-11-01 17:14:22 -07:00
Max Brunsfeld
070173fce3
Add note in README about rustc bug on macOS monterey
2021-11-01 17:11:40 -07:00
Max Brunsfeld and Nathan Sobo
0a178d2d15
Replicate diagnostics to remote buffers
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-11-01 15:28:37 -07:00
Max Brunsfeld and Nathan Sobo
7270358c7c
Move protobuf logic from buffer crate to language crate
...
This will enable us to add operations that only pertain to the language crate.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-11-01 14:05:19 -07:00
Max Brunsfeld
26680e30cc
Use Diagnostic struct in buffer's diagnostics multimap
2021-11-01 12:59:01 -07:00
a217f62a7d
Delay quit until language servers are gracefully shut down
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-11-01 11:57:31 -07:00
Max Brunsfeld and Antonio Scandurra
9cc3433d20
Add a facility for delaying quit until critical tasks finish
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2021-11-01 11:57:31 -07:00
Antonio Scandurra
d941e129e7
Take a &clock::Global instead of cloning in edits_since
2021-11-01 10:48:20 +01:00
Antonio Scandurra
d9b96409b7
Try signing rust-analyzer in order to embed it in the app bundle
2021-11-01 10:30:10 +01:00
Antonio Scandurra
e7d5a2af4e
Always notify when receiving buffer operations
...
We had changed it to only emit a notification when the buffer was
actually edited, but we also want to notify when we receive non-edit
operations, such as a selection update.
2021-11-01 10:06:23 +01:00
Nathan Sobo
65a4ad6cfb
Fix test-support feature propagation for editor and workspace
2021-10-30 07:40:20 -06:00
Antonio Scandurra and Nathan Sobo
fda08984da
Extend empty diagnostic ranges by one character
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-29 19:09:19 +02:00
Antonio Scandurra and Nathan Sobo
8a5bee616d
Communicate with language servers in terms of UTF-16 coordinates
...
This required indexing UTF-16 positions in `Rope`. We tried opting
into the UTF-8 experimental support but it didn't seem to work
correctly and the standard is UTF-16 anyway.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2021-10-29 18:33:23 +02:00
Antonio Scandurra
701b86f493
Avoid unnecessary conversion to offsets in diagnostics_in_range
2021-10-29 14:41:41 +02:00
Antonio Scandurra
05b753d39e
Support only UTF-8 for now when communicating with language server
2021-10-29 12:02:42 +02:00
Antonio Scandurra
7da4c3df27
Bundle fat-binary for rust-analyzer
2021-10-29 11:41:07 +02:00
Max Brunsfeld
17a3ba191f
Avoid panic when rust language isn't present (project unit tests)
2021-10-28 17:12:17 -07:00
Max Brunsfeld
825fb94fc6
Merge branch 'anchor-map-selections' into lsp
2021-10-28 17:08:06 -07:00
Max Brunsfeld
000f356a2e
Merge pull request #216 from zed-industries/anchor-map-selections
...
Represent selection sets as anchor range maps
2021-10-28 17:07:45 -07:00
Max Brunsfeld
b8ddf94557
🎨 anchor.rs
2021-10-28 16:48:07 -07:00
Max Brunsfeld
6fe4ed1c66
Ignore vendor/bin folder
2021-10-28 16:32:56 -07:00
Max Brunsfeld
5cb767e73b
Rename AnchorRangeSet::to_point_ranges -> point_ranges
2021-10-28 16:32:49 -07:00
Max Brunsfeld
769ad74a3d
Fix unit test for on-disk-changes to not rely on selection bias
2021-10-28 16:17:07 -07:00
Max Brunsfeld
9af0d07f23
Create valid disjoint selection sets in selections_in_ranges
2021-10-28 16:04:16 -07:00
Max Brunsfeld
d0c6a52c81
Get the Editor crate compiling
2021-10-28 15:42:24 -07:00
Antonio Scandurra and Max Brunsfeld
4fdefb4cb3
Start fixing compilation errors on Editor
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-10-28 19:36:43 +02:00
Antonio Scandurra and Max Brunsfeld
6279e74712
Clip points coming from language server
...
This avoids panicking in Zed if the points they give us are invalid.
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-10-28 19:02:26 +02:00
Antonio Scandurra and Max Brunsfeld
204f8f3367
Ensure start endpoints always come before end endpoints
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2021-10-28 18:26:32 +02:00
Antonio Scandurra
811a88f22c
Remove stray println! statements in the LSP I/O code
2021-10-28 14:07:14 +02:00
Antonio Scandurra
35aff64b6b
Express multi-cursor edits using the new coordinate space
...
The language server expects that ranges further in the list of edits
account for the impact of prior changes in the edit list.
2021-10-28 13:40:55 +02:00
Antonio Scandurra
ff236917c4
Add a unit test for disk-based diagnostics
2021-10-28 11:37:24 +02:00
Antonio Scandurra
daf928dedf
Sort LSP diagnostics by (start, end)
2021-10-28 11:36:33 +02:00
Max Brunsfeld