Max Brunsfeld
0098706f6e
Fix leak when project is unshared while LSP handler waits for edits
2023-04-10 17:03:58 -07:00
Nathan Sobo
bda9f27f31
WIP
2023-04-10 17:27:47 -06:00
Max Brunsfeld
7b7d568b1b
Upgrade postage for oneshot channel drop fix
...
Previously, dropping a oneshot sender didn't wake the receiver.
2023-04-10 16:03:49 -07:00
Nathan Sobo
596940d986
WIP: Everything shredded
2023-04-10 16:10:32 -06:00
Julia
4cd0146239
Merge pull request #2367 from zed-industries/log-github-api-response-for-deserialize-error
...
In the case of Github release deserialize error, log response text
2023-04-10 17:04:59 -04:00
Julia and Joseph Lyons
0f70199dae
In the case of Github release deserialize error, log response text
...
Co-Authored-By: Joseph Lyons <joseph@zed.dev >
2023-04-10 16:45:15 -04:00
Max Brunsfeld and Antonio Scandurra
eeeb30f56c
Preserve ordering between UpdateProject and CreateBufferForPeer messages
...
Previously, because UpdateProject messages were sent in a separately-
spawned task, they could be sent after CreateBufferForPeer messages that
were intended to be sent after them.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-10 12:54:25 -07:00
Antonio Scandurra
92d388bbbf
Avoid broadcasting SaveBuffer in response to a client's save request
...
The host will send a `SaveBuffer` message anyway and this prevents re-querying
the database, which could cause two `BufferSaved` messages to race and, as a
result, cause guest to apply them in the wrong order.
2023-04-10 10:02:13 +02:00
Antonio Scandurra
1e30e21ed2
Improve assertion message when buffer state diverges
2023-04-10 10:01:44 +02:00
Antonio Scandurra
cac9fde432
Merge branch 'main' into randomized-tests-operation-script
2023-04-10 08:45:22 +02:00
Antonio Scandurra
1f033488b1
Apply BufferReloaded message to incomplete remote buffers
2023-04-10 08:41:31 +02:00
Antonio Scandurra
7dc656cfb2
Merge pull request #2366 from zed-industries/avoid-unwrapping-on-try-send
...
Don't panic if worktree was dropped before sending path changes
2023-04-10 08:36:53 +02:00
Antonio Scandurra
c3c3416c1f
Don't panic if worktree was dropped before sending path changes
...
In `refresh_entry`, we send a message to the `self.path_changes_tx` channel
to notify the background thread that a path has changed. However, given that
`refresh_entry` uses `spawn_weak`, the worktree could get dropped before sending
the message, which could cause a panic.
This commit changes the code to return an error instead of panicking.
2023-04-10 08:16:08 +02:00
Nathan Sobo
722f47dcd1
WIP
2023-04-08 08:01:05 -06:00
Nathan Sobo
075a661b74
WIP
2023-04-08 06:43:39 -06:00
Max Brunsfeld and Antonio Scandurra
dfe146d24e
Halt UpdateBuffer messages until sync if one errors
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-07 17:31:52 -07:00
Max Brunsfeld
4d7e7b58e4
Wait for host to acknowledge buffer updates before sending them to other guests
2023-04-07 16:27:48 -07:00
Max Brunsfeld and Antonio Scandurra
7099548fd0
Fixed removal of closed projects in randomized test
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-07 12:24:59 -07:00
Joseph Lyons
6a06051a90
Put file location details of panic on separate line
2023-04-07 14:32:14 -04:00
Nathan Sobo
63c9c712eb
Merge pull request #2365 from zed-industries/dont_export_gpui_platform_module
...
Don't export platform::* from gpui
2023-04-07 12:12:05 -06:00
Nathan Sobo
5e79ca0625
Merge AppContext impl blocks
2023-04-07 11:54:08 -06:00
Nathan Sobo
45c1106140
Don't export platform::* from gpui
...
I'd like to avoid cluttering the top-level namespace with all the platform-
specific types.
2023-04-07 11:45:53 -06:00
Joseph T. Lyons
cd9842186e
Merge pull request #2364 from zed-industries/put-backtrace-on-a-newline-when-reporting-panics
...
Put backtrace on a new line when reporting panics
2023-04-07 12:46:53 -04:00
Joseph Lyons
d18e8b8f72
Put backtrace on a new line when reporting panics
2023-04-07 12:12:18 -04:00
Joseph T. Lyons
0713ecedb3
Merge pull request #2363 from zed-industries/add-copy-path-commands
...
Update copy path commands
2023-04-07 12:09:39 -04:00
Joseph Lyons
6614f8f635
Update copy path commands
2023-04-07 02:36:56 -04:00
Nathan Sobo
8b75de7087
Merge pull request #2362 from zed-industries/eliminate-mutable-app-context
...
Merge MutableAppContext into AppContext
2023-04-06 16:19:47 -06:00
Nathan Sobo
f9dfc9ad08
Fix broken test due to trimmed trailing whitespace during formatting
2023-04-06 16:10:39 -06:00
Nathan Sobo
5839c594d8
Fix formatting
2023-04-06 15:54:44 -06:00
Nathan Sobo
d937660683
Merge MutableAppContext into AppContext
...
There may have been a good reason for the difference at some point, or I was
still learning Rust. But now it's just &mut AppContext vs &AppContext.
2023-04-06 15:49:03 -06:00
Max Brunsfeld and Antonio Scandurra
1a000f51db
Fix handling of redundant buffer creation messages on guests
...
Check if the buffer already exists *before* overwriting it.
Ignore redundant registrations on remote projects.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-06 12:17:25 -07:00
Max Brunsfeld and Antonio Scandurra
ff1fcef1ef
Move project assertions into main assertion function
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-06 11:38:42 -07:00
Joseph T. Lyons
2e4efaded7
Merge pull request #2361 from zed-industries/add-close-items-to-left-and-right
...
Add close items to left and right
2023-04-06 13:06:25 -04:00
Antonio Scandurra
e74efb996c
Update file on incomplete buffer instead of waiting for it to be opened
...
This ensures that two successive file updates coming from the host are
not applied in reverse order.
2023-04-06 17:48:44 +02:00
Julia
36d3fc846a
Merge pull request #2304 from zed-industries/bump-diff-width
...
Increase git diff gutter width slightly
2023-04-06 10:58:55 -04:00
Antonio Scandurra
37e3b58b32
Wait to see guest's buffer version before converting completion anchor
2023-04-06 16:23:10 +02:00
Antonio Scandurra
c7045751da
Save server operations that were in the middle of being applied
...
Previously, if the test panicked before it had a chance to fully
apply an operation, it would end up not being saved in the plan.
With this commit we will mark the operation as applied before we
start processing it, and mark it as not applied if, once we're done,
we've found out that it couldn't be applied. This is consistent with
what we do for client operations.
2023-04-06 16:02:16 +02:00
Antonio Scandurra
d2d37988c6
Return error if subscribing to an entity that was already subscribed to
2023-04-06 14:42:19 +02:00
Antonio Scandurra
57400dbb98
Forget which buffers were shared when host reconnects
...
This fixes a bug where the host would momentarily disconnect and the guest
would close and reopen the project. This would cause the host to not observe
the guest closing the project. When the guest tried to open one of the
buffers opened prior to closing the project, the host would not send them the
buffer state because it would still remember that the buffer was shared.
The `shared_buffers` map is now cleared when the host reconnects and will slowly
get re-filled as guests issue `SynchronizeBuffers` requests.
2023-04-06 13:49:09 +02:00
Joseph Lyons
1941ac77fa
Add close items to left and right
2023-04-06 03:33:38 -04:00
Max Brunsfeld
e5c7920c2c
Avoid async fs call before checking if operation is applicable
...
This way, the executor isn't influenced by operations that aren't applicable.
2023-04-05 18:11:33 -07:00
Max Brunsfeld
f8703ec7fa
Don't use TestPlan's rng in fake LSP handlers
...
These should use the test context's rng, so that they behave the same whether
a pre-recorded plan was used, or the plan is being generated.
2023-04-05 17:50:04 -07:00
Max Brunsfeld
3a2d13541f
Merge branch 'main' into randomized-tests-operation-script
2023-04-05 17:10:20 -07:00
Nathan Sobo
975d9e70fd
Fix typos in EULA
2023-04-05 18:02:35 -06:00
Max Brunsfeld
d8119330cf
Clear guest's shared buffers if they rejoin project after leaving while host was disconnected
2023-04-05 16:53:36 -07:00
Max Brunsfeld
c75eac29ee
Do include operations in serialized test plan if they cause a client to hang
2023-04-05 16:52:39 -07:00
Max Brunsfeld
79b21904d6
Don't skip worktree updates if unknown entries are removed
...
When rejoining a project, if entries were both created and deleted since
joining the project, the guest will receive those entries ids in as
removed.
2023-04-05 15:36:01 -07:00
Max Brunsfeld
bcd32df76f
Run executor until parked at end of each iteration of random collaboration test
...
Without this, the server doesn't get dropped at the end of the test, and we eventually run
out of file handles due to sqlite connections being retained.
2023-04-05 15:05:32 -07:00
Max Brunsfeld
77fc597450
Omit operations for non-existent users from serialized test plan
2023-04-05 15:04:27 -07:00
Julia
0f6c7f7292
Merge pull request #2360 from zed-industries/maybe-fix-lock-screen-crash
...
Hesitant possible fix for lock screen crash
2023-04-05 14:10:40 -04:00
Max Brunsfeld