Julia and Max Brunsfeld
c094ca7b0d
Add top level leave call button
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 14:44:23 -05:00
Julia and Max Brunsfeld
31a31fb3fa
Fiddle with titlebar item spacing
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 14:13:29 -05:00
Julia and Max Brunsfeld
3d85c51976
Only show in-call share/unshare button if own project
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 13:40:43 -05:00
Julia and Max Brunsfeld
57185f02fb
Add style leader selection container
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 13:36:06 -05:00
Petros Amoiridis and Julia
a098593d23
Add an icon to the terminal view tab
...
The terminal icon already existed in `assets/icons`
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-22 20:30:44 +02:00
Petros Amoiridis and Julia
f6561f0cb7
Deduplicate tab theme related code
...
We've noticed that the search theme struct had two fields for a tab icon width and spacing. But we already have those in the tab theme struct. We decided to remove the duplicate and reuse the tab fields.
We also wanted to move where the spacing is being used. Instead of doing it at the left of the label, we do it at the right of the icon to match how it is done in other areas of the UI.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-22 20:28:57 +02:00
Petros Amoiridis and Julia
6456971bca
Make icon width match other areas
...
This was 8 but we've seen areas where this was 14, like the project search tab icon. We want to match this.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-22 20:25:39 +02:00
Mikayla Maki
d46f091080
Merge pull request #2201 from zed-industries/save-shortcuts
...
Add OS UI Keybindings
2023-02-22 09:16:19 -08:00
Mikayla Maki
36bf325979
Merge pull request #2198 from zed-industries/more-item-defaults
...
Add more default impls to the item trait
2023-02-22 09:14:12 -08:00
Mikayla Maki and Antonio
bed59e03f4
Fixed keyboard shortcuts in mac os native panels
...
co-authored-by: Antonio <antonio@zed.dev >
2023-02-22 09:10:16 -08:00
Mikayla Maki and Antonio
40872c8bd4
Introduce an OSAction that can be associated with menu items for mac platform compatibility.
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-02-22 09:02:31 -08:00
Julia and Max Brunsfeld
2d1da9e310
Add mockup accurate avatar background
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:34:55 -05:00
Julia and Max Brunsfeld
b7120c3e83
Initial dedicated face pile element
...
Rather than overload Flex with yet another special case, add a dedicated
element to handle this overlap instead
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
b9935a7208
Remove Flex::with_reversed_pain_order
2023-02-22 11:34:55 -05:00
Max Brunsfeld
d860521e5a
Start work on styling of follower avatars in facepiles
...
* Make follower avatars smaller than top-level avatars
* Make avatars in facepiles overlap
* Render an opaque background behind avatars in facepiles.
2023-02-22 11:34:55 -05:00
Max Brunsfeld
9032b8297a
Retrieve room id from the project when following/unfollowing
...
Previously, we were accidentally using the project id as the room id.
2023-02-22 11:34:55 -05:00
Julia and Max Brunsfeld
0781cd8112
Remove left side collaborator list
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:34:55 -05:00
Julia and Nathan Sobo
f509f4c2a7
Close contacts popover when call ends
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
19e3a864c5
Make tooltip lie less
2023-02-22 11:34:55 -05:00
Julia and Nathan Sobo
fb047a226d
Avoid moving contacts popover during call start & add button style state
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
3c7ff46f50
Initial adding of contact menu to call-less share button
2023-02-22 11:22:37 -05:00
Julia and Antonio Scandurra
84e1237d45
Add followers table to sqlite scheme for tests
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-22 11:22:37 -05:00
Julia
221d80a608
Shuffle share/unshare button back to the right side
2023-02-22 11:22:37 -05:00
Julia
8946fbd17d
Highlight face pile which local user is following
2023-02-22 11:22:37 -05:00
Julia
21bb7d85a6
Handle case where follower is local user
2023-02-22 11:22:37 -05:00
Julia
7795dc84e9
Add username to right side
2023-02-22 11:22:37 -05:00
Julia
90255cce45
Make things a bit more infallible
2023-02-22 11:22:37 -05:00
Julia
fa56590cd7
Following face piles finally take their first breath
2023-02-22 11:21:23 -05:00
Julia and Max Brunsfeld
62ea8909c1
Fix deadlock in db get_room
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:21:23 -05:00
Julia
988f9c1266
Abuse a closure instead of abusing options/iterators quite so much
2023-02-22 11:21:23 -05:00
Julia
3d9742d272
Absolute pain of the iterator kind (start laying out a user's followers)
2023-02-22 11:21:23 -05:00
Julia
bd88f47816
Initial tracking of unfollows on collab server
2023-02-22 11:21:23 -05:00
Julia and Antonio Scandurra
a3d474af23
Begin tracking follow states on collab server
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-22 11:21:23 -05:00
Julia and Petros Amoiridis
11c724d5fe
Add Flex with_reversed_paint_order & initially move face piles to left
...
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-02-22 11:21:23 -05:00
Julia and Petros Amoiridis
6fb45a7366
Start fleshing out layout of collaborator list entries
...
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-02-22 11:21:23 -05:00
Julia and Petros Amoiridis
fe1c6df418
Tell project when it has been unshared
...
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-02-22 11:21:23 -05:00
Julia
3bca2fdae9
Add collaborators to collaborator list, including self user
2023-02-22 11:21:23 -05:00
Julia
ea3bb46d2b
Add collaborator count to collaborator list button
2023-02-22 11:21:23 -05:00
Julia
944c6fba5f
Switch collaborator list to using own style
2023-02-22 11:21:23 -05:00
Julia and Antonio Scandurra
084677795d
Begin adding collaborator list popover
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-22 11:21:23 -05:00
Julia
e13d10cdb5
Move share button and support unsharing
2023-02-22 11:21:23 -05:00
Julia
9cc7d74f69
Move workspace title into collaboration titlebar item render
2023-02-22 11:21:11 -05:00
Antonio Scandurra
ea07c26aac
Hold room lock through the entirety of a room_transaction
...
Previously, when the host repeatedly sent `UpdateWorktree` messages,
new guests attempting to join a project would observe a severe slowdown
caused by a database serialization error (e.g., the coherence of the data
would get violated midway through `Database::join_project` due to worktree
entries being mutated as the user joined). Writing entries is pretty fast,
whereas reading all of them for a project can take more than 100ms.
Transactions that failed due to a serialization error are retried, but the guest
would keep retrying until the host finished writing because the guest's read
was slow.
This commit changes the semantics of `room_transaction` to acquire a room
lock before even starting the transaction and holding it all the way after
commit (storing it, as before, in the `RoomGuard`). This ensures that a fast
writer (the host) can't starve a slow reader (the guest), allowing the latter
to make progress by temporarily pausing writes by the former.
2023-02-22 16:04:29 +01:00
Kay Simmons
effca56eb4
Merge pull request #2189 from zed-industries/labeled-tasks
...
Labeled Tasks
2023-02-21 21:31:47 -08:00
Kay Simmons
561b5abc6f
fix test warning
2023-02-21 21:13:03 -08:00
Kay Simmons
8ae4613d87
Fix formatting
2023-02-21 21:07:45 -08:00
Mikayla Maki
6f6d374f7c
Remove now-default stubs
2023-02-21 17:51:49 -08:00
Mikayla Maki
7d62089491
Add more default impls to the item trait
...
Change pane to not split if the underlying item cannot be cloned
2023-02-21 17:29:39 -08:00
Mikayla Maki
5ecc0017b9
Merge pull request #2197 from zed-industries/label-text-cow
...
Changed label and text to be generic over static and owned strings
2023-02-21 17:05:57 -08:00
Mikayla Maki
6aec385c3f
Changed label and text to be generic over static strings and owned strings
2023-02-21 16:47:29 -08:00
