Commit Graph
298 Commits
Author SHA1 Message Date
Max Brunsfeld ef83a44d32 Remove logic for multiple channel parents (#3162)
This PR simplifies our state management for channels, and logic for
inheriting channel permissions, by removing the ability for channels to
have multiple parent channels.
2023-10-25 15:57:55 +02:00
Max Brunsfeld 7f767a024c Set up UI to allow dragging a channel to the root 2023-10-25 15:39:02 +02:00
Conrad Irwin 837755b5c7 Fix panic by disallowing multiple room joins (#3149)
Release Notes:

- Fixed panic that could occur when switching channels quickly
2023-10-24 23:57:08 +02:00
Conrad Irwin 38a00ade0f Fix extra race 2023-10-24 18:54:55 +02:00
e3864cb084 Remove logic for multiple channel parents
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Kyle <kyle@zed.dev>
Co-authored-by: Joseph <joseph@zed.dev>
2023-10-24 17:29:23 +02:00
Max Brunsfeld dd85f6448f Guest roles (#3140)
Release Notes:

- Added a "guest" role to channels, and made that the default when a new
user joins a public channel.
2023-10-24 17:29:14 +02:00
Kirill Bulatov ab12b3c6e1 Rework prettier tests
Do not infuse `FakeNodeRuntime` with prettier exceptions, rather keep
the default formatter installation method as no-op.
2023-10-24 14:25:46 +02:00
Conrad Irwin 4d7cc2649e fix format 2023-10-24 11:17:17 +02:00
Conrad Irwin 14590458c3 Fix set_channel_visibility for public channels 2023-10-24 10:55:10 +02:00
Conrad Irwin ff1894c6c4 Fix tests 2023-10-24 09:46:46 +02:00
Conrad Irwin 416c049767 Merge branch 'main' into guest-exp 2023-10-23 17:47:21 +02:00
Max Brunsfeld 5d1e917401 Merge branch 'main' into notifications 2023-10-22 12:25:30 +02:00
Mikayla 9c48d81c01 Finish room initialization concurrency test 2023-10-21 03:15:18 -07:00
Mikayla a798fd4a32 WIP: Add test for panic, temporarily rollback synchronization changes 2023-10-21 03:05:57 -07:00
Kirill Bulatov fb3932aa57 Move prettier parsers data into languages from LSP adapters 2023-10-21 01:14:03 +02:00
Conrad Irwin de6e3d8e10 Fix notifications for membership changes too 2023-10-19 23:05:06 -06:00
Max Brunsfeld e7f43c9e6b Navigate to chat messages when clicking them in the notification panel 2023-10-19 12:31:45 -07:00
Conrad Irwin db582b776b Add read-only channel notes support
Fix some bugs where ChannelNotes and ChannelChat had old cached channel
instances
2023-10-19 13:20:49 -06:00
Max BrunsfeldandPiotr 9449d46b70 Create notifications for mentioned users
Co-authored-by: Piotr <piotr@zed.dev>
2023-10-19 10:52:40 -07:00
Conrad Irwin 331d334bae Refactor to avoid some (mostly hypothetical) races
Tidy up added code to reduce duplicity of X and X_internals.
2023-10-18 21:42:10 -06:00
Max Brunsfeld 256ef99284 Merge branch 'main' into notifications 2023-10-18 17:20:04 -07:00
Max Brunsfeld d286c4441d Persist chat mentions 2023-10-18 16:56:03 -07:00
Conrad Irwin 8d9c9c16d4 Fix notifications on channel changes 2023-10-18 15:56:33 -06:00
Mikayla 77da29e4a9 Restrict DAG-related functionality, but retain infrastructure for implementing symlinks 2023-10-18 05:28:05 -07:00
Conrad Irwin 4d5b7e32a1 Sync Role as part of channels
Begin to fix guest notifications
2023-10-17 22:48:44 -06:00
Max Brunsfeld a42661780e Fix more issues with the channels panel
* Put the newest notifications at the top
* Have at most 1 notification toast, which is non-interactive,
  but focuses the notification panel on click, and auto-dismisses
  on a timer.
2023-10-17 15:43:06 -07:00
Max Brunsfeld 9ed0e5fdd9 Add notifications integration test 2023-10-17 11:21:38 -07:00
Max Brunsfeld f8e8340b84 Display invite response buttons inline in notification panel 2023-10-17 09:12:55 -07:00
Conrad Irwin 9029a2807b Merge branch 'main' into guests 2023-10-17 09:54:17 -06:00
Conrad Irwin 74ffac5519 Ensure that invitees do not have permissions
They have to accept the invite, (which joining the channel will do),
first.
2023-10-16 16:24:10 -06:00
Conrad Irwin 2899a628c7 Make joining a channel as a guest always succeed 2023-10-16 15:14:13 -06:00
Conrad Irwin a4e960f73a Wire through public access toggle 2023-10-13 16:59:30 -06:00
Max Brunsfeld fb4b3bb4c1 Connect notification panel to notification toasts 2023-10-13 11:21:45 -07:00
Conrad Irwin ca7a6064a8 Add check_is_channel_participant
Refactor permission checks to load ancestor permissions into memory
for all checks to make the different logics more explicit.
2023-10-12 19:59:50 -06:00
Max Brunsfeld 2eb3c45b7f Set up notification store for integration tests 2023-10-12 17:42:30 -07:00
Conrad Irwin 03dd4b5be8 Push role refactoring through RPC/client 2023-10-12 13:05:54 -06:00
Kirill Bulatov 222bb37da6 Add more tests 2023-10-12 15:14:51 +03:00
Conrad Irwin 6734472b64 Add a role column to the database and start using it
We cannot yet stop using `admin` because stable will continue writing
it.
2023-10-11 20:05:57 -06:00
Kirill Bulatov ca0c508c1d Rebase fixes 2023-10-11 12:56:29 +03:00
Kirill Bulatov a7f42aa29e Slightly better prettier settings and discovery 2023-10-11 12:56:29 +03:00
6912545774 Update channel rooms to be ephemeral
Remove redundant live kit initialization code
Fix bug in recent channel links changes where channel rooms would have the incorrect release set

co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
co-authored-by: Max <max@zed.dev>
2023-10-10 12:39:16 -07:00
Max Brunsfeld a41791a817 Add failing test for switching leaders in a pane 2023-10-09 13:30:14 -07:00
Max Brunsfeld a829cd1f89 Remove workspace -> channel dependency 2023-10-06 14:19:25 -07:00
Max Brunsfeld d480074555 Fix bugs in handling mutual following
* Propagate all of leader's views to a new follower, even if those views
  were originally created by that follower.
* Propagate active view changes to followers, even if the active view is
  following that follower.
* Avoid redundant active view updates on the client.
2023-10-05 13:28:46 -07:00
Mikaylaandmax 2417284d20 Add an RPC handler for channel buffer acks
co-authored-by: max <max@zed.dev>
2023-10-04 11:47:13 -07:00
Mikayla 2f82357b29 Fix channel messages test 2023-10-04 10:13:02 -07:00
Mikayla 6f21c99e95 Fix most tests for new chat changes 2023-10-03 20:50:17 -07:00
MikaylaandConrad f4dbf3dc0f Fix unit test
co-authored-by: Conrad <conrad.irwin@gmail.com>
2023-10-03 20:03:57 -07:00
Max Brunsfeld 6f6460a858 Merge branch 'main' into channel-changes 2023-10-03 17:52:28 -07:00
Max BrunsfeldandMikayla d2ca5522f5 Acknowledge channel notes and chat changes when views are active
Co-authored-by: Mikayla <mikayla@zed.dev>
2023-10-03 17:40:10 -07:00