Marshall Bowers
8602fa9ece
Update tenses of doc comment summary lines ( #4161 )
...
This PR updates the tenses used by the summary line of doc comments to
match the [Rust API documentation
conventions](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#summary-sentence ).
Specifically:
> The summary line should be written in third person singular present
indicative form. Basically, this means write ‘Returns’ instead of
‘Return’.
I'm sure there are plenty occurrences that I missed.
Release Notes:
- N/A
2024-01-19 11:18:50 -05:00
Joseph Lyons
4b5a7ec94a
Fix typos
2023-06-02 22:02:19 -04:00
ForLoveOfCats and Mikayla
fbea44bc5c
One big cleanup pass of clippy lints
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2022-08-10 16:51:01 -07:00
Isaac Clayton
6a89b79af3
Remove epoch-based metering
2022-07-13 18:03:14 +02:00
Isaac Clayton
fb1771df01
Use enum to differentiate between normal and precompiled plugins
2022-07-13 14:26:52 +02:00
Isaac Clayton
aac58b068a
Fix failing test
2022-07-13 13:27:31 +02:00
Isaac Clayton
6b85ab5678
Quick documentation fix
2022-07-13 13:21:45 +02:00
Isaac Clayton
4f014ff44b
Rename a few items and add documentation
2022-07-13 13:19:51 +02:00
Isaac Clayton
3b5407a26f
Fix resulting errors and introduce functional executor callback
2022-07-13 13:15:12 +02:00
Isaac Clayton
f0d59ff3cc
Work on supporting both epoch and fuel
2022-07-13 12:41:47 +02:00
Isaac Clayton
fcfa2d48dd
Add support for configuring plugin yield mechanism, stashing
2022-07-13 11:57:00 +02:00
Isaac Clayton
134548e878
Switch from epoch to fuel
2022-07-13 11:09:06 +02:00
Isaac Clayton
01598d6a6d
Implement periodic yielding using epoch_deadline_async_yield_and_update
2022-07-12 17:07:33 +02:00
Isaac Clayton
8d27d87f8a
Start working on plugin epoch async yield
2022-07-12 16:32:41 +02:00
Isaac Clayton
ea673aad1a
Add comment linking engine creating code together
2022-07-11 18:20:50 +02:00
Isaac Clayton
617068fe7c
Fix minor issues in plugin and project raised during review
2022-07-11 16:40:12 +02:00
Isaac Clayton
6a1f649d6a
Fix minor issues pointed out in the review
2022-07-11 15:54:03 +02:00
Isaac Clayton
b1bb61a83f
More cleanup during review
2022-07-11 10:56:21 +02:00
Isaac Clayton
bcac06aa90
Remove unused struct fields
2022-07-11 10:39:14 +02:00
Isaac Clayton
ce8898acf1
Remove debug statements
2022-07-08 21:28:35 +02:00
Isaac Clayton
88baf23f60
Add basic support for precompiling plugins
2022-07-07 16:21:27 +02:00
Isaac Clayton
0b85613a86
Done! Finish transition to async, very close to merging
2022-07-07 16:21:20 +02:00
Isaac Clayton
238690802d
More work on transitioning to async, need to figure out when to stop
2022-07-07 15:38:28 +02:00
Isaac Clayton
3eb0abeddd
Allow async to infect some more functions
2022-07-07 15:34:27 +02:00
Isaac Clayton
9658f732b8
Add timing instrumentation
2022-07-07 15:32:43 +02:00
Isaac Clayton
b74f90639c
Work on updating code to be async
2022-07-07 15:32:41 +02:00
Isaac Clayton
8ee48b2c0f
Isolate smol::Command hang as a test, does not hang
2022-07-07 15:23:27 +02:00
Isaac Clayton
5767287246
Switch from std::process::Command to smol::process::Command
2022-07-07 15:22:17 +02:00
Isaac Clayton
e75d068dae
Documentation pass
2022-07-07 15:22:17 +02:00
Isaac Clayton
1c9ccbcac2
Add async host functions
2022-07-07 15:22:17 +02:00
Isaac Clayton
680e899548
Rename WasiPlugin -> Plugin, etc.
2022-07-07 15:22:17 +02:00
Isaac Clayton
39e509e682
WIP: wrap async closures host-side
2022-07-07 15:22:17 +02:00
Isaac Clayton
6e902634c9
Add functions with multiple arguments to import macro, add test cases
2022-07-07 15:22:17 +02:00
Isaac Clayton
11a88ab324
Split out lifecycle of serialization, buffer is freed now
2022-07-07 15:22:17 +02:00
Isaac Clayton
0d42fb8d12
Add build.rs to rebuild plugins, and a test plugin
2022-07-07 15:22:17 +02:00
Isaac Clayton
1f352dd3ad
Change ABI from pair of u32s to single u64
2022-07-07 15:22:17 +02:00
Isaac Clayton
b4f1a3a80b
Factor out serialization code
2022-07-07 15:22:17 +02:00
Isaac Clayton
45743f6128
Add allocator to store so that it can be used by host functions
2022-07-07 15:22:17 +02:00
Isaac Clayton
420ceb4004
Remove dependency on self in call-related functions
2022-07-07 15:22:17 +02:00
Isaac Clayton
4765bed11d
Fix issue with host function binding
2022-07-07 15:22:17 +02:00
Isaac Clayton
efe725c503
Work on plugin builder
2022-07-07 15:22:17 +02:00
Isaac Clayton
27390f20e9
Start working on host-side functions
2022-07-07 15:22:17 +02:00
Isaac Clayton
56a6a81a24
Add JSON LSP plugin
2022-07-07 15:22:16 +02:00
Isaac Clayton
122157162a
Move Wasi to async, validate timeslicing, using async in traits still WIP
2022-07-07 15:20:27 +02:00
Isaac Clayton
a816d4916b
Factor out buffer code
2022-07-07 15:20:27 +02:00
Isaac Clayton
cb296f7cc6
Get JSON LSP running, still work to be done
2022-07-07 15:20:27 +02:00
Isaac Clayton
e08b18f3d6
Remove non-WASI code
2022-07-07 15:20:25 +02:00
Isaac Clayton
76c34281cc
Get Wasi working
2022-07-07 15:19:02 +02:00
Isaac Clayton
f3b8e93a8a
Start switching JSON LSP adapter to plugin (take 2)
2022-07-07 15:16:59 +02:00
Isaac Clayton
cf2d233a46
Clean up impl a bit
2022-07-07 15:11:51 +02:00