Thorsten Ball and Antonio
9e9e30376b
Log error if worktree fails to relativize git repo path
...
We saw a panic that was caused by the previous `Option.unwrap()`, so
this changes the method to return a `Result` and logs the error if
possible.
Co-authored-by: Antonio <antonio@zed.dev >
2024-01-25 11:10:00 +01:00
Conrad Irwin
701902bba8
Fix panic from unwrapping a relativize()
2024-01-24 20:56:39 -07:00
Max Brunsfeld
4b47059dbf
Simplify language server startup ( #6449 )
...
These are just some small refactorings of our language-server-starting
code, motivated by another change that I decided to bail on:
https://github.com/zed-industries/zed/pull/6448 .
2024-01-24 17:36:50 -08:00
Kirill Bulatov
bba898b70b
Fix LSP shenanigans when opening and/or editing settings files ( #4212 )
...
Fixes
* LSP servers never being shut down on worktree release
* worktrees (and LSP servers) being re-created for settings files on
every opening
Also,
* removes `async` from `workspace_configuration` to simplify the code:
we only return static configurations now
Release Notes:
- Fixed excessive LSP server creation for Zed settings files
2024-01-23 13:20:00 +02:00
Kirill Bulatov and Piotr
69aecab4c1
Create a special worktree for settings files
...
To avoid LSP server restarts/leaks when those are being opened
co-authored-by: Piotr <piotr@zed.dev >
2024-01-23 13:10:30 +02:00
Kirill Bulatov
42444558e9
Remove the async modifier from the workspace_configuration method
2024-01-23 11:58:17 +02:00
Thorsten Ball and Antonio
fb98103a91
Trim diagnostic messages to fix rendering bug
...
Before this change a diagnostic message with a trailing newline (e.g.
`line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`.
But the content we then display in this block had 3 "lines", which
pushed the content out of the block.
This fixes the issue by trimming the newlines at the end from the
diagnostics.
Co-authored-by: Antonio <antonio@zed.dev >
2024-01-23 10:36:06 +01:00
Kirill Bulatov
9623a9bf24
Clean up LSP servers on worktree release
2024-01-23 11:34:51 +02:00
Piotr Osiewicz
a8f1c15a1e
chore: Fix clippy::needless_borrow up to an editor
2024-01-21 15:03:24 +01:00
Max Brunsfeld and Conrad
49d9ad73bd
Move the details of completion-resolution logic into Project
...
Co-authored-by: Conrad <conrad@zed.dev >
2024-01-19 11:52:28 -08:00
Max Brunsfeld
f6903874f7
Start work on API docs for the language crate ( #3981 )
2024-01-19 10:04:45 -08:00
Marshall Bowers
8602fa9ece
Update tenses of doc comment summary lines ( #4161 )
...
This PR updates the tenses used by the summary line of doc comments to
match the [Rust API documentation
conventions](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#summary-sentence ).
Specifically:
> The summary line should be written in third person singular present
indicative form. Basically, this means write ‘Returns’ instead of
‘Return’.
I'm sure there are plenty occurrences that I missed.
Release Notes:
- N/A
2024-01-19 11:18:50 -05:00
Max Brunsfeld
037768f80d
Merge branch 'main' into language-api-docs
2024-01-18 15:06:45 -08:00
Mikayla
0b43bd7c14
Fix typos detected by crate-ci/typos
2024-01-17 14:31:21 -08:00
Max Brunsfeld and Antonio
7ea371a531
Add docs for buffer.rs
...
Co-authored-by: Antonio <antonio@zed.dev >
2024-01-17 10:08:42 -08:00
Mikayla
4a824521f3
remove more commented code
2024-01-12 20:10:40 -08:00
Conrad Irwin
60f7c45d35
Stop following when project is unshared
...
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.
2024-01-10 23:09:09 -07:00
Conrad Irwin
71ef720072
Allow adding write access to guests
2024-01-08 22:02:56 -07:00
Conrad Irwin
bcf30f19d6
Disallow creating files with '..' ( #3156 )
...
Release Notes:
- Fixed a crash that could occur when creating files with '..' in the
path
2024-01-08 15:43:57 -07:00
Conrad Irwin and Max
b8dbdb65f9
Fix relative path opening from project symbols
...
Co-Authored-By: Max <max@zed.dev >
2024-01-08 15:12:22 -07:00
Conrad Irwin
b62b45c6e5
No .. paths...
2024-01-08 13:46:08 -07:00
Piotr Osiewicz and Marshall Bowers
f90b05b716
Display setting documentation in settings.json ( #3936 )
...
Let this screenshot of settings.json speak for itself:
Release Notes:
- Added code completion & on-hover documentation to Zed's settings.json
file.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-01-08 19:30:18 +01:00
Conrad Irwin
455d60f20a
Merge branch 'main' into channel-guests
2024-01-05 10:05:59 -07:00
Conrad Irwin
2cf11423a3
Tidy up branch
2024-01-04 11:55:14 -07:00
Piotr Osiewicz
273ea228a9
lsp: Do not cache initialization options
2024-01-04 19:54:58 +01:00
Conrad Irwin
4260ed27f6
Track read_only per project and buffer
...
This uses a new enum to avoid confusing booleans
2024-01-03 19:31:43 -07:00
Conrad Irwin
fcdf0e8028
Track room participant role
...
(Also wire that through to project collaboration rules for now)
2024-01-03 19:30:32 -07:00
Conrad Irwin
5f8ac7c29b
Plumbing to pass role for room participants
2024-01-03 19:30:32 -07:00
4ed92d64b7
Start work on read-only project access for channel guests
...
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Mikayla <mikayla@zed.dev >
2024-01-03 19:30:32 -07:00
Max Brunsfeld and Mikayla
cdafb2d039
Remove 2 suffix for project
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2024-01-03 11:53:34 -08:00
Kirill Bulatov
b7fab01c6e
Do not panic on non-worktree file indexing
2023-12-18 13:10:26 +02:00
Kirill Bulatov
ab027aa72e
Rework the way project panel auto reveals entries
...
* gitignored entries are never auto revealed
* `project_panel::auto_reveal_entries = true` settings entry was added,
setting it to `false` will disable the auto reveal
* `pane::RevealInProjectPanel` action was added that activates the project panel and reveals the entry it got triggered on (including the gitignored ones)
2023-12-12 11:38:51 +02:00
Kirill Bulatov
cea3a29d19
Port to gpui1
2023-12-11 12:28:22 +02:00
Kirill Bulatov
5242f8031e
Port to gpui2
2023-12-05 16:13:39 +02:00
Kirill Bulatov
3c3c792750
Fix the test
2023-12-05 12:45:44 +02:00
Kirill Bulatov
51f29faaf3
Add project search in gitignored test
2023-12-05 12:45:44 +02:00
Kirill Bulatov
58264d9c3e
Integration tests for excluded files
2023-12-05 12:45:44 +02:00
Kirill Bulatov
0a150c44f2
Fix the regex matcher
2023-12-05 12:45:36 +02:00
Kirill Bulatov
057bf4e440
Ignore excluded files on worktree entry refresh
2023-12-05 12:30:29 +02:00
Kirill Bulatov
7fd7fdeef6
Allow opening buffers without a project entry
2023-12-05 12:30:29 +02:00
Kirill Bulatov
03361b4a58
Log project path that was no open due to no project entry found
2023-12-04 12:45:57 +02:00
Kirill Bulatov
cd5018d9cf
Exclude gitignored files' diagnostics from project panel and its indicator.
...
The diagnostics are collected and available still, since that might become a settings/UI toggle later.
Also, buffer diagnostics are still updated for gitignored files.
2023-11-30 15:46:30 +02:00
Kirill Bulatov
cc6109383d
Fix eslint diagnostics by passing worktree root during workspace init
2023-11-30 11:38:16 +02:00
Kirill Bulatov
5de10092a8
Log prettier installation start & success
2023-11-29 13:44:19 +02:00
Kirill Bulatov
9dd5a5a249
Fix the tests
2023-11-29 12:10:41 +02:00
Kirill Bulatov
c48e72db4c
Style fixes
2023-11-29 11:33:29 +02:00
Kirill Bulatov
5fe4027db7
Simplify default prettier installation function
2023-11-29 10:58:22 +02:00
Kirill Bulatov
33d9b2de06
Clear failed installation task when error threshold gets exceeded
2023-11-29 10:58:22 +02:00
Kirill Bulatov
89224f18dd
Properly determine default prettier plugins to install
2023-11-29 10:58:22 +02:00
Kirill Bulatov
92ef346b08
Properly increment installation attempts
2023-11-29 10:58:22 +02:00
