Joseph T. Lyons
aab0bdebc1
Use bitflags to hold error states
2023-12-14 17:22:13 -05:00
Joseph T. Lyons
bb32f705a4
Prep feedback code for testing
2023-12-14 13:22:41 -05:00
Joseph T. Lyons
44a3fd0cc7
Avoid unnecessary match
2023-12-13 21:43:21 -05:00
Joseph T. Lyons
a9573de153
Highlight email address field as red when invalid
2023-12-13 21:39:31 -05:00
Joseph T. Lyons
80473a44b8
Remove completed TODOs
2023-12-13 21:35:30 -05:00
Joseph T. Lyons
01f4d7bcef
Use an enum to represent modal states and simplify logic
2023-12-13 21:20:09 -05:00
Joseph T. Lyons
fb22f04409
Add Duration dependency
2023-12-13 21:19:36 -05:00
Joseph T. Lyons
9d9205ca8d
Use existing convention to silence warnings
2023-12-13 21:19:12 -05:00
Joseph T. Lyons
70fbe2b02c
Simulate sending feedback in dev
2023-12-13 21:18:50 -05:00
Joseph T. Lyons
9659a57292
Fix variable name
2023-12-13 17:31:51 -05:00
Joseph T. Lyons
e9cdc16b4c
Remove TODO
...
Thanks @ConradIrwin
2023-12-13 17:09:26 -05:00
Conrad Irwin
ab430c6442
fix modal exchange ( #3620 )
...
- Fix opening GoToLine from Command
- Extend test to cover go_to_line behavior too
Release Notes:
- N/A
2023-12-12 21:30:34 -07:00
Conrad Irwin
6bf18efa4e
Fix opening GoToLine from Command
...
This was broken because of the async hop introduced by should_dismiss.
Change that API to instead be syncronous, and require that implementors
(of which there is only one) to call dismiss again if they want to.
2023-12-12 20:46:27 -07:00
Joseph T. Lyons
1418732354
Use release channel display name for feedback
2023-12-12 17:29:37 -05:00
Joseph T. Lyons
7d11a521fd
Fix placeholder text
2023-12-12 16:56:43 -05:00
Joseph T. Lyons
d4e62e761e
Fix rustfmt in feedback_modal.rs
2023-12-11 13:56:58 -05:00
Joseph T. Lyons
3affeca0f4
Add code for submission and error states for feedback modal ( #3572 )
...
Release Notes:
- N/A
2023-12-10 20:49:14 -05:00
Conrad Irwin
9befa3f9ca
Restore namespace parameter to actions!
...
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
2023-12-09 15:18:31 -07:00
Joseph T. Lyons
bb6b3de164
Show negative numbers after limit is hit
2023-12-09 00:35:19 -05:00
Joseph T. Lyons
99bebd8409
Add code for submission and error states
2023-12-08 19:16:03 -05:00
Joseph T. Lyons
e6e02ab20f
Fix bug where feedback dismissal prompt is shown twice
2023-12-08 17:21:14 -05:00
Joseph T. Lyons
1b0d6aee33
Move all dismissal logic into dismiss_event
2023-12-08 16:14:45 -05:00
Joseph T. Lyons and Mikayla Maki
e418d69bc8
Allow modals to override their dismissal
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-12-08 15:29:44 -05:00
Joseph T. Lyons
8a1f4a144c
Remove some unused imports
2023-12-08 13:13:40 -05:00
Joseph T. Lyons
d25c8f52d7
Move character counter up above editor in feedback modal
2023-12-08 13:07:16 -05:00
Joseph T. Lyons
4adfbd72c2
Use consistent text
2023-12-08 11:39:10 -05:00
Joseph T. Lyons
da6e0fb9ea
Fix compiler error
2023-12-08 11:35:49 -05:00
Joseph T. Lyons
757b742f53
Fix rustfmt
2023-12-08 11:33:18 -05:00
Joseph T. Lyons
6f61ea3cb4
Add TODO
2023-12-07 22:24:32 -05:00
Joseph T. Lyons
ce90079104
Fix bug with how characters limits are being displayed
2023-12-07 13:19:03 -05:00
Joseph T. Lyons
0d6fa0434f
Skip using map
2023-12-07 13:00:49 -05:00
Joseph T. Lyons
eef6a641ac
Add TODO
2023-12-07 12:04:04 -05:00
Nate Butler
b616789646
WIP
...
[no-ci]
2023-12-07 10:50:07 -05:00
Nate Butler
5f4e9710ab
WIP
2023-12-07 01:46:28 -05:00
Nate Butler
20cfbb2abe
checkpoint
2023-12-07 00:33:24 -05:00
Joseph T. Lyons
853da8eaa6
WIP
2023-12-06 23:15:04 -05:00
Joseph T. Lyons
582f01ef1d
Renove unused code
2023-12-06 21:32:33 -05:00
Joseph T. Lyons
2a3a77d254
Improve character limit bounds indicator
2023-12-06 21:23:51 -05:00
Joseph T. Lyons
f1831d0e6d
Highlight whole modal as needing UI tweaks
2023-12-06 19:35:41 -05:00
Joseph T. Lyons
149a82ff94
Remove email address from local database if user removes it
2023-12-06 19:26:25 -05:00
Joseph T. Lyons
fa713eba9b
Start work to add a confirmation when exiting feedback containing text
2023-12-06 19:13:38 -05:00
Joseph T. Lyons
b5dc5f9086
Switch to if let statement
2023-12-06 19:11:24 -05:00
Joseph T. Lyons
cc94cfdb30
Hook up community repo button
2023-12-06 19:11:03 -05:00
Joseph T. Lyons
6e7755aa07
Hook up submit
2023-12-06 19:10:45 -05:00
Joseph T. Lyons
a7ec17fe7f
Reduce amount of state being stored
2023-12-06 18:36:17 -05:00
Joseph T. Lyons
a364c9ed70
WIP
2023-12-06 17:27:10 -05:00
Joseph T. Lyons
f9bc8c2511
temp
2023-12-06 16:15:44 -05:00
Joseph T. Lyons
5d3394bf28
Revert "Delete feedback_modal.rs"
...
This reverts commit ca4b016ddc
2023-12-06 14:13:56 -05:00
Joseph T. Lyons
c6e2d20500
WIP
2023-12-06 14:13:44 -05:00
Joseph T. Lyons
ca4b016ddc
Delete feedback_modal.rs
2023-12-06 13:26:20 -05:00
Joseph T. Lyons