Commit Graph
5172 Commits
Author SHA1 Message Date
Kirill Bulatov f5f2f2ccb6 Draft invisibles' tabs display 2023-05-08 19:36:51 +03:00
Max BrunsfeldandAntonio Scandurra 6708c6cd01 Add is_tab field to chunks
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
2023-05-08 19:36:51 +03:00
Julia f79cfd3b61 Prevent some cases of clipping icons due to pixel coord rounding 2023-05-08 11:42:00 -04:00
Antonio Scandurra cbf84f3795 Merge pull request #2441 from zed-industries/implicit-ancestry
Determine view ancestry during layout
2023-05-05 10:58:00 +02:00
Julia cac502638d Fixup cases using buffer model handle id as buffer id 2023-05-04 12:32:31 -04:00
Antonio Scandurra 206e64d67d Merge branch 'main' into implicit-ancestry 2023-05-04 17:19:06 +02:00
Antonio Scandurra 3c580153ed Merge branch 'main' into implicit-ancestry 2023-05-04 14:39:58 +02:00
Antonio Scandurra 5473d8f556 Fix panic when opening multiple definitions in a multibuffer
The editor is on the stack, so adding an item to the `Pane` containing
the editor will cause a double borrow and a consequent panic. This
commit fixes the issue by deferring the opening of the definitions.
2023-05-04 14:34:42 +02:00
Antonio Scandurra 1b1f2a3e5e Avoid re-allocating KeymapContext after every view notification 2023-05-04 12:04:30 +02:00
Max Brunsfeld 54815f70ed Merge branch 'main' into copilot-disabled-globs 2023-05-03 10:53:28 -07:00
Max Brunsfeld 647c3960d9 Add copilot menu item for enabling paths by glob 2023-05-03 10:14:01 -07:00
Antonio Scandurra ac7e73d494 Remove the ability to retrieve the view's parent 2023-05-03 16:52:55 +02:00
Antonio Scandurra 862cc2d132 Compute view ancestry at layout time 2023-05-03 16:36:14 +02:00
Antonio Scandurra bd74322351 Separate Window::build_scene into layout and paint 2023-05-03 12:18:16 +02:00
Julia 25e2016d0d Show diagnostic source in inline diagnostic 2023-05-02 09:08:07 -04:00
Max Brunsfeld 1486f1e91a Add copilot.disabled_globs setting 2023-05-01 13:45:47 -07:00
Antonio Scandurra 2742f1cb76 Remove ViewContext::dispatch_action 2023-05-01 16:27:36 +02:00
Antonio Scandurra 4bb90083cb Remove ViewContext::dispatch_any_action 2023-05-01 14:24:00 +02:00
Antonio Scandurra b2b55aa687 Fix panic when clicking on a definition
This was introduced with #2420 and was caused by re-entrantly updating
the workspace. Instead of passing the workspace reference from the outside,
we now define the definition navigation as a method on the editor which solves
the issue.

Note that we also needed to introduce a `defer` call when navigating to a definition
to prevent the workspace from reading the editor during `open_project_item`.
2023-04-29 14:53:17 +02:00
Joseph LyonsandMax Brunsfeld deae3db26b Rework telemetry code to support sending events to Clickhouse
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
2023-04-28 16:06:55 -04:00
Antonio Scandurra 41b1cda801 Merge remote-tracking branch 'origin/main' into simplify-action-dispatch 2023-04-28 17:31:12 +02:00
Antonio Scandurra 77770d3c82 Remove Scroll internal action 2023-04-28 16:43:31 +02:00
Antonio ScandurraandNathan Sobo 91a4913075 Remove DeployMouseContextMenu internal action
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2023-04-28 16:41:46 +02:00
Antonio Scandurra be095238e0 Remove internal actions from link_go_to_definition 2023-04-28 16:24:46 +02:00
Antonio Scandurra 279094ec8b Remove HideHover and HoverAt internal actions 2023-04-28 16:12:24 +02:00
Antonio Scandurra 6b87c371f9 Remove Jump internal action 2023-04-28 14:13:07 +02:00
Antonio Scandurra b9a764a22b Remove Select internal action 2023-04-28 12:33:22 +02:00
Max Brunsfeld 405fd098ea Merge pull request #2417 from zed-industries/hover-markdown
Render markdown more correctly in the editor hover popover
2023-04-27 14:15:04 -07:00
Max Brunsfeld 0dfec36d14 Give code spans in markdown a background highlight 2023-04-27 13:58:30 -07:00
Max Brunsfeld 75f242a770 Tweak rendering of multi-paragraph list items in markdown 2023-04-27 11:39:34 -07:00
JuliaandMax Brunsfeld c1545d3e23 Re-allow diagnostics hovers to soft wrap
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2023-04-27 14:35:34 -04:00
Julia df8cc2de32 Show source of diagnostic hovers 2023-04-27 14:35:34 -04:00
Antonio Scandurra b00dffa54b Remove internal actions from Pane 2023-04-27 14:23:26 +02:00
Antonio Scandurra d0a1109f62 Allow passing a handler function to context menu items 2023-04-27 11:32:12 +02:00
Max Brunsfeld f4c9fdd7d1 Improve rendering of multi-paragraph list items in hover markdown 2023-04-26 17:09:20 -07:00
Max Brunsfeld 5b9470d2b1 Render more markdown features in hover popover 2023-04-26 15:33:10 -07:00
Antonio ScandurraandNathan Sobo fa65ca0628 Don't allow strong view handles to be read/updated with an AsyncAppContext
This avoids an invitation to hold strong view handles across async await
points, which is a common source of leaks.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2023-04-26 13:36:13 +02:00
Antonio Scandurra 0571bed115 Remove unnecessary calls to WeakViewHandle::upgrade 2023-04-26 11:13:46 +02:00
Antonio Scandurra 947421133a Replace ViewContext::spawn with ViewContext::spawn_weak 2023-04-26 10:23:27 +02:00
Antonio Scandurra 2ebdfb9019 Merge remote-tracking branch 'origin/main' into fewer-context-traits 2023-04-26 09:54:58 +02:00
Max Brunsfeld d1f33d7052 🎨 Specify more dependencies at the workspace level 2023-04-24 17:41:55 -07:00
Max Brunsfeld 8007447bc2 Start work on a language server log view 2023-04-24 09:43:31 -07:00
Max Brunsfeld a17f009b00 Use a workspace dependency for the futures crate 2023-04-24 09:43:31 -07:00
Antonio ScandurraandNathan Sobo 6a2b4b47ef Remove ReadView and UpdateView traits
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2023-04-24 17:36:14 +02:00
Nathan Sobo 1e2bec9c25 Merge remote-tracking branch 'origin/main' into into-element 2023-04-21 14:27:25 -06:00
Nathan Sobo 7a981d1019 Fix more formatting 2023-04-21 14:25:49 -06:00
Nathan SoboandMax Brunsfeld 52d4cc5349 Refine naming of element-related types and traits
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2023-04-21 13:06:37 -06:00
2bd56ab6f0 Rename Drawable::boxed to into_element and make containers generic
Multi-element are now generic over any drawable child, which can be converted
into an element.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2023-04-21 12:43:19 -06:00
Antonio ScandurraandNathan Sobo a614b9528b Remove unnecessary lifetime parameter from WindowContext
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2023-04-21 18:06:53 +02:00
Antonio Scandurra 64ef8b76d3 Take a target view when marking an element as draggable 2023-04-21 15:52:05 +02:00