Antonio Scandurra and Mikayla Maki
d64b0ebd08
Remove terminal integration test
...
Creating a full-fledged terminal is flaky and causes tests to either
hang or outright panic. The only test that requires creating a terminal
was `test_terminal` but we think the value added by that test is not
worth the flakiness, so we're removing it.
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2022-08-02 19:09:34 +02:00
Mikayla Maki
13847a011a
Merge main into branch
2022-08-02 09:25:52 -07:00
Mikayla Maki
52f3edab68
End of day
2022-08-01 17:13:06 -07:00
Mikayla Maki
9d73c4e411
Probably good enough using the two thread solution, latency is low for most things, and it feels good
2022-08-01 16:52:21 -07:00
Mikayla Maki
ba16e3cea9
Abandoning this attempt, nto good enough at async
2022-08-01 16:47:16 -07:00
Mikayla Maki
a6855f7b96
Improved render performance implementation to use a fork of alacritty which includes the last # of bytes processed as a way of estimating throughput in cases where the terminal output is chanegd in place
2022-07-28 16:03:00 -07:00
Mikayla Maki
6cfd74236e
Reduced time holding lock even more
2022-07-28 14:58:19 -07:00
Mikayla Maki
08c8caa8c1
Added variable rate refreshing based on terminal throughput. Should be the last of the performance improvements for now
2022-07-27 16:46:15 -07:00
Mikayla Maki
485db97836
Implemcargo
2022-07-27 16:33:15 -07:00
K Simmons
73858d0935
Move terminal modal keymap context to the connected view
2022-07-27 11:00:54 -07:00
Mikayla Maki
164e72d605
Working on finding a way of estimating throughput
2022-07-27 10:58:23 -07:00
Mikayla Maki
3156a7f2f6
Finished long-lock style rendering. Need to dynamically adjust the notification rate to handle high throughput scenarios
2022-07-27 10:21:50 -07:00
Mikayla Maki
59e98039f4
Nearly done, not scheduling our own re-render yet
2022-07-27 10:11:10 -07:00
Antonio Scandurra
e24138eae6
Don't insert input when the fn key is held
2022-07-27 12:01:44 +02:00
Mikayla Maki
b5b6f2a1ff
Checkpoint, still not compiling
2022-07-26 16:58:14 -07:00
Mikayla Maki
a24e66563d
Added test covering this feature
2022-07-26 16:30:51 -07:00
Mikayla Maki
a77ecce10c
Fixed regression in working directory code
2022-07-26 16:22:07 -07:00
Mikayla Maki
3ff04c8c44
Checkpoint, still converting terminal to events. Not compiling
2022-07-26 16:17:26 -07:00
Mikayla Maki
11d99b055c
removed stray file
2022-07-26 13:10:04 -07:00
Mikayla Maki
fa1d34ccdb
Fixed conflicts
2022-07-25 17:24:25 -07:00
Mikayla Maki
ecde744161
keeping both...
2022-07-25 17:24:25 -07:00
Mikayla Maki
90668ad33a
Finished refactor for mutable terminal and long-single-lock style. Currently terminal is deadlocking instantly, need to just do the full refactor
2022-07-25 17:24:25 -07:00
Mikayla Maki
2c3ba57269
Checkpoint, build failing
2022-07-25 17:24:25 -07:00
Mikayla Maki
c2f99b1da9
Retouched a test, should still be failing
2022-07-25 17:24:25 -07:00
Mikayla Maki
d8499eadf2
Fixed conflict
2022-07-25 17:24:21 -07:00
Mikayla Maki
2f6b4f0fa5
Added event buffering, need to figure out a proper fix
2022-07-25 17:23:00 -07:00
Mikayla Maki
9919f813f0
fixed
2022-07-25 16:08:31 -07:00
Max Brunsfeld
bddad3b226
Update terminal test to reflect new text insertion approach
2022-07-25 12:21:26 -07:00
Antonio Scandurra
47fce17ff8
Merge branch 'main' into ime-support-2
2022-07-25 10:47:49 +02:00
Mikayla Maki
013125e978
Finished terminal refactoring
2022-07-22 13:54:46 -07:00
Mikayla Maki
86b761fb93
Refactored a bunch of stuff, working on tidying element code
2022-07-22 12:06:42 -07:00
Mikayla Maki
68c28d3ecc
Refactored terminal tests
2022-07-22 10:20:15 -07:00
Antonio Scandurra
bfa490c35d
Merge branch 'main' into ime-support-2
2022-07-22 16:03:38 +02:00
Max Brunsfeld
ef1e089260
Remove test for handling input via key events
...
Now, textual input is handled by a different code path than other key events.
2022-07-21 21:40:37 -07:00
Max Brunsfeld
1ac16da8e8
Add simple IME handling to the terminal
2022-07-21 21:32:58 -07:00
Mikayla Maki
b960af3cb0
Finished erorr terminal refactoring
2022-07-21 12:37:15 -07:00
Mikayla Maki
b1a384f96c
added cursor text back
2022-07-21 10:04:12 -07:00
Antonio Scandurra
379f8887ba
Position IME input according to where the selection is rendered
2022-07-21 17:35:40 +02:00
Max Brunsfeld
6288cafecf
Use new API for input handling in Terminal
2022-07-20 17:33:37 -07:00
Mikayla Maki
820ab0c8c5
Render is snappier, less locking, and errors feel nicely modeled
2022-07-20 17:25:21 -07:00
Mikayla Maki
1d659d3422
I think I'm finished
2022-07-20 17:11:36 -07:00
Mikayla Maki
be27f62889
Compiling with new result based error handling
2022-07-20 16:48:40 -07:00
Mikayla Maki
f43d91cebe
Checkpoint, this commit does not compile
2022-07-20 12:41:04 -07:00
Mikayla Maki
7027cf5131
Fixed failing test
2022-07-20 10:34:00 -07:00
Mikayla Maki
918ac54cd5
Updated alacritty version
2022-07-20 10:04:08 -07:00
Mikayla Maki
d56780e624
Done updating rendering performance for now. Further changes would require more fundamental work, I'm still not really happy with it as is though. Will probably take a few hours to clean the code though.
2022-07-20 10:04:08 -07:00
Mikayla Maki
c2cd90d76f
Compiling again... finally
2022-07-20 10:04:08 -07:00
Mikayla Maki
94be942845
Finally finished merging this massive ball of changes
2022-07-20 10:04:08 -07:00
Mikayla Maki
c0b0b2a7e5
Attempting to continue rebase
2022-07-20 10:04:08 -07:00
Mikayla Maki
9a0703cd7e
Finished graceful terminal failure
2022-07-20 10:04:08 -07:00
