yenru0/zed
1
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
39,175 Commits 5 Branches 0 Tags
fbda4f862a2fb03b854636b17bd04be3db3d94de
Commit Graph
31406 Commits
Author SHA1 Message Date
Julia 2b120af824 Prevent panic dragging tab into terminal panel 2023-12-21 12:56:30 -05:00
Antonio Scandurra 8644ae15eb Optimize order rendering and border drawing (#3759) 
This fixes the slowdowns we were observing when opening the saved
assistant conversations.

Release Notes:

- N/A
 2023-12-21 18:19:39 +01:00
Marshall Bowers ee820f22dd Improve chat panel styling (#3758) 
This PR improves the chat panel styling, especially with regards to the
spacing.

Release Notes:

- N/A
 2023-12-21 12:15:11 -05:00
Antonio Scandurra b8b5fe7355 Delete stray comment 2023-12-21 17:55:26 +01:00
Antonio ScandurraandNathan Sobo db3b046ed0 Use smaller quads to draw borders 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2023-12-21 17:54:13 +01:00
Antonio Scandurra 8e2e081728 Replace BspSplitter with brute-force sorting of primitives 2023-12-21 16:58:36 +01:00
Marshall Bowers c0ceb4c0dd Increase inline assistant editor's line height (#3757) 
This PR increases the line height for the inline assistant editor.

This fixes an issue where descenders were being clipped.

Release Notes:

- N/A
 2023-12-21 10:56:52 -05:00
Antonio Scandurra 8d3e6f4102 Allow scrolling of saved conversations (#3756) 
Release Notes:

- N/A
 2023-12-21 15:42:38 +01:00
Antonio Scandurra dee2603e1b Use existing AnyElement::draw 2023-12-21 15:32:05 +01:00
Antonio Scandurra 7ca4f7ebed Fix warnings 2023-12-21 15:27:08 +01:00
Antonio Scandurra 86d37be79c Correctly clamp scroll offset vertically 2023-12-21 15:23:16 +01:00
Antonio Scandurra 83a0359593 Allow scrolling saved conversations 2023-12-21 15:22:49 +01:00
Joseph T. Lyons 44d4131502 Store email address on modal close 2023-12-21 09:04:54 -05:00
Antonio Scandurra 8ce13e6476 Fix clicking on "+" button not working when a tab was underneath (#3755) 
We were mistakenly pushing an opaque layer without intersecting it with
the content mask. Also, we were pushing two opaque layers for the same
div unnecessarily.

Release Notes:

- N/A
 2023-12-21 14:57:52 +01:00
Antonio Scandurra a9f28d6f60 Fix clicking on "+" button not working when a tab was underneath 
We were mistakenly pushing an opaque layer without intersecting it
with the content mask. Also, we were pushing two opaque layers for
the same div unnecessarily.
 2023-12-21 14:28:06 +01:00
Kirill Bulatov b6849faffa Fix Zed2 cli actions: opening notes and joining calls (#3754) 
Release Notes:

- N/A
 2023-12-21 14:34:14 +02:00
Kirill Bulatov 6cb70ede1c Fix Zed cli actions: opening notes and joining calls 2023-12-21 14:27:13 +02:00
Antonio Scandurra 83548b694d Fix stale scroll position in tab bar 2023-12-21 10:03:15 +01:00
Antonio Scandurra 25a2af74d7 Remove stray dbg 2023-12-21 09:44:54 +01:00
Antonio Scandurra 5172856959 Provide mut access to allocated arena struct via non-cloneable ArenaBox 
This commit also allows turning an `ArenaBox` into an `ArenaRef` when
non-mutable access is required, which makes `ArenaRef: Clone`. This fixes
a bug that prevented the command palette from reading all the available
actions while the `command_palette::Toggle` action was being dispatched.
 2023-12-21 09:41:48 +01:00
Joseph T. Lyons 324019051f Fix layout issues with feedback modal 
The feedback modal still needs a styling update
 2023-12-20 23:54:50 -05:00
Nathan Sobo 2173d67d5f Clear pending keystrokes when an action is dispatched (#3750) 
This prevents the `cmd-k` keystroke, which clears the terminal, from
staying around as a pending keystroke on the parent workspace.

Release Notes:

- N/A
 2023-12-20 20:50:59 -07:00
Nathan Sobo c3b2fadcec Correctly compute placeholder text for buffer search query editor (#3749) 
Rather than relying on the focused element, instead explicitly pass the
focus handle for the query editor when determining the prev/next
bindings. Only compute these values once.

Release Notes:

- N/A
 2023-12-20 20:48:31 -07:00
Nathan Sobo 71f212fba6 Clear pending keystrokes when an action is dispatched 2023-12-20 20:41:36 -07:00
Nathan Sobo a2881461ca Remove unused import 2023-12-20 19:53:57 -07:00
Nathan Sobo 169da76231 Improve interaction between clicking and dragging (#3737) 
Once a drag starts, we won't fire click listeners or style any elements
as active.

- Don't fire click listeners or show active state once a drag is in
progress
- Don't show hover style when a drag is in progress
- Draw borders above content
- If borders are opaque, apply them to the content mask. This prevents
hovers from firing on content underneath the border, which was creating
issues where the drag handle was inside the border, so we'd flicker the
hover when the mouse moved out of the drag handle and into the 1px
border on the left dock.
- Add a `block_mouse` helper which causes transparent elements to paint
an "opaque" layer to prevent mouse events from falling through. We use
this for the drag handle as well to disable hover, click, etc on items
in the panel.

Release Notes:

- N/A
 2023-12-20 19:31:06 -07:00
Max Brunsfeld 29ebc46ada Ensure that views' on_release callbacks are always called (#3747) 
* Ensure that views' on_release callbacks are always called (even if
their window is gone), by passing them a `AppContext`, not a
`WindowContext`.
* Fix leaked handles to `CollabPanel`, `NotificationPanel`, and
`ChatPanel` caused by captures in a `ListState` render callback.

This fixes two issues we were seeing with following:
* inability to rejoin a remote project after you closed it
* following not working if a window had previously been closed
 2023-12-20 16:45:37 -08:00
Max Brunsfeld 13e3c4f18d Fix view handle leaks in ListState callbacks 2023-12-20 16:33:10 -08:00
Kirill Bulatov 1f214b47ae For file finder queries, search in all gitignored worktree entries 2023-12-21 02:21:27 +02:00
Max Brunsfeld 3a21b8dfe0 Prune dead workspaces from WorkspaceStore on read 
Also, remove unnecessary window handle from Workspace.
 2023-12-20 16:08:58 -08:00
Max Brunsfeld cbbeddc204 Ensure that on_release callbacks are called even if view outlives its window 2023-12-20 16:01:52 -08:00
Marshall Bowers 905cc879c7 Add ToggleButton for use in buffer search (#3746) 
This PR adds a new `ToggleButton` component:

<img width="738" alt="Screenshot 2023-12-20 at 6 50 13 PM"
src="https://github.com/zed-industries/zed/assets/1486634/9c5fb45b-0b55-4008-9336-b651a26a99ad">

We're using `ToggleButton`s for the search mode selection in the buffer
search:

<img width="842" alt="Screenshot 2023-12-20 at 6 47 57 PM"
src="https://github.com/zed-industries/zed/assets/1486634/178a278f-172c-4c67-8572-83d59de2ed14">

Release Notes:

- N/A
 2023-12-20 19:00:04 -05:00
Marshall Bowers e1cf36aa6a Add large variant for buttons 2023-12-20 18:47:22 -05:00
Marshall Bowers ab2fb09b8f Use ToggleButtons for search mode in buffer search 2023-12-20 18:32:12 -05:00
Marshall Bowers 128b97cdf7 Add ToggleButton component 2023-12-20 18:23:21 -05:00
Kirill Bulatov e50704e6dc Remove nightly from zed1 and use proper namespaces for nightly in zed2 manifest 2023-12-21 01:18:00 +02:00
Kirill Bulatov 3d795b6236 Restore "reveal in project panel" and "search in directory" context menu actions 2023-12-21 01:07:05 +02:00
Marshall Bowers b6a23e77c0 Inline toggle replace button 2023-12-20 17:34:08 -05:00
Marshall Bowers bfcf2ff2d0 Inline buttons 2023-12-20 17:31:36 -05:00
Marshall Bowers 143ef14117 Style replace input 2023-12-20 17:25:38 -05:00
Marshall Bowers 9b7d6cd4f6 Improve spacing of items in buffer search bar 2023-12-20 17:10:27 -05:00
Marshall Bowers 8a0c95d729 Increase toolbar padding 2023-12-20 17:03:44 -05:00
Marshall Bowers 7346ed8a43 Don't apply the gap when we don't have any items in the first row 2023-12-20 17:02:15 -05:00
Nathan Sobo ca69cc23e0 Merge remote-tracking branch 'origin/main' into cancel-clicks-on-drag 2023-12-20 15:01:10 -07:00
Nathan Sobo 3f994735ff Only compute placeholder text once 2023-12-20 14:47:56 -07:00
Marshall Bowers 28942699d0 Tighten up project share notifications 2023-12-20 16:06:59 -05:00
Marshall Bowers 2990c17cb1 Style incoming call notifications 2023-12-20 15:59:01 -05:00
Nathan Sobo 0421bfe734 Compute the query editor placeholder text with a focus handle 
So we're not beholden to the current focus.
 2023-12-20 13:00:52 -07:00
Piotr Osiewicz 469d82beec chore: Remove 'db' dependency from recent_projects2 (#3740) 
It was pulling in gpui1 into zed2 build.

Release Notes:

- N/A
 2023-12-20 20:38:37 +01:00
Marshall Bowers 31c90694c5 Style notification panel (#3741) 
This PR makes a first pass at styling the notification panel.

#### Signed out

<img width="381" alt="Screenshot 2023-12-20 at 11 41 25 AM"
src="https://github.com/zed-industries/zed/assets/1486634/f045fa17-4ebc-437f-a25b-d7695d47f18b">

#### No notifications

<img width="380" alt="Screenshot 2023-12-20 at 11 44 23 AM"
src="https://github.com/zed-industries/zed/assets/1486634/3a7543f2-8cd8-4788-8059-d5663f5f6b4c">

#### Notifications

<img width="386" alt="Screenshot 2023-12-20 at 1 27 08 PM"
src="https://github.com/zed-industries/zed/assets/1486634/13b81722-c47a-4c06-b37d-e6515cbfdb9d">

Release Notes:

- N/A
 2023-12-20 14:06:33 -05:00