Commit Graph
31406 Commits
Author SHA1 Message Date
Kirill Bulatov 9fd57e4dde Return include warnings toggle to the diagnostics panel 2023-12-14 10:00:31 +02:00
Marshall Bowers dc46d0c0a6 Change project search bar flex axis to column (#3647)
This PR changes project search bar's flex axis to `column`.

This fixes an issue where toggling the filters would cause the search
controls to center themselves vertically instead of staying next to the
search input.

Release Notes:

- N/A
2023-12-13 23:02:49 -05:00
Julia d2a9f95a11 Quick and dirty attempt to immediately apply focus change in tests
Doesn't quite work yet
2023-12-13 21:48:05 -05:00
Joseph T. Lyons 44a3fd0cc7 Avoid unnecessary match 2023-12-13 21:43:21 -05:00
Mikayla Maki b3510e24b0 Fix bugs in resizing the docks + Add debug styling (#3645)
This PR:
- Fixes several bugs with dock resizing
- Adds a new drag move API for resizes 
- Adds special debug styling for elements, including auto-opening Zed at
the element's location in source
- Changes the `cx.paint_quad()` API to take a type and adds several
helpers to create this type.
- Adds `()` as the empty element, and uses it to implement a derive
macro for the `Render` trait.

Release Notes:

- N/A
2023-12-13 18:40:28 -08:00
Joseph T. Lyons a9573de153 Highlight email address field as red when invalid 2023-12-13 21:39:31 -05:00
Joseph T. Lyons 80473a44b8 Remove completed TODOs 2023-12-13 21:35:30 -05:00
Mikayla 8b9240cb84 Remove inconsistency with how GPUI used to handle these events 2023-12-13 18:32:42 -08:00
Mikayla 626ed06f86 Merge branch 'main' into fix-splits-bugs 2023-12-13 18:29:48 -08:00
Joseph T. Lyons 01f4d7bcef Use an enum to represent modal states and simplify logic 2023-12-13 21:20:09 -05:00
Joseph T. Lyons fb22f04409 Add Duration dependency 2023-12-13 21:19:36 -05:00
Mikayla 83407107df add cmd-click-to-jump-to-element 2023-12-13 18:19:25 -08:00
Joseph T. Lyons 9d9205ca8d Use existing convention to silence warnings 2023-12-13 21:19:12 -05:00
Joseph T. Lyons 70fbe2b02c Simulate sending feedback in dev 2023-12-13 21:18:50 -05:00
Marshall Bowers c923ff8f4d Ensure the outer ListItem element has a unique ID (#3644)
This PR fixes an issue where the outer `ListItem` element was using a
static ID instead of the one provided to the component.

Now that active states are fixed, this meant that any time there were
sibling list items they would share active states if one of them was
clicked.

Release Notes:

- N/A
2023-12-13 21:14:21 -05:00
Marshall Bowers 5231b412ef Remove unneeded left-click filtering in ListItem (#3643)
This PR removes the left-click filtering from the `on_click` handler for
`ListItem`s.

It's no longer needed after #3584.

Release Notes:

- N/A
2023-12-13 21:03:50 -05:00
Nathan Sobo 2d4d76ca87 Log frame timings 2023-12-13 18:44:21 -07:00
Marshall Bowers 45a30238e9 Implement VisibleOnHover for IconButton (#3642)
This PR implements the `VisibleOnHover` trait for `IconButton`s.

I noticed that in a lot of places we were wrapping an `IconButton` in an
extra `div` just so we could call `visible_on_hover` on it. By
implementing the trait on `IconButton` directly it allows us to avoid
the interstitial `div` entirely.

Release Notes:

- N/A
2023-12-13 20:42:27 -05:00
Max Brunsfeld cc4e0b2fa1 Allowing dragging tabs onto panes and pane edges (#3641) 2023-12-13 17:23:43 -08:00
Max Brunsfeld dc210610b8 Clone item when dragging to split 2023-12-13 17:16:00 -08:00
Max Brunsfeld d6542feb14 Ensure only top layer is styled with drag over style 2023-12-13 17:07:23 -08:00
Max Brunsfeld 8b9080cbb2 Start work on allowing dragging tabs onto panes and pane edges 2023-12-13 17:06:42 -08:00
Mikayla 14ef7fbb55 Add interactive debug info 2023-12-13 17:03:56 -08:00
Mikayla 15c01277af Add debug and debug below methods for observing the bounds of divs 2023-12-13 16:47:55 -08:00
Mikayla 992828bacb Tidy up workspace resizing 2023-12-13 16:35:25 -08:00
Marshall Bowers 9d2708c71e Add .visible_on_hover helper method (#3639)
This PR adds a `.visible_on_hover` helper method that can be used to
make an element only visible on hover.

I noticed we were repeating this similar stanza in a bunch of different
spots:

```rs
some_element
    .invisible()
    .group_hover("", |style| style.visible())
``` 

so it seemed like a nice thing to factor out into a reusable utility.

Release Notes:

- N/A
2023-12-13 19:12:20 -05:00
92b959fc4e Style collab panel (#3638)
This PR styles the collab panel.

Release Notes:

- N/A

---------

Co-authored-by: Nate Butler <iamnbutler@gmail.com>
Co-authored-by: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-12-13 18:20:04 -05:00
Mikayla 33a127bd78 Fix dock split resizin 2023-12-13 15:14:51 -08:00
Nathan Sobo 1b0e54ca45 Don't notify when drawing 2023-12-13 16:05:34 -07:00
Conrad Irwin 745b74dc37 Don't hang the app when signing in offline 2023-12-13 15:52:43 -07:00
Joseph T. Lyons 9659a57292 Fix variable name 2023-12-13 17:31:51 -05:00
Joseph T. Lyons e9cdc16b4c Remove TODO
Thanks @ConradIrwin
2023-12-13 17:09:26 -05:00
Mikayla f87a8c5565 Add new drag API 2023-12-13 13:40:19 -08:00
Max Brunsfeld 8f1406442b frame time 2023-12-13 14:22:34 -07:00
Mikayla de754ed76f Add fluent quad API 2023-12-13 13:21:48 -08:00
Conrad Irwin 6256da7df2 Implement user menu 2023-12-13 14:14:03 -07:00
Conrad Irwin d528b07b8c Port project_symbols (#3634)
Release Notes:

- N/A
2023-12-13 14:13:25 -07:00
Antonio Scandurra 93a3e739aa Optimize inserting lots of primitives with the same StackingOrder (#3631)
Release Notes:

- N/A
2023-12-13 22:12:31 +01:00
Marshall BowersandNate a432aa627b Rework ListItem and ListHeader to use slot-based APIs (#3635)
This PR reworks the `ListItem` and `ListHeader` components to use
slot-based APIs, making them less opinionated about their contents.

Splitting this out of the collab UI styling PR so we can land it to
avoid conflicts.

Co-authored-by: Nate <nate@zed.dev>

Release Notes:

- N/A
2023-12-13 16:08:31 -05:00
Antonio Scandurra 35f1f9d5f4 Clear last_order when building Scene 2023-12-13 22:02:30 +01:00
Piotr Osiewicz fe1b402c16 fixup! collab_ui: Wire up project picker 2023-12-13 12:53:41 -08:00
Piotr OsiewiczandConrad fc8e5cfc4d collab_ui: Wire up project picker
Co-authored-by: Conrad <conrad@zed.dev>
2023-12-13 12:53:41 -08:00
Joseph T. Lyons 35a4dfaa9f v0.118.x dev 2023-12-13 12:53:41 -08:00
Marshall Bowers c6cf3c52cb Wire up tooltips on tab bar actions (#3629)
This PR wires up the tooltips on the actions in the tab bar.

Release Notes:

- N/A
2023-12-13 12:53:41 -08:00
Marshall Bowers 4346df11df Fix tab bar drop target sizing (#3627)
This PR fixes an issue where the tab bar drop target was not receiving
any size.

The styling isn't 100% correct yet, as the updated background color has
a gap around it.

Release Notes:

- N/A
2023-12-13 12:53:41 -08:00
Piotr Osiewicz 39a5826df7 Add inclusion of ignored files 2023-12-13 12:53:41 -08:00
Piotr Osiewicz e01fa587f9 Bring back semantic search UI 2023-12-13 12:53:41 -08:00
Conrad Irwin 0b2d20be0b Port project_symbols 2023-12-13 13:43:39 -07:00
Marshall Bowers 8e16d05049 Fix styling of project search tabs (#3633)
This PR fixes the styling of the project search tabs.

We now have spacing between the icon and the tab label, as well as use
the correct color for the icon based on whether the tab is active or
not.

Release Notes:

- N/A
2023-12-13 14:50:15 -05:00
Marshall Bowers 1a2584222c Don't show empty documentation labels in completions menu (#3632)
This PR fixes an issue where we would sometimes have extra blank lines
in the completions menu.

This was due to some items including documentation labels that were
empty strings.

Release Notes:

- N/A
2023-12-13 14:15:03 -05:00