Commit Graph
31406 Commits
Author SHA1 Message Date
Mikayla Maki 5ace4b8f06 Merge branch 'main' into add-collab-tests 2023-11-03 18:06:08 -07:00
Mikayla c163c12bca Get collab2 green 2023-11-03 18:01:06 -07:00
Max Brunsfeld 7b7ba5236d WIP2000 2023-11-03 16:40:37 -07:00
Max Brunsfeld 3500ef8b50 Allow language injection in markdown code blocks in channel notes 2023-11-03 15:53:54 -07:00
JuliaandConrad Irwin e56b9f7f45 Move more tooltip logic into gpui2 & fix tooltip moving on paint
Co-Authored-By: Conrad Irwin <conrad@zed.dev>
2023-11-03 18:37:15 -04:00
Nate Butler c6b1ef2c38 Merge branch 'main' into add-ui-docs 2023-11-03 18:20:17 -04:00
Nate Butler 7080241479 Add some initial docs 2023-11-03 18:19:54 -04:00
Marshall Bowers 80ad36479b storybook2: Remove unreferenced components module (#3229)
This PR removes the `components` module from `storybook2` as it was
dead, unreferenced code.

Release Notes:

- N/A
2023-11-03 18:12:21 -04:00
JuliaandConrad Irwin 438dcffdad Tooltips in mouse event handler & fix executor timer
Co-Authored-By: Conrad Irwin <conrad@zed.dev>
2023-11-03 18:02:58 -04:00
Marshall Bowers 49922ece21 ui2: Reorganize components (#3228)
This PR reorganizes the components in the `ui2` crate.

The distinction between "elements" and "components" is now gone, with
all of the reusable components living under `components/`.

The components that we built while prototyping but will eventually live
in other crates currently reside in the `to_extract/` module.

Release Notes:

- N/A
2023-11-03 17:34:11 -04:00
Marshall Bowers f81e3f4dab Allow deriving Serialize and Deserialize on generated refinement (#3227)
This PR adds support for deriving `Serialize` and `Deserialize` on the
refinement type generated by `#[derive(Refineable)]`.

Release Notes:

- N/A
2023-11-03 17:21:00 -04:00
Marshall Bowers 95216af9d5 Remove unneeded type qualification 2023-11-03 16:40:46 -04:00
Nate ButlerandMarshall Bowers 5426d44499 Add docs burndown list
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-03 16:37:22 -04:00
Marshall Bowers 137c08c810 Use an IconButton for the tab close button 2023-11-03 16:36:02 -04:00
Nate ButlerandMarshall Bowers 7782368831 Start on ui root doc
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-03 16:28:54 -04:00
Conrad Irwin db65488f14 MOAR TOOLTIPS 2023-11-03 14:15:32 -06:00
Kirill Bulatov 1e24f68814 Refresh diagnostics inside the tab (#3225)
r-a now has 2 different types of diagnostics: 
* "disk-based" ones that come from `cargo check` and related, that emit
`project::Event::DiskBasedDiagnosticsStarted` and
`DiskBasedDiagnosticsFinished`
* "flycheck" diagnostics from r-a itself, that it tries to dynamically
apply to every buffer open, that come with `DiagnosticsUpdated` event.

Latter diagnostics update frequently, on every file close and open, but
`diagnostics.rs` logic had never polled for new diagnostics after
registering the `DiagnosticsUpdated` event, so the only way we could
have newer diagnostics was to re-open the whole panel.
The PR fixes that, and also adds more debug logging to the module.
The logic of the fix looks very familiar to previous related fix:
https://github.com/zed-industries/zed/pull/3128

One notable thing after the fix: "flycheck" diagnostics stay forever if
the diagnostics panel is opened: excerpts in that panel do not allow the
buffer to get dropped (hence, closed in terms of r-a) and get the
updated, zero diagnostics.
If the diagnostics panel is opened and closed multiple times, those
errors gradually disappear.

Release Notes:

- Fixed diagnostics panel not refreshing its contents properly
2023-11-03 22:03:05 +02:00
Conrad IrwinandJulia 5687664b81 Tooltip on tabs
Co-Authored-By: Julia <julia@zed.dev>
2023-11-03 14:02:46 -06:00
Kirill Bulatov 1ed9260477 Fix the test 2023-11-03 21:51:12 +02:00
Kirill Bulatov 2996ff6c1b Fix a compilation error 2023-11-03 21:51:12 +02:00
Kirill Bulatov 3592b98e8f Refresh diagnostics inside the tab 2023-11-03 21:51:12 +02:00
Marshall Bowers f9701564ce Merge branch 'main' into import-theme 2023-11-03 15:41:12 -04:00
Marshall Bowers 9e7f83068a Remove Default impl for ThemeColors` (#3226)
This PR removes the `Default` impl for `ThemeColors`.

Since we need default light and dark variants for `ThemeColors`, we
can't use a single `Default` impl.

Release Notes:

- N/A
2023-11-03 15:40:50 -04:00
a1e9f0f311 Fix double borrow in synchronous tests that take AppContext
Co-authored-by: Mikayla <mikayla@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
2023-11-03 12:10:11 -07:00
Mikayla 3a4d70b212 WIP 2023-11-03 12:04:24 -07:00
Conrad Irwin b2c983034b gpui2: Add on_hover events 2023-11-03 12:51:38 -06:00
Antonio Scandurra 18f34e4eed WIP 2023-11-03 18:55:20 +01:00
Mikayla b4c926ad13 Update to latest patterns for porting work 2023-11-03 10:46:47 -07:00
Max BrunsfeldandMarshall eeaa7c7685 Add channel2 crate
Co-authored-by: Marshall <marshall@zed.dev>
2023-11-03 10:41:41 -07:00
Conrad Irwin 48800ad097 Add PointingHand on tabs 2023-11-03 11:30:15 -06:00
aebf31819c Add hover behaviour to tabs
Co-Authored-By: Marshall <marshall@zed.dev>
Co-Authored-By: Nathan <nathan@zed.dev>
2023-11-03 10:55:07 -06:00
KCaverly 29315fe06f port rope2 to zed2 2023-11-03 12:15:23 -04:00
Antonio Scandurra 8ffded7fa5 WIP: start on editor element 2023-11-03 17:14:17 +01:00
Conrad IrwinandJulia dc41855b96 Fix bug when unsubscribe called after remove
Co-Authored-By: Julia <julia@zed.dev>
2023-11-03 09:56:35 -06:00
Conrad Irwin db23fbd69d Make the close button close 2023-11-03 09:20:27 -06:00
Antonio Scandurra 3958abaa90 Ensure panes cover the available space 2023-11-03 16:14:03 +01:00
Conrad Irwin 5032e61f73 Fix tab text colors 2023-11-03 09:12:12 -06:00
Marshall Bowers 9b1559bada Exclude source themes from Zed2 binary 2023-11-03 11:11:10 -04:00
Kyle Caverly e216233676 added workspace event for WorkspaceCreated (#3222)
added workspace2 event for WorkspaceCreated

Release Notes:

- NA
2023-11-03 11:06:11 -04:00
Marshall Bowers f70852c328 Update emitted module import 2023-11-03 10:58:06 -04:00
Marshall Bowers b37fdcab3d Account for colors in VS Code theme being optional 2023-11-03 10:54:12 -04:00
Antonio Scandurra 78393c3e21 Make tab bar visible 2023-11-03 15:51:33 +01:00
Marshall Bowers b0d3bdb08e Update color names in workspace2 2023-11-03 10:16:34 -04:00
Marshall Bowers ca64641b26 Merge branch 'main' into import-theme 2023-11-03 10:11:35 -04:00
Antonio Scandurra 327a700c80 Don't depend on gpui2 in text 2023-11-03 14:53:08 +01:00
Antonio Scandurra 305c7b29a2 Merge remote-tracking branch 'origin/main' into editor2 2023-11-03 14:47:49 +01:00
Antonio Scandurra c4c9ce9be2 Remove more todos 2023-11-03 14:42:26 +01:00
Antonio Scandurra 53077fe80b Add ViewContext::window_context 2023-11-03 14:41:37 +01:00
KCaverly a378036917 added workspace event for WorkspaceCreated 2023-11-03 08:52:18 -04:00
Kirill Bulatov 574176ae6d Remove and add more todosmerge . 2023-11-03 13:22:11 +02:00