Commit Graph
31406 Commits
Author SHA1 Message Date
Conrad Irwin a22d09c9d7 Fix Y on last line with no trailing new line
For zed-industries/community#2044
2023-09-15 11:14:04 -06:00
Max Brunsfeld d115ba1b26 Ensure the chat panel is fully feature flagged 2023-09-15 10:13:43 -07:00
Nate Butler 0dc4475f7f Unify icons using multiple variants, remove all unused icons 2023-09-15 12:50:49 -04:00
Conrad Irwin bca265c25b Make cargo test -p gpui work 2023-09-15 10:24:12 -06:00
Conrad Irwin 943feaa45c Fix multi-character shortcuts with modifiers (#2968)
This moves the IME shortcut handling over to the keystroke matcher so
that it
can not clear pending matches when trying out the IME equivalent.

Release Notes:

- vim: add `g s` / `g S` to show symbols in the current buffer /
workspace
- Fix multi-key shortcuts with modifiers (preview-only)
2023-09-15 10:15:01 -06:00
Nate Butler 616fb506a7 Checkpoint 2023-09-15 11:41:21 -04:00
KCaverly d657691ced add ndcg@k to evaluate metrics 2023-09-15 10:36:21 -04:00
KCaverly 44249374dc catchup with main 2023-09-15 09:31:33 -04:00
Antonio Scandurra 9c8feb82a6 Don't dismiss inline assistant when an error occurs 2023-09-15 12:32:37 +02:00
Antonio Scandurra c450c67a9d Include modified buffers in semantic search results (#2970)
This pull request introduces an additional step to
`SemanticIndex::search_project` that includes the content of buffers
that are modified but haven't been saved yet. In most cases, the buffer
will contain a small portion of changed spans that are potentially not
included in the index. To reuse all the other spans that haven't
changed, we will query the database for embeddings by their digest. This
means we have to index spans by their digest, which means some penalty
when writing, but in our tests this didn't seem to make indexing much
slower.

Release Notes:

- Improved semantic search to include results from modified buffers.
(preview-only)
2023-09-15 12:24:10 +02:00
Antonio Scandurra c5dcfc4d05 Refactor semantic searching of modified buffers 2023-09-15 12:12:20 +02:00
Kirill Bulatov f98a5f4479 Rework inlay hover model (#2969)
Fixes
```
thread 'main' panicked at 'byte index 2 is not a char boundary; it is inside '…' (bytes 0..3) of `…)`'
```
panics like
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1694535396473329

by reworking the inlay hover model:
* avoid storing "hardcoded" coordinates of hovered inlay labels (such as
`InlayOffset`), instead, remember `inlay_id` and apply required
highlights there when hint with the same id is handled
* add randomized tests on inlay highlights
* sped up inlay hint cache lookup by inlay_id

As a downside, background highlights are no long appearing on inlay
hints, but Zed does not receive any tooltips for inlays anyway (r-a does
not send them for some reason, other LSP seem to have no such feature?),
so it does not matter now.
Nontheless, if the logic for displaying hint pop-ups is present and
works for harcoded tooltips in r-a, only background highlight is missing
now.

Release Notes:

- Fixed inlay hint highlights causing panic for certain cases with
"large" characters
2023-09-15 10:40:02 +03:00
Kirill Bulatov e78bff1ebb Empty both hint cache storages correctly 2023-09-15 10:33:32 +03:00
Nathan Sobo 4ad2ce6e07 Checkpoint 2023-09-14 21:42:56 -06:00
Max Brunsfeld 18882a4fb6 Bump protocol version 2023-09-14 18:39:31 -07:00
Max Brunsfeld 1462bb38ca Add tooltips and actions for opening notes+call from chat
No keyboard shortcut yet.
2023-09-14 18:38:37 -07:00
Max Brunsfeld 5a2c3c4393 Add buttons for opening channel notes and joining call, in chat panel header 2023-09-14 18:05:44 -07:00
Nathan Sobo 9cc4ef000f Checkpoint 2023-09-14 18:51:03 -06:00
Max Brunsfeld 1965c351e3 Style the chat panel further 2023-09-14 17:19:08 -07:00
KCaverly 54487b74fe update searching in modified buffers to accomodate for excluded paths 2023-09-14 19:42:06 -04:00
Max Brunsfeld 60ffa5f9e7 Allow deleting chat messages 2023-09-14 16:29:40 -07:00
Nathan Sobo 58ac12ae05 WIP 2023-09-14 16:52:04 -06:00
Nathan Sobo 987a5dfe09 Checkpoint 2023-09-14 16:19:48 -06:00
Nathan Sobo 885bf731d1 Checkpoint 2023-09-14 16:14:42 -06:00
Max Brunsfeld 3cb0e69878 Merge branch 'main' into chat-again 2023-09-14 14:50:45 -07:00
Nathan Sobo 1038c6ef19 Checkpoint 2023-09-14 15:49:54 -06:00
Nathan Sobo 18a56d9a37 Checkpoint 2023-09-14 15:34:39 -06:00
Piotr Osiewicz 228467bf59 search_bar: Add toggle_replace_on_a_pane. (#2966)
This allows users to add a keybind to ToggleReplace from Editor/Pane
contexts.

Release Notes:
- Fixed replace in buffer not reacting to keyboard shortcuts outside of
search bar<preview-only>.
2023-09-14 23:25:27 +02:00
Nathan Sobo f2bcffa2b6 Slotmaps 2023-09-14 15:21:49 -06:00
Kirill Bulatov bc36e906d3 Combine both text and inlay highlights in randomized tests 2023-09-14 23:53:56 +03:00
Max Brunsfeld d9df8ed631 Provide an admin REST API for use by zed.dev (#2962)
We're using [PostgREST](https://hub.docker.com/r/postgrest/postgrest)

Todo:
* [x] Add instructions for installing postgrest to local development
docs
* [x] Deploy to staging
* [x] Deploy to production
* [x] Add DNS record for `admin-staging.zed.dev` pointing to the staging
db
* [x] Add a DNS record for `admin.zed.dev` pointing to the production db
2023-09-14 13:48:54 -07:00
Nathan Sobo 1885d71924 Checkpoint 2023-09-14 14:47:02 -06:00
Nathan Sobo bf85f3580e Checkpoint 2023-09-14 14:42:04 -06:00
Kirill Bulatov 1d88a1ea63 Store hints in the map, not the snapshot 2023-09-14 23:36:33 +03:00
Conrad Irwin 914959abf3 Fix multi-key shortcuts with modifiers
To make this work we need to move the handling of multiple possible key
events into the keyboard shortcut system.

This was broken in #2957.
2023-09-14 14:35:17 -06:00
Kirill Bulatov de1ca60a54 Improve inlay hint cache lookup 2023-09-14 23:31:50 +03:00
Kirill Bulatov 17b09eb060 Restructure inlay highlights data for proper access 2023-09-14 23:05:22 +03:00
KCaverly 02c4b3f56b small fix to rate status update 2023-09-14 15:42:21 -04:00
Kirill Bulatov 8702be1933 Remove useless background highlights code 2023-09-14 22:18:30 +03:00
Kirill Bulatov 0c70840290 Uncomment the rest of the tests 2023-09-14 22:18:26 +03:00
Kirill Bulatov 130e873079 Randomize inlay highlight range start 2023-09-14 22:08:12 +03:00
Kirill Bulatov a2dba081dc Consider offsets in inlay chunks 2023-09-14 22:08:12 +03:00
Kirill BulatovandAntonio Scandurra 15942c31ef Properly handle inlay highlights in the InlayMap
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-09-14 22:08:12 +03:00
Kirill Bulatov 58a24cf6d8 Add inlay highlight test 2023-09-14 22:08:12 +03:00
Kirill Bulatov 95bfe39bf9 Implement inlay highlighting 2023-09-14 22:08:12 +03:00
Kirill Bulatov d2b0649378 Use standalone inlay background highlights 2023-09-14 22:08:12 +03:00
Kirill Bulatov c8ede63d7c Unify highlights in *Map 2023-09-14 22:08:12 +03:00
Kirill Bulatov 5a9d375f79 Do not combine inlay and text highlights on the *Map level 2023-09-14 22:08:12 +03:00
KCaverly c549532a98 add initial search inside modified buffers 2023-09-14 14:58:34 -04:00
Piotr Osiewicz 46f38f13ed editor: Do not run brace completion on empty text. (#2965)
Users of keyboard layout with IME complained about the peculiar
behaviour where typing in "sss" and then removing all of it left behind
one 's' and also appended a closing brace. This was not reproducible on
a buffer without language, so I've suspected that brace insertion might
be a problem here. For whatever reason when the user removes the last
character from a run that triggered IME, we receive a notification about
an empty insertion. Sadly, brace completion does not handle an empty
input properly and we erroneously insert a closing brace when deleting
the followup characters. In fact, the brace inserted is always the
closing brace for the first entry in language's config.toml 'brackets'
field (see Scheme vs Markdown). This guard also allows for the proper
removal of the first character.

Closes community tickets zed-industries/community#877
zed-industries/community#1329

Z-2869

Release Notes:
- Fixed handling of bracket completion for international keyboard
layouts that use IME. This led to Zed erroneously inserting the `}`
character while removing the first character that triggered IME.
2023-09-14 20:24:21 +02:00