Commit Graph
31406 Commits
Author SHA1 Message Date
Nathan Sobo f0132c19a9 Store AnyWindowHandles instead of usizes 2023-08-08 16:06:53 -06:00
Mikayla 647f724c30 Position and style the channel editor correctly
Fix a bug where some channel updates would be lost
Add channel name sanitization before storing in the database
2023-08-08 14:06:29 -07:00
Mikayla 23628aaf3f Position and style the channel editor correctly
Fix a bug where some channel updates would be lost
Add channel name sanitization before storing in the database
2023-08-08 12:46:13 -07:00
Piotr Osiewicz 128890db7c Piotr/optimize search selections with a limit (#2831)
/cc @nathansobo @maxbrunsfeld 

Release Notes:
- Fixed scrollbar selections causing noticeable slowdowns with large
quantities of selections.
2023-08-08 21:29:24 +02:00
Mikayla e377b3dedc Fix a bug where channel invitations would show up in the channels section
Block non-members from reading channel information
WIP: Make sure Arc::make_mut() works
2023-08-08 11:47:13 -07:00
Mikayla 6324f2fb6c Fix positioning on face piles, fix panic on member invite removal 2023-08-08 10:44:44 -07:00
Nathan Sobo 7416197a6e Return window handles from WeakItemHandle 2023-08-08 11:39:56 -06:00
Nathan Sobo 79da4b18a4 Move more window methods off AsyncAppContext 2023-08-08 11:38:07 -06:00
Nathan Sobo 3c7e84d573 Move debug_elements to AnyWindowHandle 2023-08-08 11:27:19 -06:00
Nathan Sobo 0b2865203b Remove window methods from AsyncAppContext 2023-08-08 11:23:49 -06:00
Nathan Sobo 11c1e225a0 Remove AsyncAppContext::remove_window 2023-08-08 11:22:43 -06:00
Nathan Sobo 729a5abbeb Remove unused dock code 2023-08-08 11:20:42 -06:00
Nathan Sobo f01d3b87e0 Remove more window id usage 2023-08-08 11:20:09 -06:00
Nathan Sobo e293985af9 Work with window handles instead of ids in drag code 2023-08-08 11:14:02 -06:00
Nathan Sobo c843749cb0 Store an AnyWindowHandle in WindowContext 2023-08-08 11:08:37 -06:00
Mikayla 434f9dc2e5 Fix tests 2023-08-08 10:04:29 -07:00
Nathan Sobo d03f2437e5 Remove window when closing workspace in test 2023-08-08 09:13:17 -06:00
Piotr Osiewicz c546e190d0 Move option button rendering to search_bar 2023-08-08 16:26:19 +02:00
Piotr Osiewicz 7f2d4abe4b Finish migration to modes for buffer search 2023-08-08 15:57:07 +02:00
Piotr Osiewicz b10245bdd3 Add modes to buffer search 2023-08-08 15:25:32 +02:00
Piotr Osiewicz a5af566ddf Move mode cycling to mode module 2023-08-08 15:20:34 +02:00
Piotr Osiewicz a56e6c1b85 Move mode rendering to a search_bar module 2023-08-08 15:11:32 +02:00
Piotr Osiewicz ab7a7b7918 Move nav buttons generation to search_bar 2023-08-08 14:56:21 +02:00
Piotr Osiewicz 87f8fa36a7 Remove SearchOptions::REGEX.
A bit WIP as it awaits migration of buffer search to modes
2023-08-08 14:42:11 +02:00
Piotr Osiewicz 3c71113730 Update keybinds to use new names 2023-08-08 14:33:51 +02:00
Piotr Osiewicz 4fda657efe Move ButtonSide to new module 2023-08-08 14:24:26 +02:00
Piotr Osiewicz eb2bfe55c4 Move SearchMode and SearchHistory to separate modules 2023-08-08 14:14:39 +02:00
Piotr Osiewicz 6daa812d5d Do not highlgiht selections at all over the threshold 2023-08-08 13:09:27 +02:00
Nathan Sobo a4836b25d6 Remove window via handles 2023-08-07 22:58:01 -06:00
Nathan Sobo 337db743e9 Remove TestAppContext::add_view
Instead, we now call this on window handles.
2023-08-07 22:46:48 -06:00
Nathan Sobo 29e16ae866 Remove unused method 2023-08-07 22:08:44 -06:00
Nathan Sobo 5bdfe4199e Merge remote-tracking branch 'origin/main' into window-handles 2023-08-07 22:07:20 -06:00
Nathan Sobo 8a187b0b25 Move window-related methods from TestAppContext to AnyWindowHandle 2023-08-07 20:23:04 -06:00
Nathan Sobo d72e27a4c2 Move activation simulation to AnyWindowHandle 2023-08-07 19:45:43 -06:00
Nathan Sobo ce33bd19e5 Get compiling 2023-08-07 19:08:58 -06:00
Max Brunsfeld 7d045ebb88 Change collab panel icon 2023-08-07 18:04:41 -07:00
Piotr Osiewicz 2afb207a6e Address review feedback.
Rename selected_rows to background_highlight_row_ranges.
Do not return any ranges if there are more than 50k results
2023-08-08 02:47:49 +02:00
Piotr Osiewicz 2287c07c9d Use display maps 2023-08-08 02:37:27 +02:00
Piotr Osiewicz 8863e75114 Remove redundant argument 2023-08-08 02:25:30 +02:00
Piotr Osiewicz 29465aa01a Add upper bound limit. Remove dbg! statements 2023-08-08 02:17:11 +02:00
Mikaylaandmax 2c2db5537d Tune UX for context menus
Co-authored-by: max <max@zed.dev>
2023-08-07 17:14:14 -07:00
Mikaylaandmax e5812b5c7f Improve local collaboration script to accept a zed impersonate
Gate channels UI behind a flag

co-authored-by: max <max@zed.dev>
2023-08-07 16:45:13 -07:00
Mikaylaandmax 8a7d078eaf Add settings for removing the assistant and collaboration panel buttons
Add a not-logged-in state to the collaboration panel

co-authored-by: max <max@zed.dev>
2023-08-07 16:27:47 -07:00
MikaylaandMax 9f1d025937 Add context menu controls to the channel member management
co-authored-by: Max <max@zed.dev>
2023-08-07 15:29:30 -07:00
Piotr Osiewicz 2b1b1be185 Do not query start of range if it's end is the same as the previous hunk's 2023-08-08 00:27:38 +02:00
Piotr Osiewicz d98ed0e958 Baseline: Improve selection rendering for large quantities from 270ms to 90ms 2023-08-07 23:32:27 +02:00
MikaylaandMax 06f40c814a Remove admin and member button
Fix bug with invites in the member list
Fix bug when there are network errors in the member related RPC calls

co-authored-by: Max <max@zed.dev>
2023-08-07 14:32:13 -07:00
Max Brunsfeld 8af441ec62 Make LspAdapter::process_diagnostics synchronous (#2829)
When editing rust code, the project diagnostics view sometimes fails to
update, so that you have to close the view and re-open it to see the
correct state.

This PR fixes one possible cause of that problem. There was an async
step in between *receiving* diagnostics from the language server and
updating the diagnostics, due to an async call to
`LspAdapter::process_diagnostics`. This could cause the following
sequence of events to happen:

1. Rust-analyzer sends us new diagnostics for a file `a.rs`
2. We call `process_diagnostics` with those diagnostics
3. Rust-analyzer sends us a `WorkDoneProgress` message, indicating that
the "flycheck" (aka `cargo check`) process has completed
4. We update the project diagnostics view due to this message.
5. The `process_diagnostics` call for `a.rs` completes
6. 💥 We have the new diagnostics for `a.rs`, but do not update the
project diagnostics view again.

This PR fixes this bug by simply making `process_diagnostics`
synchronous. There is no I/O or expensive computation happening in that
method. If we need to make it asynchronous in the future, we need to
introduce a queue that ensures that `publishDiagnostics` and
`workDoneProgress` messages are processed serially.

Release Notes:

- Fixed a bug where the project diagnostics view would sometimes fail to
update properly when using Rust-analyzer.
2023-08-07 14:31:49 -07:00
Joseph T. Lyons b8fe41ab50 Add syntax highlighting for Cargo.toml files 2023-08-07 17:24:22 -04:00
Joseph T. Lyons 71e10d21a5 Fix test name 2023-08-07 17:07:01 -04:00