Antonio Scandurra
74fe1a91de
Ensure workspace gets rendered in collab integration tests
2023-05-03 18:31:07 +02:00
Antonio Scandurra
ac7e73d494
Remove the ability to retrieve the view's parent
2023-05-03 16:52:55 +02:00
Antonio Scandurra
862cc2d132
Compute view ancestry at layout time
2023-05-03 16:36:14 +02:00
Antonio Scandurra
bd74322351
Separate Window::build_scene into layout and paint
2023-05-03 12:18:16 +02:00
Antonio Scandurra
2d0c647fac
Fix "IncomingCallNotification was dropped" error when accepting a call
...
This was caused by accepting the call, which caused the notification to
be removed. When `active_call.accept_incoming()` finally completed, we
would try to get the app state from it in order to join the project, but
couldn't becuase the view would have already been dropped.
This commit fixes the bug by capturing a weak handle to the app state
when accepting the call as opposed to trying to read it from the view
when the accept completes.
2023-05-03 10:37:57 +02:00
Antonio Scandurra
9b5ee9c01d
Merge pull request #2436 from zed-industries/close-window-end-call
...
Move methods querying window state into `AsyncAppContext`
2023-05-03 10:27:05 +02:00
Joseph Lyons
0eb35b39a7
Use post_json so that the Content-Type is set to application/json
2023-05-02 23:23:43 -04:00
Joseph Lyons
fc54c15077
Update post_json to take in a bool for allowing for redirects
2023-05-02 23:22:55 -04:00
Joseph Lyons
f06239dad4
Add download and upload metadata to update request
2023-05-02 17:16:42 -04:00
Kirill Bulatov and Antonio Scandurra
82ad598309
More keybindings in macOs modals with buttons
...
Closes https://github.com/zed-industries/community/issues/1095
by forcing the non-Cancel button to get a focus.
Due to the way macOs handles buttons on modals, the focus gain had to be
achieved via certain button addition order, rather than conventional
"setFocus"-ish API, see the related comment for details.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-05-02 21:10:20 +03:00
Antonio Scandurra
4e0ab2f8d0
Move methods querying window state into AsyncAppContext
2023-05-02 19:38:48 +02:00
Julia
8ac81321d9
Merge pull request #2432 from zed-industries/more-diagnostic-source
...
Show diagnostic source in more places
2023-05-02 09:16:11 -04:00
Julia
25e2016d0d
Show diagnostic source in inline diagnostic
2023-05-02 09:08:07 -04:00
Antonio Scandurra
1362dd6c98
Fix broken styling in contact finder
...
This regressed as part of #2372 , where we forgot to theme the contact
finder picker differently from the rest of the app.
2023-05-02 13:46:49 +02:00
Antonio Scandurra
8f63d0b3dd
Fix panic when showing contacts popover via keybinding
2023-05-02 11:47:05 +02:00
Antonio Scandurra
fe585ff99b
Move debug_elements to AsyncAppContext
...
Previously, `debug_elements` was available on `WindowContext`. If that
method was called while having a borrow out to a view, it would panic because
the view would already have been borrowed.
By moving it to an `AsyncAppContext` we ensure the method can't be called while
a view is being used.
2023-05-02 11:09:40 +02:00
Antonio Scandurra
69ebd00ce3
Remove unnecessary Element impl for RootElement
2023-05-02 10:09:57 +02:00
Julia
33173ad0ee
Show diagnostic source in diagnostic multibuffer headers
2023-05-01 16:48:27 -04:00
Max Brunsfeld
1486f1e91a
Add copilot.disabled_globs setting
2023-05-01 13:45:47 -07:00
Joseph T. Lyons
b3309b0f56
use installation_id over device_id
2023-05-01 16:29:51 -04:00
Julia
918093842b
Reduce hardcoded ESLint workspace configuration
2023-05-01 13:14:35 -04:00
Antonio Scandurra
cd0c231879
Defer hiding the dock and going back/forward when Pane is on the stack
2023-05-01 17:06:05 +02:00
Antonio Scandurra
3e757a5377
Run until parked now that the command palette spawns to dispatch action
2023-05-01 16:58:07 +02:00
Antonio Scandurra
98ca695c93
Inline test-only AppContext methods
2023-05-01 16:49:17 +02:00
Antonio Scandurra
48373ac54a
Move dispatch_action_any_action_at to AsyncAppContext
2023-05-01 16:40:57 +02:00
Antonio Scandurra
2742f1cb76
Remove ViewContext::dispatch_action
2023-05-01 16:27:36 +02:00
Antonio Scandurra
4bb90083cb
Remove ViewContext::dispatch_any_action
2023-05-01 14:24:00 +02:00
Antonio Scandurra
554ea1948e
Make dispatch_global_action private
2023-05-01 11:45:35 +02:00
Antonio Scandurra
b2b55aa687
Fix panic when clicking on a definition
...
This was introduced with #2420 and was caused by re-entrantly updating
the workspace. Instead of passing the workspace reference from the outside,
we now define the definition navigation as a method on the editor which solves
the issue.
Note that we also needed to introduce a `defer` call when navigating to a definition
to prevent the workspace from reading the editor during `open_project_item`.
2023-04-29 14:53:17 +02:00
Joseph T. Lyons
33934ca2c2
Merge pull request #2421 from zed-industries/metrics-2
...
Rework telemetry code to support sending events to Clickhouse
2023-04-28 17:16:33 -04:00
Julia
e0728c7789
Source ESLint server from Github rather than 3rd party NPM package
2023-04-28 16:42:36 -04:00
Joseph Lyons and Max Brunsfeld
deae3db26b
Rework telemetry code to support sending events to Clickhouse
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-04-28 16:06:55 -04:00
Antonio Scandurra
63e6eb45bb
Remove obsolete presenter modules
2023-04-28 17:37:25 +02:00
Antonio Scandurra
41b1cda801
Merge remote-tracking branch 'origin/main' into simplify-action-dispatch
2023-04-28 17:31:12 +02:00
Antonio Scandurra
eb20613772
Remove impl_internal_actions macro
2023-04-28 17:29:57 +02:00
Antonio Scandurra
9182eb0b1d
Remove internal actions from terminal_button
2023-04-28 17:29:17 +02:00
Antonio Scandurra
236937fa3e
Remove internal actions from project_panel
2023-04-28 17:21:10 +02:00
Antonio Scandurra
a6c394f720
Remove DeployContextMenu internal action
2023-04-28 16:51:01 +02:00
Antonio Scandurra
77770d3c82
Remove Scroll internal action
2023-04-28 16:43:31 +02:00
Antonio Scandurra and Nathan Sobo
91a4913075
Remove DeployMouseContextMenu internal action
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-28 16:41:46 +02:00
Antonio Scandurra and Nathan Sobo
d7231f63c6
💄
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-28 16:38:00 +02:00
Antonio Scandurra and Nathan Sobo
addccba272
Remove internal actions from copilot_button
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-28 16:36:57 +02:00
Antonio Scandurra
be095238e0
Remove internal actions from link_go_to_definition
2023-04-28 16:24:46 +02:00
Antonio Scandurra
279094ec8b
Remove HideHover and HoverAt internal actions
2023-04-28 16:12:24 +02:00
Antonio Scandurra
21b1a32fa6
Remove unused Jump internal action
2023-04-28 15:57:36 +02:00
Antonio Scandurra
481eab0c9e
Remove Dismiss and RespondToContactRequest internal actions
2023-04-28 15:56:41 +02:00
Antonio Scandurra
e6785c91d5
Remove LeaveCall internal action
2023-04-28 14:14:25 +02:00
Antonio Scandurra
6b87c371f9
Remove Jump internal action
2023-04-28 14:13:07 +02:00
Antonio Scandurra
1334855566
Fix panic due to re-entrantly reading Workspace
2023-04-28 12:36:50 +02:00
Antonio Scandurra
b9a764a22b
Remove Select internal action
2023-04-28 12:33:22 +02:00
Antonio Scandurra