Antonio Scandurra
e062c97b68
WIP: accept to join requests if user is already participating
...
There's a panic caused by `Store::check_invariants` that we still
need to figure out.
2022-05-17 13:21:20 +02:00
Antonio Scandurra
70d91a0cff
Hold a weak handle to Presenter when dispatching events
...
This ensures that the only strong reference to the presenter is held
by `App`. This is important because we want to call `flush_effects`
when removing a window and implicit drops of the `Presenter` would
make that hard.
Before this commit, if a rendered view contained strong handles to
views and models, we would only drop them on the next `flush_effects`.
This was manifesting itself in `Project`s not being released when
closing their containing window.
2022-05-17 13:04:38 +02:00
Antonio Scandurra
3bc2358e17
Send LeaveProject when waiting room is dismissed while waiting
2022-05-17 11:25:14 +02:00
Nathan Sobo
6be7161888
Cancel join requests when the requester closes the window
2022-05-16 20:29:36 -06:00
Nathan Sobo
30a1f0275b
Refine messages on waiting to join screen and include host avatar
2022-05-16 16:52:31 -06:00
Nate Butler and Keith Simmons
e9137fa0b1
Rework color schemes
...
Co-Authored-By: Keith Simmons <keith@the-simmons.net >
2022-05-16 18:11:22 -04:00
Nathan Sobo
9620e6e77b
Remove "They won't know if you decline" message
2022-05-16 13:15:46 -06:00
Antonio Scandurra and Nathan Sobo
1738d4dbbe
Show the reason why a join request was declined
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-05-16 19:57:50 +02:00
Antonio Scandurra
5733963edc
WIP: decline pending join requests when project is unregistered
2022-05-16 17:46:08 +02:00
Antonio Scandurra
5509d7192e
Display a temporary window while remote project is loading
2022-05-16 17:45:50 +02:00
Antonio Scandurra
9cff0a822b
Don't show "they won't know if you decline" when request is accepted
2022-05-16 15:37:29 +02:00
Antonio Scandurra
a6a9aa6dc3
Uncomment randomized tests for contacts
2022-05-16 15:13:32 +02:00
Antonio Scandurra
06e988c231
Poll snapshot after refreshing entry
2022-05-16 11:50:21 +02:00
Antonio Scandurra
121611cbc7
Grab share state after retrieving metadata when refreshing entry
2022-05-16 11:46:49 +02:00
Antonio Scandurra
1373403134
Delete commented-out code
2022-05-16 09:50:36 +02:00
Antonio Scandurra
aa6d96a26d
Initialize UserStore before client connects in integration tests
...
This fixes a failure in `test_contacts` where we were receiving the
initial `proto::UpdateContacts` message before `UserStore` had a chance
to register a message handler for it.
2022-05-16 09:48:24 +02:00
Max Brunsfeld
5d563459e7
WIP - update worktree's scan_id when mutating it in the foreground
2022-05-13 17:03:48 -07:00
Keith Simmons
b03abdb6df
Reduce accessibility of multibuffer read to reduce risk of borrowing snapshot and buffer refcells twice
2022-05-13 16:58:30 -07:00
Keith Simmons
157de669ae
Merge pull request #973 from zed-industries/selections-refactor
...
Pull selections out of editor into selections collection
2022-05-13 16:07:26 -07:00
Keith Simmons
9bb347b513
Review fixes
2022-05-13 15:55:27 -07:00
Keith Simmons
07ccf7c74b
minor tweaks to selections collection api
2022-05-13 15:55:27 -07:00
Keith Simmons
c95f74648a
Rename selected_ranges and selected_display_ranges to remove redundant selected
2022-05-13 15:55:27 -07:00
Keith Simmons
2a984285a2
store buffer and display_map model handles on selections collection
2022-05-13 15:55:27 -07:00
Keith Simmons
851e04d46b
Passing tests and removed local argument. Also pulled autoscroll argument out to change_selections
2022-05-13 15:55:27 -07:00
Keith Simmons
9b46bb0ee6
Move selection helpers to SelectionCollection, add update_anchor_selections, add a number of invariant preserving mutation functions to the MutableSelectionCollection
2022-05-13 15:55:17 -07:00
Max Brunsfeld
2afcbe8b63
Send RemoveProjectCollaborator to host in addition to ProjectUnshared
2022-05-13 15:04:48 -07:00
Max Brunsfeld
4f473eba7a
Tell host to unshare project when last guest leaves
2022-05-13 14:57:55 -07:00
Nathan Sobo
f754614157
Only synthesize mouse moves on scene construction if window is active
2022-05-13 14:05:13 -06:00
Antonio Scandurra and Nathan Sobo
b8383deda2
Fix randomized test failure caused by unsharing while guest was joining
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-05-13 17:39:13 +02:00
Antonio Scandurra and Nathan Sobo
b3fc910632
Make Project::share and Project::unshare private
...
This is still in-progress because randomized tests are failing.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-05-13 17:17:20 +02:00
Max Brunsfeld and Nathan Sobo
8d00fab9b1
Start work on requesting to join projects
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-05-12 17:53:11 -07:00
Nathan Sobo
e3ecfaeb02
0.33.0
2022-05-12 14:46:33 -06:00
Nathan Sobo
a897e2318b
Merge pull request #990 from zed-industries/more-tracing
...
Improve tracing support
2022-05-12 14:45:50 -06:00
Nathan Sobo
e0cc0b833e
Try to improve tracing messages when client disconnects
2022-05-12 13:05:05 -06:00
Nathan Sobo
9f2b29550d
Include login in connection-related tracing spans/events
...
Also, include metadata on more events and add an event called "signing out" with all this metadata to make it easier to search for.
2022-05-12 12:06:06 -06:00
Nathan Sobo
d96cc06c5b
Remove commented method
2022-05-12 11:37:33 -06:00
Max Brunsfeld and Antonio Scandurra
7a93292dfa
Select the first contact when changing the filter in the contacts panel
...
Co-authored-by: Antonio Scandurra <me@as-cii.com >
2022-05-12 09:56:32 -07:00
81ce10b180
Enable logging of rpc crate trace events when no subscriber is present
...
This allows these events to be logged in the Zed client (until we setup tracing there).
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2022-05-12 10:17:37 -06:00
0207fa49fc
💄
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2022-05-12 10:16:50 -06:00
Nathan Sobo and Antonio Scandurra
4ba72c3243
Use tracing instead of log in collab and rpc crates
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-05-12 10:05:49 -06:00
Nathan Sobo and Antonio Scandurra
925c002a90
WIP: Enhance tracing in Peer
...
- Add a bunch of events to Peer's async connection handling logic
- Use an EnvFilter to allow more control over the verbosity level of tracing on a per-module basis
- Wire up logging to emit trace events (we actually probably want to do this the other way around)
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-05-12 09:58:17 -06:00
Antonio Scandurra
33c6c80b7e
Use cmd-9 and cmd-shift-9 to toggle contacts panel focus/visibility
2022-05-12 12:11:27 +02:00
Antonio Scandurra
390cfb341a
Allow toggling sections in contacts panel by clicking on them
2022-05-12 11:48:11 +02:00
Max Brunsfeld
00af7d0273
Merge branch 'main' into contact-panel-keyboard-nav
2022-05-11 17:45:44 -07:00
Max Brunsfeld
c1d76112bd
Merge pull request #987 from zed-industries/notifications
...
Notify when someone requests to add you as a contact or accepts your contact request
2022-05-11 17:40:11 -07:00
Max Brunsfeld
957a220899
Add the ability to expand and collapse sections of the contacts panel
...
Also, allow joining projects using the keyboard.
2022-05-11 17:28:35 -07:00
Max Brunsfeld and Nathan Sobo
afd6eaed3f
Rework the contact panel's styling to allow keyboard navigation
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-05-11 16:50:51 -07:00
Max Brunsfeld
d8c19a7a2b
Fix bug where Contacts included projects for which the use was a guest
2022-05-11 16:49:56 -07:00
Max Brunsfeld and Nathan Sobo
449e7d69cb
Improve layout and styling of contact notifications
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-05-11 14:20:05 -07:00
Max Brunsfeld and Nathan Sobo
0a1ca3dfc5
Add notifications for accepted contact requests
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-05-11 11:39:01 -07:00
Antonio Scandurra