Antonio Scandurra and Nathan Sobo
dae6a540b5
Hold strong handle in ChildView
...
This eliminates a whole class of errors where the `ChildView` could
be referring to a view that doesn't exist anymore. That probably still
indicates that there's an underlying bug, but at least we won't panic.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-14 15:49:11 +01:00
Antonio Scandurra and Nathan Sobo
88ac3564de
Re-render workspace when removing an inactive pane
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-14 15:49:08 +01:00
Antonio Scandurra and Nathan Sobo
351477793b
Don't draw scene elements if their size is zero
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-14 15:29:18 +01:00
Max Brunsfeld
836480a3e3
Merge branch 'main' into settings-file
2022-03-13 10:43:23 -07:00
Antonio Scandurra
b348cc77ee
Merge pull request #596 from zed-industries/fix/dropped-subscription-in-callback
...
Fix Dropped Subscription in Handler Bug
2022-03-12 19:14:38 +01:00
Nathan Sobo and Antonio Scandurra
7027cec1a9
Hide selections in original editor when renaming
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-03-12 10:45:11 -07:00
Nathan Sobo and Antonio Scandurra
a93bdc4538
🙊
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-03-12 10:44:11 -07:00
Nathan Sobo and Antonio Scandurra
795b6344da
Improve selection handling when pending rename is taken
...
- Set selection to the intuitive cursor position when moving up rather than restoring the full selection of the rename editor.
- When cancelling, restore the original selection.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-03-12 10:30:57 -07:00
Nathan Sobo
ea7f2b309d
Merge remote-tracking branch 'origin/main' into select-on-rename
2022-03-12 10:10:23 -07:00
Nathan Sobo and Antonio Scandurra
f1881795f4
Refresh document highlight after rename, but not during
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-03-12 10:10:06 -07:00
Antonio Scandurra
682ac9d92c
Merge pull request #589 from zed-industries/fold-map-test-failures
...
Avoid re-using excerpt IDs in `MultiBuffer`
2022-03-12 17:59:48 +01:00
Antonio Scandurra
c3ac7e639b
Account for all excerpts ever inserted when determining new excerpt ID
2022-03-12 17:50:09 +01:00
Antonio Scandurra
4ee1f2dfc4
Fix bug in selection position maintenance while renaming symbol
...
We were resolving the selection with the wrong buffer, which now
causes a panic because we don't check the anchor's `buffer_id` anymore.
2022-03-12 13:03:45 +01:00
Max Brunsfeld
839a7f8782
Start work on relaying settings to language servers
2022-03-11 17:36:27 -08:00
Max Brunsfeld
d2a4b6888c
Store settings as a global via a gpui app_state
2022-03-11 15:58:58 -08:00
Keith Simmons
3780ef3840
Format including missing formatting changes from previous PR
2022-03-11 15:38:01 -08:00
Keith Simmons
727188bbd2
Add some tests for global events and fix potential bug in subscriptions when subscription is dropped inside of it's own callback
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-03-11 15:34:04 -08:00
Nathan Sobo
f2451665af
On rename, replace background highlights with transparent text highlights
2022-03-11 15:54:17 -07:00
Nathan Sobo
2c6d8e9d65
Merge branch 'main' into select-on-rename
2022-03-11 15:30:07 -07:00
Max Brunsfeld
906e647702
Allow registering handlers for typed LSP requests
2022-03-11 13:19:10 -08:00
Max Brunsfeld
1f0b778e85
Add a snippet unit test with an escaped curly brace
2022-03-11 13:02:20 -08:00
Keith Simmons and Max Brunsfeld
1c794540cb
Merge pull request #576 from zed-industries/cursor-shape
...
Add support for rendering the cursor as a Block and Underscore
Co-authored-by: Max Brunsfeld <max@zed.dev >
2022-03-11 11:51:24 -08:00
Max Brunsfeld
62c3c6b290
Provide JSON language server with settings schema
2022-03-11 11:46:22 -08:00
Max Brunsfeld
780c0207c2
Add API for handling custom requests from the language server
2022-03-11 11:44:02 -08:00
Keith Simmons and Max Brunsfeld
c6af58835f
Merge pull request #586 from zed-industries/global-events
...
Global Events
Co-authored-by: Max Brunsfeld <nathan@zed.dev >
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-03-11 11:42:25 -08:00
Keith Simmons
15dea6ede0
Minor renames for clarity
2022-03-11 11:25:36 -08:00
Max Brunsfeld
7f3b4aa41e
Merge branch 'main' into settings-file
2022-03-11 10:04:17 -08:00
Max Brunsfeld
4589f2a5ac
Handle escaped characters in snippets
2022-03-11 09:57:43 -08:00
Nathan Sobo
88d05db936
Merge pull request #587 from zed-industries/lsp-progress
...
Show language server progress in the status bar
2022-03-11 10:57:24 -07:00
Antonio Scandurra
f74035bd29
💄
2022-03-11 17:13:28 +01:00
Antonio Scandurra
1a5f0456e6
Assume the anchor is valid if we can find an excerpt that contains it
2022-03-11 17:08:12 +01:00
Nathan Sobo and Antonio Scandurra
c598628f94
Don't reuse excerpt ids in MultiBuffer
...
This prevents anchors from swapping their ordering, which was causing issues in FoldMap.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-03-11 08:50:50 -07:00
Nathan Sobo and Antonio Scandurra
0db6f31d02
Remove dead code
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2022-03-11 08:24:42 -07:00
Antonio Scandurra
092abbe39b
Respect excerpt's range when comparing two anchors both belonging to it
2022-03-11 12:42:22 +01:00
Antonio Scandurra
583377a39d
Don't starve main thread when lots of messages/events arrive at once
2022-03-11 10:09:13 +01:00
Antonio Scandurra
6454b09051
Show the last in-progress task from language servers
2022-03-11 09:59:13 +01:00
Keith Simmons
fb3d7986cb
Add unwrap check if buffer_line not available
2022-03-10 20:04:16 -08:00
Keith Simmons
a3270225fb
Add global events to MutableAppContext and raise global event when new workspace is created
2022-03-10 20:03:01 -08:00
Keith Simmons
ce78fcac2a
Merge pull request #563 from zed-industries/mouse-history-navigation
...
Add missing mouse button events and mouse history navigation
2022-03-10 17:39:36 -08:00
Max Brunsfeld
e7e4393088
Create the settings file if needed when opening it via command
2022-03-10 17:27:46 -08:00
Max Brunsfeld
73f2271071
For single-file worktrees start LSP with parent dir as CWD
2022-03-10 16:06:12 -08:00
Max Brunsfeld
f89dacc086
Add cmd-, as a keybinding for opening settings
2022-03-10 15:51:57 -08:00
Nathan Sobo
eddd356051
Focus in-progress rename editor when editor is focused
2022-03-10 16:42:20 -07:00
Nathan Sobo
fe88d384a5
When renaming, match the color of the renamed token in the rename editor
2022-03-10 16:38:45 -07:00
Max Brunsfeld
78e2e01e42
Always refresh the windows when the settings change
2022-03-10 15:34:04 -08:00
Max Brunsfeld
81ad32ba1e
Load the settings file on a background thread during startup
2022-03-10 15:25:22 -08:00
Nathan Sobo
799d1c90cb
Remove unused variable
2022-03-10 15:27:29 -07:00
Nathan Sobo
ebdba1d0c8
When renaming, fade out the old name and select all
2022-03-10 14:55:31 -07:00
Keith Simmons
7ff8aa152f
swap default cursor shape back to bar
2022-03-10 13:28:13 -08:00
Keith Simmons
40518148e1
Fix failing gpui test from missing cursor shape
2022-03-10 13:20:45 -08:00
