Marshall Bowers
bce6b9b886
Enable clippy::option_as_ref_deref ( #8747 )
...
This PR enables the
[`clippy::option_as_ref_deref`](https://rust-lang.github.io/rust-clippy/master/index.html#/option_as_ref_deref )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 21:36:42 -05:00
Marshall Bowers
32c917ccb7
Enable clippy::needless_borrowed_reference ( #8746 )
...
This PR enables the
[`clippy::needless_borrowed_reference`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrowed_reference )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 21:24:56 -05:00
Marshall Bowers
f2686cf443
Enable clippy::drain_collect ( #8745 )
...
This PR enables the
[`clippy::drain_collect`](https://rust-lang.github.io/rust-clippy/master/index.html#/drain_collect )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 21:14:42 -05:00
Marshall Bowers
e2fe71fbbc
Enable clippy::needless_arbitrary_self_type ( #8743 )
...
This PR enables the
[`clippy::needless_arbitrary_self_type`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_arbitrary_self_type )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 21:04:49 -05:00
Marshall Bowers
16e365ec42
Enable clippy::unit_arg ( #8742 )
...
This PR enables the
[`clippy::unit_arg`](https://rust-lang.github.io/rust-clippy/master/index.html#/unit_arg )
rule and suppresses the false positive that it flags.
Release Notes:
- N/A
2024-03-02 20:59:41 -05:00
Marshall Bowers
d88c1ee8c8
Enable clippy::filter_map_identity ( #8741 )
...
This PR enables the
[`clippy::filter_map_identity`](https://rust-lang.github.io/rust-clippy/master/index.html#/filter_map_identity )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 20:48:29 -05:00
Marshall Bowers
0b8b723044
Enable clippy::unnecessary_find_map ( #8740 )
...
This PR enables the
[`clippy::unnecessary_find_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_find_map )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 20:39:03 -05:00
Marshall Bowers
e14f6b0b26
Enable clippy::manual_flatten ( #8739 )
...
This PR enables the
[`clippy::manual_flatten`](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_flatten )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 20:28:26 -05:00
Marshall Bowers
1d80e76963
Enable clippy::unnecessary_filter_map ( #8738 )
...
This PR enables the
[`clippy::unnecessary_filter_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_filter_map )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 20:16:54 -05:00
Marshall Bowers
cf81943b17
Enable clippy::manual_find ( #8737 )
...
This PR enables the
[`clippy::manual_find`](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_find )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 20:03:49 -05:00
Marshall Bowers
9da3eef9e1
Enable clippy::too_many_arguments ( #8734 )
...
This PR enables the
[`clippy::too_many_arguments`](https://rust-lang.github.io/rust-clippy/master/index.html#/too_many_arguments )
rule.
I opted to add `#[allow(clippy::too_many_arguments)]` on the individual
violations, as reworking them to take fewer arguments is a more involved
task.
Release Notes:
- N/A
2024-03-02 18:42:05 -05:00
Marshall Bowers
6a762a2517
Enable clippy::map_flatten ( #8733 )
...
This PR enables the
[`clippy::map_flatten`](https://rust-lang.github.io/rust-clippy/master/index.html#/map_flatten )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 18:24:22 -05:00
Marshall Bowers
cd772439f4
Enable clippy::to_string_in_format_args ( #8732 )
...
This PR enables the
[`clippy::to_string_in_format_args`](https://rust-lang.github.io/rust-clippy/master/index.html#/to_string_in_format_args )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 18:13:49 -05:00
Marshall Bowers
74876d90b8
Enable clippy::map_identity ( #8731 )
...
This PR enables the
[`clippy::map_identity`](https://rust-lang.github.io/rust-clippy/master/index.html#/map_identity )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 18:02:39 -05:00
Marshall Bowers
86e31db1fb
Enable clippy::clone_on_copy ( #8728 )
...
This PR enables the
[`clippy::clone_on_copy`](https://rust-lang.github.io/rust-clippy/master/index.html#/clone_on_copy )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 17:37:48 -05:00
Marshall Bowers
c27546f5f3
Enable clippy::single_char_pattern ( #8727 )
...
This PR enables the
[`clippy::single_char_pattern`](https://rust-lang.github.io/rust-clippy/master/index.html#/single_char_pattern )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 17:04:59 -05:00
Marshall Bowers
aea1b34132
Enable clippy::useless_conversion ( #8724 )
...
This PR enables the
[`clippy::useless_conversion`](https://rust-lang.github.io/rust-clippy/master/index.html#/useless_conversion )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 16:31:47 -05:00
Marshall Bowers
a1af22aedd
Enable clippy::bind_instead_of_map ( #8723 )
...
This PR enables the
[`clippy::bind_instead_of_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/bind_instead_of_map )
rule and fixes the outstanding violations.
Release Notes:
- N/A
2024-03-02 16:10:34 -05:00
Marshall Bowers
e4ed7fc1ba
Deny all Clippy warnings ( #8720 )
...
This PR makes Clippy deny all warnings across the workspace.
We now enumerate all of the rules that have violations and temporarily
allow them, with the goal being to drive the list down over time.
On Windows we don't yet use `--deny warnings`, as the Windows build
still has some warnings.
Release Notes:
- N/A
2024-03-02 15:51:01 -05:00
Marshall Bowers
bfd2c0b7ec
Add cargo xtask clippy ( #8722 )
...
This PR sets up a `cargo xtask clippy` command for running `cargo
clippy` with our defined set of options.
The intent is to make this easier to manage as we start enabling more
Clippy rules.
Release Notes:
- N/A
2024-03-02 14:46:02 -05:00