yenru0/zed
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
39,175 Commits 5 Branches 0 Tags
fbda4f862a2fb03b854636b17bd04be3db3d94de
Commit Graph
39175 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Marshall Bowers 6b71baa54e Enable clippy::unnecessary_unwrap (#8756) 
This PR enables the
[`clippy::unnecessary_unwrap`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_unwrap)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 23:10:56 -05:00
Marshall Bowers 8e9a4ce6eb Enable clippy::nonminimal_bool (#8755) 
This PR enables the
[`clippy::nonminimal_bool`](https://rust-lang.github.io/rust-clippy/master/index.html#/nonminimal_bool)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 22:57:37 -05:00
Marshall Bowers 7e05bb450a Enable clippy::extra_unused_lifetimes (#8754) 
This PR enables the
[`clippy::extra_unused_lifetimes`](https://rust-lang.github.io/rust-clippy/master/index.html#/extra_unused_lifetimes)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 22:43:00 -05:00
Marshall Bowers ffd5c6c26d Enable clippy::explicit_auto_deref (#8753) 
This PR enables the
[`clippy::explicit_auto_deref`](https://rust-lang.github.io/rust-clippy/master/index.html#/explicit_auto_deref)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 22:30:18 -05:00
Marshall Bowers 09c78c6bc3 Enable clippy::unnecessary_operation (#8752) 
This PR enables the
[`clippy::unnecessary_operation`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_operation)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 22:19:56 -05:00
Marshall Bowers 085c7f1179 Enable clippy::option_map_unit_fn (#8751) 
This PR enables the
[`clippy::option_map_unit_fn`](https://rust-lang.github.io/rust-clippy/master/index.html#/option_map_unit_fn)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 22:08:37 -05:00
Marshall Bowers af6e97049b Enable clippy::redundant_locals (#8750) 
This PR enables the
[`clippy::redundant_locals`](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_locals)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 21:57:40 -05:00
Marshall Bowers e977db6b94 Enable clippy::search_is_some (#8748) 
This PR enables the
[`clippy::search_is_some`](https://rust-lang.github.io/rust-clippy/master/index.html#/search_is_some)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 21:46:30 -05:00
Marshall Bowers bce6b9b886 Enable clippy::option_as_ref_deref (#8747) 
This PR enables the
[`clippy::option_as_ref_deref`](https://rust-lang.github.io/rust-clippy/master/index.html#/option_as_ref_deref)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 21:36:42 -05:00
Marshall Bowers 32c917ccb7 Enable clippy::needless_borrowed_reference (#8746) 
This PR enables the
[`clippy::needless_borrowed_reference`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrowed_reference)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 21:24:56 -05:00
Marshall Bowers f2686cf443 Enable clippy::drain_collect (#8745) 
This PR enables the
[`clippy::drain_collect`](https://rust-lang.github.io/rust-clippy/master/index.html#/drain_collect)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 21:14:42 -05:00
Marshall Bowers e2fe71fbbc Enable clippy::needless_arbitrary_self_type (#8743) 
This PR enables the
[`clippy::needless_arbitrary_self_type`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_arbitrary_self_type)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 21:04:49 -05:00
Marshall Bowers 16e365ec42 Enable clippy::unit_arg (#8742) 
This PR enables the
[`clippy::unit_arg`](https://rust-lang.github.io/rust-clippy/master/index.html#/unit_arg)
rule and suppresses the false positive that it flags.

Release Notes:

- N/A
 2024-03-02 20:59:41 -05:00
Marshall Bowers d88c1ee8c8 Enable clippy::filter_map_identity (#8741) 
This PR enables the
[`clippy::filter_map_identity`](https://rust-lang.github.io/rust-clippy/master/index.html#/filter_map_identity)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 20:48:29 -05:00
Marshall Bowers 0b8b723044 Enable clippy::unnecessary_find_map (#8740) 
This PR enables the
[`clippy::unnecessary_find_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_find_map)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 20:39:03 -05:00
Marshall Bowers e14f6b0b26 Enable clippy::manual_flatten (#8739) 
This PR enables the
[`clippy::manual_flatten`](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_flatten)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 20:28:26 -05:00
Marshall Bowers 1d80e76963 Enable clippy::unnecessary_filter_map (#8738) 
This PR enables the
[`clippy::unnecessary_filter_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_filter_map)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 20:16:54 -05:00
Marshall Bowers cf81943b17 Enable clippy::manual_find (#8737) 
This PR enables the
[`clippy::manual_find`](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_find)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 20:03:49 -05:00
Marshall Bowers 9da3eef9e1 Enable clippy::too_many_arguments (#8734) 
This PR enables the
[`clippy::too_many_arguments`](https://rust-lang.github.io/rust-clippy/master/index.html#/too_many_arguments)
rule.

I opted to add `#[allow(clippy::too_many_arguments)]` on the individual
violations, as reworking them to take fewer arguments is a more involved
task.

Release Notes:

- N/A
 2024-03-02 18:42:05 -05:00
Marshall Bowers 6a762a2517 Enable clippy::map_flatten (#8733) 
This PR enables the
[`clippy::map_flatten`](https://rust-lang.github.io/rust-clippy/master/index.html#/map_flatten)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 18:24:22 -05:00
Marshall Bowers cd772439f4 Enable clippy::to_string_in_format_args (#8732) 
This PR enables the
[`clippy::to_string_in_format_args`](https://rust-lang.github.io/rust-clippy/master/index.html#/to_string_in_format_args)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 18:13:49 -05:00
Marshall Bowers 74876d90b8 Enable clippy::map_identity (#8731) 
This PR enables the
[`clippy::map_identity`](https://rust-lang.github.io/rust-clippy/master/index.html#/map_identity)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 18:02:39 -05:00
Marshall Bowers 86c7f0bd1d Add license to Gleam extension (#8730) 
This PR adds a license to the Gleam extension crate, since the bundling
script was unhappy that it didn't have one.

Since extensions like this one may ultimately live outside of Zed
itself, I went with the Apache 2.0 license.

Release Notes:

- N/A
 2024-03-02 17:56:57 -05:00
Marshall Bowers 86e31db1fb Enable clippy::clone_on_copy (#8728) 
This PR enables the
[`clippy::clone_on_copy`](https://rust-lang.github.io/rust-clippy/master/index.html#/clone_on_copy)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 17:37:48 -05:00
Marshall Bowers c27546f5f3 Enable clippy::single_char_pattern (#8727) 
This PR enables the
[`clippy::single_char_pattern`](https://rust-lang.github.io/rust-clippy/master/index.html#/single_char_pattern)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 17:04:59 -05:00
Marshall Bowers a11aa6682c terminal: Make rgb_for_index take a u8 instead of a &u8 (#8726) 
This PR makes the `rgb_for_index` take a `u8` instead of a `&u8`.

`u8` is `Copy` and is only 1 byte, so there really isn't any reason to
pass a reference to it.

Release Notes:

- N/A
 2024-03-02 16:51:46 -05:00
Marshall Bowers aea1b34132 Enable clippy::useless_conversion (#8724) 
This PR enables the
[`clippy::useless_conversion`](https://rust-lang.github.io/rust-clippy/master/index.html#/useless_conversion)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 16:31:47 -05:00
Marshall Bowers a1af22aedd Enable clippy::bind_instead_of_map (#8723) 
This PR enables the
[`clippy::bind_instead_of_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/bind_instead_of_map)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 16:10:34 -05:00
Marshall Bowers e4ed7fc1ba Deny all Clippy warnings (#8720) 
This PR makes Clippy deny all warnings across the workspace.

We now enumerate all of the rules that have violations and temporarily
allow them, with the goal being to drive the list down over time.

On Windows we don't yet use `--deny warnings`, as the Windows build
still has some warnings.

Release Notes:

- N/A
 2024-03-02 15:51:01 -05:00
Marshall Bowers bfd2c0b7ec Add cargo xtask clippy (#8722) 
This PR sets up a `cargo xtask clippy` command for running `cargo
clippy` with our defined set of options.

The intent is to make this easier to manage as we start enabling more
Clippy rules.

Release Notes:

- N/A
 2024-03-02 14:46:02 -05:00
Marshall Bowers 0c3b391ba8 Fix Clippy warnings in util crate (#8721) 
This PR fixes a number of Clippy warnings in the `util` crate.

Release Notes:

- N/A
 2024-03-02 13:06:35 -05:00
Marshall Bowers 2244ed4b0f Fix Clippy warnings in client crate (#8719) 
This PR fixes a number of Clippy warnings in the `client` crate.

Release Notes:

- N/A
 2024-03-02 12:33:02 -05:00
Tommi Pisto e40381a3a1 Add flex_wrap_* and content_* to GPUI (#8710) 
Now with GPUI you can auto-layout something like this:

<img width="560" alt="Screenshot 2024-03-02 at 13 56 50"
src="https://github.com/zed-industries/zed/assets/226244/8ec4b683-dd7d-41f8-8b09-4be66ecec9a0">
 2024-03-02 11:29:44 -05:00
Marshall Bowers b5832f8e53 Fix Clippy warnings in theme crate (#8715) 
This PR fixes a number of Clippy warnings in the `theme` crate.

Release Notes:

- N/A
 2024-03-02 11:11:08 -05:00
Zephaniah Ong 12e40053cc Expose more errors from rust-analyzer on invalid Cargo.toml contents (#8356) 
Release Notes:

- Fixed ([#7574](https://github.com/zed-industries/zed/issues/7574)).
 2024-03-02 10:07:25 +02:00
Liam Murphy 9390247645 Fix unsafe precondition violation when building with nightly rustc (#8691) 
Fixes #8658

Release Notes:

- N/A
 2024-03-02 08:01:44 +01:00
Marshall Bowers ceab9f0906 Fix Clippy warnings in fuzzy crate (#8701) 
This PR fixes a number of Clippy warnings in the `fuzzy` crate.

Release Notes:

- N/A
 2024-03-02 01:02:34 -05:00
Marshall Bowers 1af163fd01 Remove unneeded 'static lifetimes on &strs in constants (#8698) 
This PR removes unneeded `'static` lifetimes on `&str`s stored in
`const` declarations.

This addresses some Clippy lints about
[`redundant_static_lifetimes`](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_static_lifetimes).

In item-level `const` declarations we can rely on lifetime elision and
use the default `'static` lifetime.

Note that associated constants still require an explicit `'static`
lifetime, as explained in
https://github.com/rust-lang/rust/issues/115010.

Release Notes:

- N/A
 2024-03-02 00:40:49 -05:00
Marshall Bowers d1aed45705 Fix Clippy warnings in settings crate (#8700) 
This PR fixes a number of Clippy warnings in the `settings` crate.

Release Notes:

- N/A
 2024-03-02 00:29:29 -05:00
Marshall Bowers 7e4203173f Fix Clippy warnings in fs (#8696) 
This PR fixes various Clippy warnings in the `fs` crate.

Release Notes:

- N/A
 2024-03-01 23:22:22 -05:00
Marshall Bowers b59c1cf14e Remove expects when constructing Clickhouse client (#8697) 
This PR removes the `expect`s when constructing the Clickhouse client
while still retaining the less-noisy behavior from before.

Release Notes:

- N/A
 2024-03-01 23:10:02 -05:00
Marshall Bowers 72e6b054a5 Document release_channel crate (#8695) 
This PR documents the `release_channel` crate.

Release Notes:

- N/A
 2024-03-01 22:05:46 -05:00
Marshall Bowers 9fce47e25d Use long flags in script/clippy for readability (#8694) 
This PR modifies the `script/clippy` script to use long flags, as these
are better for readability.

Release Notes:

- N/A
 2024-03-01 21:25:06 -05:00
Marshall Bowers 51263689a8 Upgrade bitflags to v2.4.2 (#8693) 
This PR upgrades our [`bitflags`](https://crates.io/crates/bitflags)
dependency to v2.4.2.

This also fixes an error that was seen when running `clippy`:

```
error: &-masking with zero
  --> crates/fsevent/src/fsevent.rs:19:1
   |
19 | / bitflags! {
20 | |   #[repr(C)]
21 | |   pub struct StreamFlags: u32 {
22 | |     const NONE = 0x00000000;
...  |
46 | |   }
47 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask
   = note: `#[deny(clippy::bad_bit_mask)]` on by default
   = note: this error originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info)
```

Fixes #8681.

Release Notes:

- N/A
 2024-03-01 21:07:39 -05:00
Marshall Bowers 6e53ffdaa6 Allow overriding player colors via experimental.theme_overrides (#8692) 
This PR extends the `experimental.theme_overrides` to allow overriding
the player colors.

Release Notes:

- Added the ability to override player colors using
`experimenta.theme_overrides`.
 2024-03-01 20:33:37 -05:00
Brian Donovan c7fdf01166 docs: Fix "it's" typos that should be "its" (#8690) 
These all meant to use the possessive "its" rather than the contraction
of "it is".
 2024-03-01 20:32:27 -05:00
aryal 2ee78cd203 Add Void Linux support to script/linux (#8664) 
add support for the xbps package manager in the system library setup
script
 2024-03-01 16:47:59 -08:00
Dzmitry Malyshau 4bd80f767a Clean up and refactor X11 refresh loop (alternative) (#8655) 
Associates every window with its own refresh event. Removes the use of
X11 present.
Alternative to #8592.
Instead of doing the rendering on idle and then involving a hack for
polling X11 events, this PR just tries to do the rendering inside the
main loop. This guarantees that we continue to poll for events after the
draw, and not get screwed by the driver talking to X11 via the same file
descriptor.

Release Notes:
- N/A
 2024-03-01 16:43:24 -08:00
Kirill Bulatov 48290e893a When clicking the checkbox, toggle open the LSP trace logs (#8689) 
Before this change, enabling LSP trace checkbox closed the panel and
toggled the server logs on.
Now, the newly enabled trace logs are shown instead.

Release Notes:

- Improved LSP logs checkbox behavior
 2024-03-02 02:03:30 +02:00
Max BrunsfeldMarshallNathanMarshall Bowers
 		cf930d26ca Add initial support for defining language server adapters in WebAssembly-based extensions (#8645) 
This PR adds **internal** ability to run arbitrary language servers via
WebAssembly extensions. The functionality isn't exposed yet - we're just
landing this in this early state because there have been a lot of
changes to the `LspAdapter` trait, and other language server logic.

## Next steps

* Currently, wasm extensions can only define how to *install* and run a
language server, they can't yet implement the other LSP adapter methods,
such as formatting completion labels and workspace symbols.
* We don't have an automatic way to install or develop these types of
extensions
* We don't have a way to package these types of extensions in our
extensions repo, to make them available via our extensions API.
* The Rust extension API crate, `zed-extension-api` has not yet been
published to crates.io, because we still consider the API a work in
progress.

Release Notes:

- N/A

---------

Co-authored-by: Marshall <marshall@zed.dev>
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
 2024-03-01 16:00:55 -08:00