Commit Graph
39175 Commits
Author SHA1 Message Date
Kirill Bulatov a3573d9b4c Display something 2023-12-20 18:23:08 +02:00
Kirill Bulatov cff6dd2450 Add new panels into zed2 2023-12-20 18:23:08 +02:00
Kirill Bulatov 6afd8661c0 Uncomment tests 2023-12-20 18:23:08 +02:00
Kirill Bulatov 8147706439 Finish all but the styling 2023-12-20 18:23:08 +02:00
Kirill Bulatov da8c4e8ae3 Apply more fixes to the visual part 2023-12-20 18:23:08 +02:00
Kirill Bulatov 8b78f3b3f0 First fixes 2023-12-20 18:23:08 +02:00
Kirill Bulatov 401c06935e Create a new crate 2023-12-20 18:23:08 +02:00
Marshall Bowers 04bfd3f7fe Style links in terminal (#3736)
This PR styles links in the terminal using the colors from the theme.

Release Notes:

- N/A
2023-12-20 10:57:15 -05:00
Antonio Scandurra cbfec6c8b6 Perform a bounds check when allocating in the arena (#3735)
This ensures we don't invoke undefined behavior when overflowing.

Release Notes:

- N/A
2023-12-20 16:56:14 +01:00
Nathan SoboandAntonio 6683cb8ea8 Clear pending click state when dragging
Once a drag starts, we won't fire click listeners or style any elements
as active.

Co-Authored-By: Antonio <antonio@zed.dev>
2023-12-20 08:55:18 -07:00
Nathan SoboandAntonio d53458ed58 Perform a bounds check when allocating in the arena
This ensures we don't invoke undefined behavior when overflowing.

Co-Authored-By: Antonio <antonio@zed.dev>
2023-12-20 08:20:00 -07:00
Antonio Scandurra caa8cd698d Show button as selected if screen sharing is on (#3734)
Release Notes:

- N/A
2023-12-20 14:44:24 +01:00
Antonio Scandurra 3bf0a943ed Show a "disconnected overlay" when project becomes read-only (#3733)
<img width="1136" alt="image"
src="https://github.com/zed-industries/zed/assets/482957/9daaf21a-90d6-4074-9c65-360df5661221">


Release Notes:

- N/A
2023-12-20 14:18:15 +01:00
Antonio Scandurra 98eae94aa2 Show button as selected if screen sharing is on 2023-12-20 14:17:15 +01:00
Antonio Scandurra 7043312451 Render disconnected overlay when project becomes readonly 2023-12-20 14:10:59 +01:00
Antonio Scandurra 41b1b8c2ac Disable focus when disconnecting from host 2023-12-20 14:10:56 +01:00
Antonio Scandurra a191e527bf Introduce InteractiveElement::capture_any_mouse_{down,up} 2023-12-20 14:00:12 +01:00
Antonio Scandurra d80c00a981 Use InteractiveBounds everywhere we change the cursor style 2023-12-20 13:59:52 +01:00
Piotr Osiewicz f1d3cab4be Popover buttons titlebar (#3732)
Migrate project picker/vcs menu to use popover_menu.

Release Notes:
- N/A
2023-12-20 12:47:53 +01:00
Antonio Scandurra bc4bf73ddd Fix sluggish experience when dragging tabs (#3731)
The problem was caused by a missing call to `WindowContext::notify` when
moving the mouse. Actually, we *did* notify as part of a
`MouseMoveEvent` listener registered in `Interactivity` but that code
path was never exercised because we were clearing the
`pending_mouse_down`.

This pull request fixes the issue by automatically redrawing the window
in gpui when there is an active drag and the mouse moves.

Release Notes:

- N/A
2023-12-20 11:34:09 +01:00
Antonio Scandurra 4a9545870f Fix sluggish experience when dragging tabs
The problem was caused by a missing call to `WindowContext::notify` when
moving the mouse. Actually, we *did* notify as part of a `MouseMoveEvent`
listener registered in `Interactivity` but that code path was never
exercised because we were clearing the `pending_mouse_down`.

This commit fixes the issue by automatically redrawing the window in gpui
when there is an active drag and the mouse moves.
2023-12-20 11:21:55 +01:00
Max Brunsfeld a27b9afbcb Ensure that new view observers are called by WindowContext::replace_root_view (#3730)
This fixes a bug where the window got into a bad, non-interactive state
when opening a project from an empty window.
2023-12-19 17:16:30 -08:00
Max Brunsfeld a4122f387c Ensure that new view observers are called by WindowContext::replace_root_view 2023-12-19 17:04:42 -08:00
Max Brunsfeld a321beb15e Fix layout of diagnostic blocks (#3729)
Previously, all of the lines in a multi-line error message were painted
on top of each other. I also simplified the logic for highlighting
backtick-enclosed ranges in a diagnostic message.
2023-12-19 15:49:56 -08:00
Marshall Bowers 6d141d833d Style go-to-definition links (#3727)
This PR styles go-to-definition links using the link color from the
theme.

Release Notes:

- N/A
2023-12-19 18:41:45 -05:00
Max Brunsfeld e7d7c4b055 Fix layout of diagnostic blocks 2023-12-19 15:41:00 -08:00
JuliaandAntonio Scandurra 9362e6f11e Reintroduce LSP diagnostic/status message
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-12-19 18:38:25 -05:00
Marshall Bowers 803ff5b096 Map textLink.activeForeground from VS Code to link_text_hover 2023-12-19 18:29:27 -05:00
Marshall Bowers 38a30560ff Use link_text_hover for go-to-definition links 2023-12-19 18:24:52 -05:00
Marshall Bowers c2154e3805 Style pane drop targets (#3726)
This PR styles the pane drop targets using the `drop_target_background`
color from the theme.

We do have to adjust the alpha channel of the color so that it doesn't
obscure the contents of the buffer.

Release Notes:

- N/A
2023-12-19 18:06:21 -05:00
Marshall Bowers ef7231e167 Style tab drop targets for project entries (#3725)
This PR styles the drop targets when dragging a project entry onto a tab
or the tab bar.

I also adjusted the existing tab drop targets to use the
`drop_target_background` from the theme.

Release Notes:

- N/A
2023-12-19 17:45:42 -05:00
Max Brunsfeld 3edb17c964 Make collab panel usable from the keyboard, add missing styling (#3724)
* allow confirming all items via the keyboard
* allow deploying the channel context menu via the keyboard
* add missing selected styling for list items
2023-12-19 14:33:56 -08:00
Max Brunsfeld 2ca38d8863 Add missing selected state and keyboard action for some collab panel items 2023-12-19 14:16:44 -08:00
Max Brunsfeld 112b2fcf39 Don't reset the collab panel when it loses focus 2023-12-19 14:12:29 -08:00
Max Brunsfeld 541ae5993d Restrcit context for some editor bindings that don't apply to single-line editors 2023-12-19 14:11:59 -08:00
Kirill Bulatov 8dfe7eecae Better display items from different sources with different z-indices in the same place (#3723) 2023-12-20 00:01:37 +02:00
Kirill BulatovandAntonio Scandurra 2ac6f36ab4 Tidy up z-index handling
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-12-19 23:50:42 +02:00
Marshall Bowers fbc2d8d65f Fix typo in ButtonCommon doc comment (#3722)
This PR fixes a small typo in the doc comments for `ButtonCommon`.

Was waiting to roll this up into another PR, but it never ended up
happening.

Release Notes:

- N/A
2023-12-19 16:32:57 -05:00
Kirill Bulatov 13b50e5502 Optimize stack id in-memory layout 2023-12-19 23:31:17 +02:00
Kirill BulatovandAntonio Scandurra b4932b264e Fix more z-index and rendering issues
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-12-19 23:30:17 +02:00
bdad88c207 Initial fix of the z-index
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2023-12-19 23:29:08 +02:00
Marshall Bowers d5b97db646 Fix typo in "Quote Selection" tooltip (#3721)
This PR fixes a typo in the "Quote Selection" tooltip.

Release Notes:

- N/A
2023-12-19 16:21:58 -05:00
Marshall Bowers cbaa666ebe Apply padding at the toolbar level (#3720)
This PR adjusts the padding in the toolbar to be applied within the
toolbar itself.

Previously the different elements within the toolbar were applying their
own padding, which led to inconsistencies.

Release Notes:

- N/A
2023-12-19 16:01:03 -05:00
Max Brunsfeld 4162c74b39 Add missing collab panel features (#3719)
* channel modal
* channel invites in collab panel
2023-12-19 12:16:01 -08:00
Max BrunsfeldandNathan e6458a9b07 Clean up commented code
Co-authored-by: Nathan <nathan@zed.dev>
2023-12-19 12:06:47 -08:00
Max BrunsfeldandNathan cf11738a38 Implement channel modal
Co-authored-by: Nathan <nathan@zed.dev>
2023-12-19 12:02:35 -08:00
Marshall Bowers b9a96abb00 Use child instead of children (#3718)
This PR refactors some code where we were using `children` when we could
have used `child` instead.

Release Notes:

- N/A
2023-12-19 13:49:52 -05:00
Max Brunsfeld 2e3bb03a0d wip 2023-12-19 10:20:40 -08:00
Max Brunsfeld ed56527860 Render channel invites in collab panel, fix unused warnings 2023-12-19 10:20:40 -08:00
Marshall Bowers f4e1fdbe0b Style contact finder (#3717)
This PR styles the contact finder.

<img width="598" alt="Screenshot 2023-12-19 at 12 59 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ca9d9345-bf27-4256-aabc-6017a0c4d217">

Release Notes:

- N/A
2023-12-19 13:16:14 -05:00