Commit Graph
39175 Commits
Author SHA1 Message Date
Max Brunsfeld 91bb4809f2 Fix channel move cancel (#3004)
Release Notes:

- Fixes a bug where channels could no longer be rearranged with drag and
drop.
2023-09-21 09:11:09 -07:00
Mikayla c4a0267642 Switch drag end event to be fired after mouse up 2023-09-21 08:58:36 -07:00
Nate Butler 2c4b375d39 Correct icon_margin_scale 2023-09-21 11:57:35 -04:00
Piotr Osiewicz 1da3ed5c4c [WIP] Replace in project (#2984)
Targeting Preview of 09.27.
This is still pending several touchups/clearups:
- We should watch multibuffer for changes and rescan the excerpts. This
should also update match count.
- Closing editor while multibuffer with 100's of changed files is open
leads to us prompting for save once per each file in the multibuffer.
One could in theory save in multibuffer before closing it (thus avoiding
unnecessary prompts), but it'd be cool to be able to "Save all"/"Discard
All".

Release Notes:

- Added "Replace in project" functionality
2023-09-21 16:27:58 +02:00
Kirill Bulatov 6d87fc4e17 Supplementary LSP server log improvements (#3002)
Follow-up of https://github.com/zed-industries/zed/pull/2991 improving
rough edges around supplementary LSP servers:

* Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1695281196667609
Copilot init panic
* Makes LSP server list scrollable in the panel
* Shows supplementary servers' RPC logs in the panel

Release Notes:

- N/A
2023-09-21 11:22:56 +03:00
Kirill Bulatov 70b0f10ef9 Properly re-add Copilot LSP server 2023-09-21 11:02:03 +03:00
Kirill Bulatov 4d2f4d0e1a Fix RPC logs not being displayed for supplementary servers 2023-09-21 11:00:05 +03:00
Kirill BulatovandMax 6400a2cb03 Make LSP panel scrollable
co-authored-by: Max <max@zed.dev>
2023-09-21 10:59:19 +03:00
Nathan Sobo 4769f8dc4d WIP - Next: implement Element derive macro 2023-09-20 22:26:46 -06:00
Conrad Irwin 6e501de8e2 Code review changes 2023-09-20 21:29:45 -06:00
Conrad Irwin fdf7793e3d Revert accidental Cargo change 2023-09-20 20:50:22 -06:00
Conrad Irwin 8c9233436d Fix save related tests, and refactor saves again 2023-09-20 20:44:42 -06:00
Conrad Irwin 89c569e0b1 Fix backward search from command 2023-09-20 20:44:42 -06:00
Conrad Irwin e85104ab0b Iron out some edge-cases 2023-09-20 20:44:42 -06:00
Conrad Irwin 12cbf801f3 Flesh out v1.0 of vim : 2023-09-20 20:44:41 -06:00
Conrad Irwin 376f80d966 Add NewFileInDirection 2023-09-20 20:44:26 -06:00
Conrad Irwin e1be209367 Merge Workspace::save_item into Pane::save_item
These methods were slightly different which caused (for example) there
to be no "Discard" option in the conflict case at the workspace level.

To make this work, a new SaveBehavior (::PromptForNewPath) was added to
support SaveAs.
2023-09-20 20:44:26 -06:00
Conrad Irwin e0b746fbee tests: wait deterministically after simulating_keystrokes 2023-09-20 20:44:26 -06:00
Conrad Irwin 1b77522c2f Ensure the picker waits for pending updates
Particularly in development builds (and in tests), when typing in the
command palette, I tend to hit enter before the suggestions have
settled.
2023-09-20 20:44:26 -06:00
Conrad Irwin 78fdde1e6e Fix vim tests on my machine
In a rare case of "it broke on my machine" I haven't been able to run
the vim tests locally for a few days; turns out I ran out of swap file
names...
2023-09-20 20:44:26 -06:00
Conrad Irwin ee0a229996 Add vim-specific interactions to command
This mostly adds the commonly requested set (:wq and friends) and
a few that I use frequently
:<line> to go to a line number
:vsp / :sp to create a split
:cn / :cp to go to diagnostics
2023-09-20 20:44:26 -06:00
Nathan Sobo 684913d974 WIP 2023-09-20 20:40:30 -06:00
Nathan Sobo f26176215a WIP 2023-09-20 20:28:32 -06:00
Max Brunsfeld 694ad1b675 collab 0.22.1 2023-09-20 17:39:21 -07:00
Max Brunsfeld 7ec8e1d1ec Fix select all bugs (#3001)
Release Notes:

- Restore `cmd-shift-d` as 'editor::DuplicateLine' and move
`editor::SelectAllMatches` to `cmd-shift-L`, like in VS Code. The
previous action for `cmd-shift-l`, `editor::SplitSelectionIntoLines`,
has been moved to the sublime base keymap.
- Fixes a panic when using 'editor::SelectAllMatches'  on an empty line.
2023-09-20 17:21:10 -07:00
Mikayla 043f998a97 fix default keybindings for select all matches 2023-09-20 17:14:19 -07:00
Mikayla e73220b2d4 Fix panic on select all when query is empty 2023-09-20 17:10:23 -07:00
Mikayla Maki 0c85e0ae9f Fix bugs from channel moving (#3000)
This PR fixes several bugs related to channel moving and it's
unintuitive behavior when attempting to re-order channels

Release Notes:

- N/A
2023-09-20 17:01:14 -07:00
MikaylaandMax 48a48d18d0 Fix bug in channel rendering
Fix drag and drop stale state bug revealed by the channel panel

co-authored-by: Max <max@zed.dev>
2023-09-20 16:40:29 -07:00
Conrad Irwin 66226ea84f vim fixes for find&replace (#2995)
* allow replacing with the empty string to delete
* fix <enter> for ReplaceNext (in vim mode)

Release Notes:

- allow replacement to be empty
2023-09-20 16:42:39 -06:00
MikaylaandMax 0cee12f6eb Fix bugs in moving channels that could cause channels to be stranded or moved unexpectedly
Made channel linking not query in a loop

co-authored-by: Max <max@zed.dev>
2023-09-20 15:32:06 -07:00
Max Brunsfeld 4e84d03d4c Fix opening channel notes from collab panel context menu (#2998)
Release Notes:

- Fixed a bug where the 'Open Notes' action in the collaboration panel
context menu didn't work (preview only).
2023-09-20 13:55:23 -07:00
Max Brunsfeld 992a86aada Fix opening channel notes from context menu 2023-09-20 13:45:35 -07:00
Nathan Sobo ad9d487142 WIP 2023-09-20 14:32:55 -06:00
Conrad Irwin 6bc64f9425 Fix vim panic when over-shooting with j (#2997)
Release Notes:

- vim: fix a panic when using `j` to go beyond end of file
2023-09-20 12:17:07 -06:00
Nathan Sobo 752f2f8b9b Checkpoint 2023-09-20 12:16:26 -06:00
Conrad Irwin 20ad2c41c8 Fix vim test recording 2023-09-20 12:01:04 -06:00
Joseph T. Lyons 98d8ed590d collab 0.22.0 2023-09-20 13:59:36 -04:00
Nate Butler f78dd3960a Add an initial set of GPUI2 components to the storybook (#2990)
This PR adds an initial set of components to `crates/storybook/src/ui`.

All changes still are contained to inside storybook. Merging to keep up
to date with main.
2023-09-20 13:52:47 -04:00
Conrad Irwin 4a5e44a9ef Fix vim panic when over-shooting with j 2023-09-20 11:20:35 -06:00
Nate Butler fe77f15487 Update tracker.md 2023-09-20 13:08:20 -04:00
Joseph T. Lyons 351e9100e6 v0.106.x dev 2023-09-20 13:02:13 -04:00
Nate Butler f5fbedf9e5 WIP Project Tracker 2023-09-20 12:53:08 -04:00
Kyle Caverly 5d7ec08095 Keyboard navigation and setting persistence for project search (#2996)
Enable keyboard shortcuts for Project Search modes, and ensure project
search settings are persisted search to search.

Release Notes:

- Added alt-cmd-s to Toggle Semantic Search Mode
- Added alt-cmd-g to Toggle Regex Search Mode
- Added alt-cmd-x to Toggle Text Search Mode
- Defaulted new project searches to using last used search mode and
settings.
2023-09-20 12:44:30 -04:00
Joseph T. Lyons d9389fbfb6 Add select all command to the editor (#2963)
Equivalent to hitting cmd-d as many times as possible

cc: @JosephTLyons this PR needs a bit of work on user-facing naming and
interactions:
- [x] ~~I thought cmd-shift-d would be nice for this action, but that is
already taken by a sublime key binding. Could we use the VSCode binding?
I left the sublime text binding in but commented out.~~ Gonna just leave
it as is
- [x] ~~I went through 'SelectAllMatches' and 'SelectAll' as names for
this action, but ran into conflicts with the buffer search action and
the existing SelectAll (`cmd-a`) action. I decided to go with
`SelectNextAll`, but could use your help here.~~ Decided to go with
'SelectAllMatches'

Release Notes:
- Added a `editor::SelectAllMatches` command, bound to `cmd-shift-d`,
for selecting all matching occurrences under your selection. Note that
this has replaced the previous binding for `editor::DuplicateLine`.
2023-09-20 12:42:23 -04:00
KCaverly 57f49a6530 remove conditional action registration for activate semantic search mode 2023-09-20 12:38:29 -04:00
Mikayla 8c8fc4aef6 Only autoscroll on select_next operations 2023-09-20 09:31:12 -07:00
Nathan Sobo a06e8dbfd7 Checkpoint 2023-09-20 10:17:29 -06:00
KCaverly e7a0476a76 enable project search states to persist between workspace project searches 2023-09-20 12:12:01 -04:00
Mikayla 71df613d1c Fix rebase 2023-09-20 08:34:18 -07:00