Kirill Bulatov 5e99d0e61f Fix completion labels becoming overly large due to LSP completion items with newlines (#23407) ...

Reworks https://github.com/zed-industries/zed/pull/23030 and
https://github.com/zed-industries/zed/pull/15087
Closes https://github.com/zed-industries/zed/issues/23352
Closes https://github.com/zed-industries/zed/issues/23310 

Zed's completion items use `label` from LSP completion items as a base
to show in the list:
https://github.com/zed-industries/zed/blob/d290da7dac922fdc67c4774cdd371fba23fe62e3/crates/project/src/lsp_store.rs#L4371-L4374

Besides that, certain language plugins append `detail` or
`label_details.description` as a suffix:
https://github.com/zed-industries/zed/blob/d290da7dac922fdc67c4774cdd371fba23fe62e3/crates/languages/src/vtsls.rs#L178-L188

Either of these 3 properties may return `\n` (or multiple) in it,
spoiling Zed's completion menu, which uses `UniformList` to render those
items: a uniform list uses common, minimum possible height for each
element, and `\n` bloats that overly.

Good approach would be to use something else:
https://github.com/zed-industries/zed/issues/21403 but that has its own
drawbacks and relatively hard to use instead (?).

We could follow VSCode's approach and move away all but `label` from
`CodeLabel.text` to the side, where the documentation is, but that does
not solve the issue with `details` having newlines.

So, for now, sanitize all labels and remove any newlines from them. If
newlines are found, also replace whitespace sequences if there's more
than 1 in a row.

Later, this approach can be improved similarly to how Helix and Zed's
inline completions do: rendering a "ghost" text, showing the
completion's edit applied to the editor.

Release Notes:

- Fixed completion labels becoming overly large due to LSP completion
items with newlines

2025-01-21 17:55:41 +02:00

..

lsp_command

use ssh lsp store (#17655)

2024-09-10 15:51:01 -04:00

buffer_store.rs

deps: Bump smol to 2.0 (#22956)

2025-01-10 13:38:00 +00:00

color_extractor.rs

Simplify static expression to a constant (#23193)

2025-01-15 19:31:21 +00:00

connection_manager.rs

chore: Fix several style lints (#17488)

2024-09-06 11:58:39 +02:00

debounced_delay.rs

chore: Fix several style lints (#17488)

2024-09-06 11:58:39 +02:00

direnv.rs

Environment loading fixes (#19144)

2024-10-16 12:14:40 +02:00

environment.rs

environments: Don't load shell environments in non-local worktrees (#23138)

2025-01-14 17:13:55 +00:00

git.rs

git: Implement commit creation (#23263)

2025-01-17 18:51:20 +00:00

image_store.rs

image viewer: Allow dropping images on pane (#21803)

2024-12-10 15:01:14 +01:00

lsp_command.rs

Include display text for LSP commands in errors (#23012)

2025-01-11 21:59:06 +00:00

lsp_ext_command.rs

Include display text for LSP commands in errors (#23012)

2025-01-11 21:59:06 +00:00

lsp_store.rs

Fix completion labels becoming overly large due to LSP completion items with newlines (#23407)

2025-01-21 17:55:41 +02:00

prettier_store.rs

Add .prettierignore support (#21297)

2024-12-12 15:45:44 -08:00

project_settings.rs

Document git.gutter_debounce setting (#22663)

2025-01-06 18:33:04 +00:00

project_tests.rs

windows: Fix FS-related issues (#23369)

2025-01-21 14:19:23 +08:00

project.rs

Fix project entry rename in Remote Development (#23382)

2025-01-21 12:48:40 +01:00

search_history.rs

project search: Persist search history across session (#9932)

2024-04-02 11:13:18 +02:00

search.rs

Use static LazyLocks for all constant regexes (#22225)

2024-12-19 02:20:35 +00:00

task_inventory.rs

Move git status out of Entry (#22224)

2025-01-04 01:00:16 +00:00

task_store.rs

Fix active line number highlight (#23266)

2025-01-17 01:23:28 +00:00

terminals.rs

vim: ! support (#23169)

2025-01-16 21:19:15 -07:00

toolchain_store.rs

toolchains: Run listing tasks on background thread (#21414)

2024-12-02 21:03:31 +01:00

worktree_store.rs

Fix project entry rename in Remote Development (#23382)

2025-01-21 12:48:40 +01:00

yarn.rs

chore: Fix several style lints (#17488)

2024-09-06 11:58:39 +02:00